Moodle

"Attempts: nnn" ignores group mod / accessallgroups

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9
  • Component/s: Quiz
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

First, I've prevented the "accessallgroups" capability of Non-editing teacher role. Hence, in quiz module, he can only see his own groups. However, the "x Students have made x" statistic is still showing a total of all participants.

This statistic is listed in the index, info and report page.

Activity

Hide
Tim Hunt added a comment -

In Moodle 1.9, this has changed to the simpler "Attempts: nnn", but it still does not take note of groups. However, the FIVE different places where this string used to be produced have now been merged into a single function, so it should be easier to fix in 1.9 now (but not really possible to back-port).

Show
Tim Hunt added a comment - In Moodle 1.9, this has changed to the simpler "Attempts: nnn", but it still does not take note of groups. However, the FIVE different places where this string used to be produced have now been merged into a single function, so it should be easier to fix in 1.9 now (but not really possible to back-port).
Hide
Tim Hunt added a comment -

Actually, there are three cases to consider:

1. You are looking at a report, and you have selected to view the results for
one group.

2. You are looking at a page like the quiz info page, where there is no clear
concept of the current group, but groups are in force, and you are in one or
more groups.

3. No groups in use of the course/quiz, or you are not associated with any
particular groups (e.g. admin on the quiz intro page).

In case 3. we want to keep the current wording [Attempts: 123]

In case 1. we need to reflect the currently selected group, so [Attempts 123
(45 from this group)]

In case 2. I think we need a wording like [Attempts 123 (67 from your groups)]

I also took the opportunity to improve the layout of this message slightly, and clarify the message that tells you that you cannot add or remove questions from the quiz if there are attemts.

Show
Tim Hunt added a comment - Actually, there are three cases to consider: 1. You are looking at a report, and you have selected to view the results for one group. 2. You are looking at a page like the quiz info page, where there is no clear concept of the current group, but groups are in force, and you are in one or more groups. 3. No groups in use of the course/quiz, or you are not associated with any particular groups (e.g. admin on the quiz intro page). In case 3. we want to keep the current wording [Attempts: 123] In case 1. we need to reflect the currently selected group, so [Attempts 123 (45 from this group)] In case 2. I think we need a wording like [Attempts 123 (67 from your groups)] I also took the opportunity to improve the layout of this message slightly, and clarify the message that tells you that you cannot add or remove questions from the quiz if there are attemts.
Hide
Tim Hunt added a comment -

By the way, I don't think it is a problem that people without moodle/site:accessallgroups can see the total number. It is not very critical information (this and more in available in the gradebook). On the other hand, it may often be useful to be able to compare what is happening in your group with the course overall.

Show
Tim Hunt added a comment - By the way, I don't think it is a problem that people without moodle/site:accessallgroups can see the total number. It is not very critical information (this and more in available in the gradebook). On the other hand, it may often be useful to be able to compare what is happening in your group with the course overall.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: