Moodle

Data activity "file" field's output should be filtered - since MDL-6635 it's not

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Won't Fix
  • Affects Version/s: 1.8
  • Fix Version/s: None
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE

Description

The fixing of MDL-6635 changed the database activity's behaviour slightly. The "file" activity outputs a link to a file when in browse mode, and in 1.7.x this would be filtered so that (e.g.) the mediaplugin filter or the Jmol filter could automatically render these in interesting ways.

Because of the fix in MDL-6635 this no longer happens. The field types are responsible for their own filtering, and many of them do. The "file" type does not filter its self-generated link HTML, but it should do, in order to re-enable this behaviour. My patch for doing this is included below. I will commit it if there are no objections - please let me know.

RCS file: /cvsroot/moodle/moodle/mod/data/field/file/field.class.php,v
retrieving revision 1.16
diff -r1.16 field.class.php
108c108
< '<a href="'.$source.'/'.$src.'" >'.$name.'</a>';

> format_text('<a href="'.$source.'/'.$src.'" >'.$name.'</a>', FORMAT_HTML);

Issue Links

Activity

Hide
Michael de Raadt added a comment -

Thanks for reporting this issue.

We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

Michael d;

lqjjLKA0p6

Show
Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
Hide
Michael de Raadt added a comment -

I'm closing this issue as it has become inactive and does not appear to affect a current supported version. If you are encountering this problem or one similar, please launch a new issue.

Show
Michael de Raadt added a comment - I'm closing this issue as it has become inactive and does not appear to affect a current supported version. If you are encountering this problem or one similar, please launch a new issue.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: