Issue Details (XML | Word | Printable)

Key: MDL-9476
Type: Bug Bug
Status: Open Open
Priority: Critical Critical
Assignee: Michael Penney
Reporter: Ivana Bosnic
Votes: 1
Watchers: 4
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

moddata/lesson not included in lesson backup

Created: 21/Apr/07 04:55 AM   Updated: 23/Feb/09 05:05 PM
Component/s: Backup, Lesson
Affects Version/s: 1.8
Fix Version/s: 2.0

Database: MySQL
Participants: Eloy Lafuente (stronk7), Ivana Bosnic, Mark Nielsen and Michael Penney
Security Level: None
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
After the lesson backup (including the user data), moddata/lesson directory is not included in the backup file. As a consequence, all the lesson images are lost in a restore.

Images were inserted using Import PowerPoint option.



 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) added a comment - 21/Apr/07 04:28 PM
This goes to Michael...

Michael Penney added a comment - 21/Apr/07 11:29 PM
I'm going to pass this to Mark.

Mark Nielsen added a comment - 24/May/07 12:41 AM
Did you include course files in the backup? I don't think lesson should not do its own file backup/restore.

Ivana Bosnic added a comment - 27/May/07 03:57 AM
Yes, I checked the "user data" next to the lesson, and also included Course files. The images are originally in moddata/lesson/lesson_name, and they are not copied in the backup ZIP.

Mark Nielsen added a comment - 29/May/07 12:54 AM
Looked through the backup code and it looks like the modules are responsible for backing up content in the moddata directory. When I coded this, I was not too clever about the directory naming structure Should be moddata/lesson/lessonid. Since I used the lesson name, there is no way to identify 100% of the time which directories in moddata/lesson actually need to be backed up.

The solution might be that we convert to the proper method and then any new imports would work with backup/restore automatically while old imports the files will have to be moved manually.

I think just copying over the whole moddata/lesson directory every time is not a good solution because it could copy over data that is not needed (EG: user data is not selected for a specific lesson).


Michael Penney added a comment - 23/Feb/09 05:05 PM
Going to need to fix this in 2.0 or drop powerpoint import - this was my bad idea, since MS changes the structure of the powerpoint export this is very expensive to maintain.