Moodle

Show final grades from new gradebook in Quiz UI

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.9.2
  • Fix Version/s: 1.9.5
  • Component/s: Gradebook, Quiz
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Show final grades from new gradebook in Quiz UI - optionally allow overriding of grades

  • quiz uses several methods to find the resulting grade (setting in activity edit page)
  • the final grade is not visible in reports

The idea is to get the final grade for each test and display it - both student view/teacher view; I would be good to indicate why is the grade different - overrided or conversion constants used

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

Petr, are you expecting me to do this? I'm pretty busy this week.

Show
Tim Hunt added a comment - Petr, are you expecting me to do this? I'm pretty busy this week.
Hide
Permalink
Martin Dougiamas added a comment -

This needs to be done before Beta.

Show
Martin Dougiamas added a comment - This needs to be done before Beta.
Hide
Permalink
Martin Dougiamas added a comment -

Currently this is the last blocker for 1.9 beta

Show
Martin Dougiamas added a comment - Currently this is the last blocker for 1.9 beta
Hide
Permalink
Petr Škoda (skodak) added a comment -

Working on it

Show
Petr Škoda (skodak) added a comment - Working on it
Hide
Permalink
Martin Dougiamas added a comment -

yoo hoo!

Show
Martin Dougiamas added a comment - yoo hoo!
Hide
Permalink
AjnabiZ added a comment -

Any news

Show
AjnabiZ added a comment - Any news
Hide
Permalink
Martin Dougiamas added a comment -

Hi, Petr ... this is resolved now, no?

Show
Martin Dougiamas added a comment - Hi, Petr ... this is resolved now, no?
Hide
Permalink
Martin Dougiamas added a comment -

Petr ....

Show
Martin Dougiamas added a comment - Petr ....
Hide
Permalink
Petr Škoda (skodak) added a comment -

going to implement change in student UI - show the result from gradebook instead from module results table (the same as in assignment)
patch should be ready today...

Show
Petr Škoda (skodak) added a comment - going to implement change in student UI - show the result from gradebook instead from module results table (the same as in assignment) patch should be ready today...
Hide
Permalink
Tim Hunt added a comment -

Petr, I don't think we can do exactly what the assignment does, because an assignment has just one grade given by the teacher. A quiz has a grade calculated from individual question scores in a way that the student can check. This screenshot shows the kind of thing that might confuse a student.

Show
Tim Hunt added a comment - Petr, I don't think we can do exactly what the assignment does, because an assignment has just one grade given by the teacher. A quiz has a grade calculated from individual question scores in a way that the student can check. This screenshot shows the kind of thing that might confuse a student.
Hide
Permalink
Tim Hunt added a comment -

Instead, I propose this:

When showing an overridden grade from the gradebook :

  • change the label to "Final grade:"
  • include underneath that heading the notice "You final grade for this quiz was manually adjusted" (if you can think of a better wording than that, great!)

Also, if there is a teacher's comment, it would be nice to show this on the quiz view page too, under the score.

Thanks for doing this.

Show
Tim Hunt added a comment - Instead, I propose this: When showing an overridden grade from the gradebook :
  • change the label to "Final grade:"
  • include underneath that heading the notice "You final grade for this quiz was manually adjusted" (if you can think of a better wording than that, great!)
Also, if there is a teacher's comment, it would be nice to show this on the quiz view page too, under the score. Thanks for doing this.
Hide
Permalink
Petr Škoda (skodak) added a comment - - edited

assigning to Tim,
please review/commit patch and fix CSS if needed

Show
Petr Škoda (skodak) added a comment - - edited assigning to Tim, please review/commit patch and fix CSS if needed
Hide
Permalink
Tim Hunt added a comment -

Petr, please review what I have done, once it shows up in the version control tab here. I think it makes sense though.

Show
Tim Hunt added a comment - Petr, please review what I have done, once it shows up in the version control tab here. I think it makes sense though.
Hide
Permalink
Nicolas Connault added a comment -

Tim, I've just tested this and it doesn't seem to work. I came across several issues:

1. Once a student had attempted a quiz, the grade was entered into the gradebook, but I could not override it using the quickgrading interface. I could, however, edit the grade individually and set it as 'overridden'
2. Once I had overridden the student's grade, I went back to the quiz report to see if my change was visible: it was not.
3. Entering grades in the gradebook for students who had not yet attempted the quiz was erratic: sometimes it recorded it, sometimes not. But none of these affected the results shown in the quiz reports

Show
Nicolas Connault added a comment - Tim, I've just tested this and it doesn't seem to work. I came across several issues: 1. Once a student had attempted a quiz, the grade was entered into the gradebook, but I could not override it using the quickgrading interface. I could, however, edit the grade individually and set it as 'overridden' 2. Once I had overridden the student's grade, I went back to the quiz report to see if my change was visible: it was not. 3. Entering grades in the gradebook for students who had not yet attempted the quiz was erratic: sometimes it recorded it, sometimes not. But none of these affected the results shown in the quiz reports
Hide
Permalink
Tim Hunt added a comment -

Overridden grades are only visible on the quiz view page, not in the quiz reports, at least in 1.9. This may change as part of the work Jamie is doing on the quiz reports for 2.0, but it may not.

Show
Tim Hunt added a comment - Overridden grades are only visible on the quiz view page, not in the quiz reports, at least in 1.9. This may change as part of the work Jamie is doing on the quiz reports for 2.0, but it may not.
Hide
Permalink
Nicolas Connault added a comment -

Tim, following my tests, it appears that:

1. The overridden grade is not visible to the admin/teacher on any quiz page
2. The overridden grade is not visible to the student whose grade was overridden: the original grade only is visible on the view page

Show
Nicolas Connault added a comment - Tim, following my tests, it appears that: 1. The overridden grade is not visible to the admin/teacher on any quiz page 2. The overridden grade is not visible to the student whose grade was overridden: the original grade only is visible on the view page
Hide
Permalink
Tim Hunt added a comment -

Drat, OK. I'll look into this again when I get a moment.

Show
Tim Hunt added a comment - Drat, OK. I'll look into this again when I get a moment.
Hide
Permalink
Martin Dougiamas added a comment -

Ping ping ping ping!

Show
Martin Dougiamas added a comment - Ping ping ping ping!
Hide
Permalink
Tim Hunt added a comment -

Groan groan groan groan

Show
Tim Hunt added a comment - Groan groan groan groan
Hide
Permalink
Tim Hunt added a comment -

This was working! The overridden grade from the gradebook is visible in the quiz UI.

There was one tiny detail missing: The message "Your final grade from this activity was manually adjusted." was only being shown if the quiz was closed, or you had used up all your attempts. I have fixed that.

The bit about overridden grades not being visible to teachers in the quiz UI is MDL-14768. I'll work on that after the current discussions about grades have played out.

Show
Tim Hunt added a comment - This was working! The overridden grade from the gradebook is visible in the quiz UI. There was one tiny detail missing: The message "Your final grade from this activity was manually adjusted." was only being shown if the quiz was closed, or you had used up all your attempts. I have fixed that. The bit about overridden grades not being visible to teachers in the quiz UI is MDL-14768. I'll work on that after the current discussions about grades have played out.
Hide
Permalink
Nicolas Connault added a comment -

The student can see the overridden grade, but not the teacher. Sorry Tim but this is still not fixed

Show
Nicolas Connault added a comment - The student can see the overridden grade, but not the teacher. Sorry Tim but this is still not fixed
Hide
Permalink
Tim Hunt added a comment -

Nico, please re-read my last comment!

Show
Tim Hunt added a comment - Nico, please re-read my last comment!

People

Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.