Issue Details (XML | Word | Printable)

Key: MDL-9647
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Petr Skoda
Reporter: Petr Skoda
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

simplify dealing with headers/footers in admin sections

Created: 01/May/07 01:06 AM   Updated: 01/May/07 01:31 AM
Return to search
Component/s: Administration
Affects Version/s: 1.7, 1.8
Fix Version/s: 1.9

Participants: Petr Skoda
Security Level: None
Resolved date: 01/May/07
Affected Branches: MOODLE_17_STABLE, MOODLE_18_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
The problem is in use of $adminroot - its value is the same as global $ADMIN, there is no need to pass it around in function parameters.
Also we could allow using of normal print_footer() because we can detect if we printed special admin header before.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda committed 67 files to 'Moodle CVS' - 01/May/07 01:08 AM
MDL-9647 simplify dealing with headers/footers in admin sections
MODIFY admin/report/courseoverview/index.php   Rev. 1.16    (+5 -7 lines)
MODIFY course/report/stats/report.php   Rev. 1.17    (+3 -10 lines)
MODIFY user/profile/definelib.php   Rev. 1.5    (+7 -7 lines)
MODIFY admin/uploaduser.php   Rev. 1.60    (+6 -8 lines)
MODIFY admin/mnet/enr_hosts.php   Rev. 1.6    (+4 -5 lines)
MODIFY admin/auth_config.php   Rev. 1.11    (+3 -4 lines)
MODIFY admin/mnet/peers.html   Rev. 1.8    (+2 -2 lines)
MODIFY admin/mnet/trustedhosts.html   Rev. 1.6    (+2 -2 lines)
MODIFY admin/langimport.php   Rev. 1.35    (+9 -9 lines)
MODIFY admin/mnet/trustedhosts.php   Rev. 1.9    (+3 -4 lines)
MODIFY admin/Attic/upgradeforumread.php   Rev. 1.12    (+6 -10 lines)
MODIFY admin/mnet/mnet_review_allhosts.html   Rev. 1.3    (+2 -2 lines)
MODIFY user/profile/index.php   Rev. 1.13    (+10 -11 lines)
MODIFY admin/innodb.php   Rev. 1.8    (+5 -5 lines)
MODIFY admin/mnet/mnet_services.php   Rev. 1.6    (+1 -2 lines)
MODIFY admin/roles/manage.php   Rev. 1.51    (+10 -11 lines)
MODIFY admin/roles/assign.php   Rev. 1.51    (+6 -8 lines)
MODIFY admin/Attic/module.php   Rev. 1.25    (+5 -5 lines)
MODIFY admin/xmldb/index.php   Rev. 1.8    (+5 -5 lines)
MODIFY admin/health.php   Rev. 1.17    (+5 -5 lines)
MODIFY course/index.php   Rev. 1.75    (+5 -6 lines)
MODIFY admin/enrol_config.php   Rev. 1.15    (+4 -5 lines)
MODIFY course/category.php   Rev. 1.102    (+4 -5 lines)
MODIFY admin/lang.php   Rev. 1.95    (+7 -7 lines)
MODIFY admin/phpinfo.php   Rev. 1.9    (+4 -9 lines)
MODIFY admin/mnet/mnet_review.html   Rev. 1.8    (+2 -2 lines)
MODIFY admin/roles/Attic/allowoverride.php   Rev. 1.12    (+4 -6 lines)
MODIFY admin/modules.php   Rev. 1.41    (+5 -6 lines)
MODIFY admin/replace.php   Rev. 1.8    (+6 -10 lines)
MODIFY admin/mnet/access_control.php   Rev. 1.14    (+4 -6 lines)
MODIFY admin/Attic/stickyblocks.php   Rev. 1.15    (+4 -5 lines)
MODIFY admin/mnet/peers.php   Rev. 1.12    (+5 -6 lines)
MODIFY lib/weblib.php   Rev. 1.870    (+17 -14 lines)
MODIFY admin/auth.php   Rev. 1.61    (+3 -4 lines)
MODIFY admin/report/simpletest/Attic/index.php   Rev. 1.10    (+3 -4 lines)
MODIFY admin/roles/override.php   Rev. 1.31    (+4 -5 lines)
MODIFY course/report/log/index.php   Rev. 1.15    (+6 -8 lines)
MODIFY admin/Attic/langdoc.php   Rev. 1.20    (+9 -10 lines)
MODIFY admin/report/stats/Attic/index.php   Rev. 1.12    (+6 -8 lines)
MODIFY admin/roles/Attic/allowassign.php   Rev. 1.13    (+4 -6 lines)
MODIFY admin/environment.php   Rev. 1.18    (+4 -5 lines)
MODIFY admin/upgradesettings.php   Rev. 1.18    (+4 -5 lines)
MODIFY admin/blocks.php   Rev. 1.39    (+5 -6 lines)
MODIFY admin/Attic/filter.php   Rev. 1.18    (+4 -5 lines)
MODIFY admin/delete.php   Rev. 1.13    (+7 -7 lines)
MODIFY theme/index.php   Rev. 1.34    (+5 -6 lines)
MODIFY admin/mnet/mnet_services.html   Rev. 1.5    (+2 -2 lines)
MODIFY admin/timezoneimport.php   Rev. 1.10    (+5 -6 lines)
MODIFY files/index.php   Rev. 1.117    (+7 -9 lines)
MODIFY lib/adminlib.php   Rev. 1.134    (+13 -8 lines)
MODIFY admin/block.php   Rev. 1.18    (+5 -5 lines)
MODIFY admin/search.php   Rev. 1.15    (+4 -5 lines)
MODIFY admin/mnet/index.php   Rev. 1.14    (+7 -8 lines)
MODIFY admin/Attic/maintenance.php   Rev. 1.12    (+4 -5 lines)
MODIFY admin/report/log/Attic/index.php   Rev. 1.5    (+4 -6 lines)
MODIFY enrol/mnet/allowed_courses.php   Rev. 1.8    (+5 -6 lines)
MODIFY admin/filters.php   Rev. 1.38    (+4 -5 lines)
MODIFY admin/mnet/enr_course_enrol.php   Rev. 1.8    (+4 -5 lines)
MODIFY admin/mnet/enr_courses.php   Rev. 1.8    (+4 -5 lines)
MODIFY admin/enrol.php   Rev. 1.30    (+4 -5 lines)
MODIFY admin/oacleanup.php   Rev. 1.9    (+4 -8 lines)
MODIFY admin/multilangupgrade.php   Rev. 1.3    (+6 -10 lines)
MODIFY group/db/Attic/upgrade.php   Rev. 1.15    (+1 -2 lines)
MODIFY admin/Attic/upgradelogs.php   Rev. 1.10    (+6 -10 lines)
MODIFY user/editadvanced.php   Rev. 1.14    (+6 -7 lines)
MODIFY admin/index.php   Rev. 1.274    (+4 -4 lines)
MODIFY admin/user.php   Rev. 1.108    (+6 -6 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 01/May/07 01:13 AM
MDL-9647 simplify dealing with headers/footers in admin sections; fixed double footers when using print_footer() in admin page
MODIFY lib/weblib.php   Rev. 1.871    (+4 -3 lines)
Petr Skoda committed 8 files to 'Moodle CVS' - 01/May/07 01:28 AM
MDL-9647 simplify dealing with headers/footers in admin sections; some more cleanup
fixed continue button in error() on admin page when link present
MODIFY course/index.php   Rev. 1.76    (+3 -11 lines)
MODIFY course/category.php   Rev. 1.103    (+2 -6 lines)
MODIFY admin/roles/assign.php   Rev. 1.52    (+2 -6 lines)
MODIFY admin/roles/override.php   Rev. 1.32    (+2 -6 lines)
MODIFY course/report/log/index.php   Rev. 1.16    (+2 -6 lines)
MODIFY lib/weblib.php   Rev. 1.872    (+8 -19 lines)
MODIFY files/index.php   Rev. 1.118    (+2 -6 lines)
MODIFY user/editadvanced.php   Rev. 1.15    (+2 -4 lines)
[ Permalink | « Hide ]
Petr Skoda added a comment - 01/May/07 01:31 AM
fixed in cvs

Petr Skoda made changes - 01/May/07 01:31 AM
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
David Mudrak committed 1 file to 'Moodle CVS' - 17/Jun/07 10:14 AM
Repeating the skodak's commit 1.95 (MDL-9647 simplify dealing with headers/footers in admin sections) - evidently too late for me tonight... doing more CVS mistakes :-(
MODIFY admin/lang.php   Rev. 1.97    (+7 -7 lines)
Martín Langhoff committed 1 file to 'Moodle CVS' - 19/Sep/07 03:48 PM
course/index: Bring back Petr's MDL-9647 simplify dealing with headers/footers in admin sections

I had mistakenly reverted some of Petr's changes.

Fixes MDL-11179 19PERF: Notice on /course/index.php as admin
MODIFY course/index.php   Rev. 1.86    (+3 -11 lines)

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators