Moodle

"link to file or website" resource doesn't show flash player for mp3 files.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.8
  • Fix Version/s: 1.8.3, 1.9
  • Component/s: Filters
  • Labels:
    None
  • Environment:
    Firefox 2 on Ubuntu
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE

Description

In versions before 1.8, you could use the resource type "link to file or website" and point to an mp3 file and, if you had also specified that it display in the same window, it would be filtered and a flash player interface would appear. This no longer seems to occur as of version 1.8. I also tested with a .flv file and similarly, it only offered to download the file, there appeared to be no way to get it to play in place

This may be due to the forms being rewritten as the display in same window options have changed slightly, or it may be to do with the rewrite of the filter code. The rewrite seems to have introduced IE specific code, so it may need to be tested on both IE and in a non-IE browser.

This is not directly linked to this bug, but I would suggest that it might make sense to reuse the flash player currently used for .flv files, to also play .mp3 files in this case. This would share code and be slightly more aesthetically pleasing. The only feature lost would be the "pan" control, which I believe is effectively useless. I had always thought that it acted as a "balance" control that allowed you to listen to only one channel, but it appears it just moves the same audio from left to right.

Issue Links

This issue has a non-specific relationship to:
MDL-9792 Media filter doesn't work correctly for .mp3 or .rm files Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Martin Dougiamas added a comment -

Nicolas can you check this out? It might be related to some of the accessibility changes you made earlier this year.

Show
Martin Dougiamas added a comment - Nicolas can you check this out? It might be related to some of the accessibility changes you made earlier this year.
Hide
Permalink
Elena Ivanova added a comment -

It is actually related to this one: http://tracker.moodle.org/browse/MDL-9245
If, when you add a mp3 file, you remeber to check that "Keet Navigation Visible" box, then the file will be filtered and displayed properly.
Otherwise, students will need to download it.

Vote on MDL-9245! It is critical, I think.

Show
Elena Ivanova added a comment - It is actually related to this one: http://tracker.moodle.org/browse/MDL-9245 If, when you add a mp3 file, you remeber to check that "Keet Navigation Visible" box, then the file will be filtered and displayed properly. Otherwise, students will need to download it. Vote on MDL-9245! It is critical, I think.
Hide
Permalink
Martin Dougiamas added a comment -

Not quite ... currently it will use whatever plugin you have to play it, and if you don't then download it. I much prefer the flash player for MP3s.

eg http://test.moodle.com/mod/resource/view.php?id=25

I'm fixing this now.

Show
Martin Dougiamas added a comment - Not quite ... currently it will use whatever plugin you have to play it, and if you don't then download it. I much prefer the flash player for MP3s. eg http://test.moodle.com/mod/resource/view.php?id=25 I'm fixing this now.
Hide
Permalink
Martin Dougiamas added a comment -

I think things are OK now in 1.8 and head. It works like this:

1) If JS is enabled then use the MP3 and FLV flash players respectively, otherwise
2) Include the file as an object so that the plugins can take over, plus include a direct link to click on.

The JS thing is necessary because of XHTML strict compliance (spit).

Show
Martin Dougiamas added a comment - I think things are OK now in 1.8 and head. It works like this: 1) If JS is enabled then use the MP3 and FLV flash players respectively, otherwise 2) Include the file as an object so that the plugins can take over, plus include a direct link to click on. The JS thing is necessary because of XHTML strict compliance (spit).
Hide
Permalink
Martin Dougiamas added a comment -

PS I kept the MP3 player because

  • it displays ID3 info about the file, which is useful
  • it's colour-customisable
Show
Martin Dougiamas added a comment - PS I kept the MP3 player because
  • it displays ID3 info about the file, which is useful
  • it's colour-customisable
Hide
Permalink
Steve Dubrick added a comment -

I am still having a problem with mp3 links that open in a new window to play. mp3's in the same window also try to download instead of play. The only time the mp3 player appears is if I check the Keet Navigation Visible box as someone mentioned. I'm using todays build, so it has the recent changes.

Show
Steve Dubrick added a comment - I am still having a problem with mp3 links that open in a new window to play. mp3's in the same window also try to download instead of play. The only time the mp3 player appears is if I check the Keet Navigation Visible box as someone mentioned. I'm using todays build, so it has the recent changes.
Hide
Permalink
David Scotson added a comment -

Steve, I'm fairly sure that was the behaviour in 1.5/6/7, and is the intended behaviour after this fix. The only difference that may confuse you is that I believe the 'keep navigation visible' checkbox may have changed it's default behaviour.

There may be an 'expectations' bug, but I think the current behaviour is intended, at least in the sense that it matches the previous behaviour.

(I didn't think this was worth mentioning before, but seeing as I'm already typing this, the area dedicated to the flash (or native) plugin seems excessive, almost as if the default size was copied from a video display item (it's roughly square, but most audio things are long and horizontal). I think you have to set the background as well if it you're not using a white background. Looking at the source of the page it appears to suggest a 600 x 70 size, but that's not what I'm seeing on Ubuntu Firefox).

Show
David Scotson added a comment - Steve, I'm fairly sure that was the behaviour in 1.5/6/7, and is the intended behaviour after this fix. The only difference that may confuse you is that I believe the 'keep navigation visible' checkbox may have changed it's default behaviour. There may be an 'expectations' bug, but I think the current behaviour is intended, at least in the sense that it matches the previous behaviour. (I didn't think this was worth mentioning before, but seeing as I'm already typing this, the area dedicated to the flash (or native) plugin seems excessive, almost as if the default size was copied from a video display item (it's roughly square, but most audio things are long and horizontal). I think you have to set the background as well if it you're not using a white background. Looking at the source of the page it appears to suggest a 600 x 70 size, but that's not what I'm seeing on Ubuntu Firefox).
Hide
Permalink
Steve Dubrick added a comment -

So if I need to use "link to file or website" to link an .mp3 from the course topic list page, it's no longer possible in v1.8? I'm certain it did work in v1.6 and v1.7, because this is how I had set up my courses before. In 1.8 it no longer works if in the same window, or opening a new window. Every time it simply tries to download the file as if the media player filter wasn't on.

Show
Steve Dubrick added a comment - So if I need to use "link to file or website" to link an .mp3 from the course topic list page, it's no longer possible in v1.8? I'm certain it did work in v1.6 and v1.7, because this is how I had set up my courses before. In 1.8 it no longer works if in the same window, or opening a new window. Every time it simply tries to download the file as if the media player filter wasn't on.

People

Vote (12)
Watch (5)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.