Moodle

Gradebook sort buttons in 1.8+ yield empty list

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.8
  • Fix Version/s: 1.8.1
  • Component/s: Gradebook
  • Labels:
    None
  • Environment:
    Moodle 1.8+ of May 9, 2007, probably all 1.8 versions. PHP is 4.4.6 under Apache 1.3.37 and Linux.

Description

The default gradebook listing for an instructor is fine, but when a sort button is pressed, only standard page headers are shown. The various sort button URLs all include "&group=-1". When this text is appended to the URL of the standard display, an empty display results.

I believe the problem is due to near line 318 of lib.php, where $group is compared to zero instead of -1.

See attachment for a context diff of a fix.
--James

Issue Links

Activity

Hide
Petr Škoda (skodak) added a comment -

should be already fixed during the groups cleanup, thanks for the report!

Show
Petr Škoda (skodak) added a comment - should be already fixed during the groups cleanup, thanks for the report!

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: