Issue Details (XML | Word | Printable)

Key: MDL-9780
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Petr Skoda
Reporter: Petr Skoda
Votes: 1
Watchers: 4
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Groups 181 cleanup - META

Created: 11/May/07 08:14 PM   Updated: 23/May/07 05:18 PM
Return to search
Component/s: Groups
Affects Version/s: 1.8
Fix Version/s: 1.8.1

File Attachments: 1. Text File groups_181.patch (88 kB)
2. Text File groups_181_2.patch (89 kB)
Issue Links:
Dependency
 

Participants: Andrea Bicciolo, Anthony Borrow, Martin Dougiamas, Petr Skoda and Ray Lawrence
Security Level: None
Resolved date: 16/May/07
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_18_STABLE

Sub-Tasks:   All   Open   
 Sub-Task Progress: 
No sub-tasks match this view.

 Description  « Hide
There are several regressions, unfinished code, roles related problems and also some old bugs in groups implementation.

I am working on these problems now...

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Petr Skoda added a comment - 11/May/07 08:15 PM
unfinished patch attached

Petr Skoda made changes - 11/May/07 08:15 PM
Field Original Value New Value
Attachment groups_18.patch [ 11237 ]
Petr Skoda made changes - 12/May/07 08:02 PM
Link This issue will help resolve MDL-9670 [ MDL-9670 ]
Petr Skoda made changes - 12/May/07 08:02 PM
Link This issue will help resolve MDL-9769 [ MDL-9769 ]
Petr Skoda made changes - 12/May/07 08:04 PM
Link This issue will help resolve MDL-9365 [ MDL-9365 ]
Petr Skoda made changes - 12/May/07 08:04 PM
Link This issue will help resolve MDL-8914 [ MDL-8914 ]
Petr Skoda made changes - 12/May/07 08:06 PM
Link This issue will help resolve MDL-9520 [ MDL-9520 ]
Petr Skoda made changes - 12/May/07 08:07 PM
Link This issue will help resolve MDL-9438 [ MDL-9438 ]
Petr Skoda made changes - 12/May/07 08:09 PM
Link This issue will help resolve MDL-9127 [ MDL-9127 ]
Petr Skoda made changes - 15/May/07 02:15 AM
Link This issue will help resolve MDL-9806 [ MDL-9806 ]
Petr Skoda made changes - 15/May/07 05:13 AM
Link This issue will help resolve MDL-9807 [ MDL-9807 ]
Petr Skoda made changes - 15/May/07 05:14 AM
Attachment groups_18.patch [ 11237 ]
Petr Skoda made changes - 15/May/07 05:21 AM
Attachment groups_181.patch [ 11246 ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 15/May/07 05:22 AM
the patch above is ready for testing

[ Permalink | « Hide ]
Martin Dougiamas added a comment - 15/May/07 03:01 PM
OK, I'm testing it now. Thanks, Petr!

[ Permalink | « Hide ]
Andrea Bicciolo added a comment - 15/May/07 03:43 PM
Thanks Petr. I've patched a production site which makes extensive use of separated groups in chat and databases. Currently all seems working corerctly, we are monitoring the resultes in the next hours.

Petr Skoda made changes - 15/May/07 03:49 PM
Attachment groups_181_2.patch [ 11248 ]
[ Permalink | « Hide ]
Ray Lawrence added a comment - 15/May/07 03:54 PM
Hi,
Just updated from anon CVS (UK). Resources still have groups settings (MDL-9365).

How long will it take for me to be able to check the 181_2.patch via anon CVS?


[ Permalink | « Hide ]
Martin Dougiamas added a comment - 15/May/07 05:30 PM
Petr, groups are all looking really good, apart from those few small interface things we talked about in Skype (moving menu to left again, and hiding groupings fully)

Check it in!

Thanks for the excellent catch! :-D


Petr Skoda committed 19 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 16/May/07 02:23 AM
MDL-9780 Groups 181 cleanup - part 1
MODIFY user/index.php   Rev. 1.162.2.12    (+4 -8 lines)
MODIFY group/grouping.php   Rev. 1.4.2.5    (+5 -0 lines)
MODIFY course/moodleform_mod.php   Rev. 1.5.2.2    (+1 -0 lines)
MODIFY group/lib/Attic/modulelib.php   Rev. 1.1.4.4    (+1 -1 lines)
MODIFY course/Attic/grades.php   Rev. 1.34.2.2    (+3 -7 lines)
MODIFY grade/index.php   Rev. 1.10.2.2    (+6 -31 lines)
MODIFY course/lib.php   Rev. 1.484.2.11    (+3 -2 lines)
MODIFY grade/Attic/exceptions.php   Rev. 1.11.6.2    (+6 -4 lines)
MODIFY blocks/news_items/block_news_items.php   Rev. 1.19.2.3    (+12 -29 lines)
MODIFY theme/standard/styles_layout.css   Rev. 1.365.2.64    (+13 -0 lines)
MODIFY group/index.php   Rev. 1.13.2.12    (+30 -5 lines)
MODIFY grade/lib.php   Rev. 1.65.2.3    (+22 -38 lines)
MODIFY blocks/online_users/block_online_users.php   Rev. 1.46.2.4    (+3 -3 lines)
MODIFY group/Attic/edit_form.php   Rev. 1.1.2.7    (+9 -4 lines)
MODIFY group/Attic/printgrouping.php   Rev. 1.1.2.1    (+91 -0 lines)
MODIFY group/Attic/edit.php   Rev. 1.1.2.8    (+22 -2 lines)
MODIFY group/lib/Attic/legacylib.php   Rev. 1.6.2.5    (+55 -31 lines)
MODIFY blocks/blog_tags/block_blog_tags.php   Rev. 1.18.4.2    (+2 -2 lines)
MODIFY lib/weblib.php   Rev. 1.812.2.56    (+14 -7 lines)
Petr Skoda committed 31 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 16/May/07 02:26 AM
MDL-9780 Groups 181 cleanup - part 2
MODIFY mod/quiz/report/analysis/Attic/report.php   Rev. 1.30.2.5    (+14 -11 lines)
MODIFY mod/forum/lib.php   Rev. 1.536.2.31    (+38 -30 lines)
MODIFY mod/assignment/lib.php   Rev. 1.219.2.10    (+21 -52 lines)
MODIFY mod/forum/view.php   Rev. 1.94.2.4    (+3 -43 lines)
MODIFY mod/forum/search.php   Rev. 1.72.2.5    (+2 -2 lines)
MODIFY mod/chat/gui_header_js/index.php   Rev. 1.24.2.2    (+2 -2 lines)
MODIFY mod/forum/subscribers.php   Rev. 1.34.8.1    (+3 -6 lines)
MODIFY mod/data/view.php   Rev. 1.56.2.6    (+7 -10 lines)
MODIFY mod/choice/lib.php   Rev. 1.53.2.2    (+26 -24 lines)
MODIFY mod/assignment/index.php   Rev. 1.28.2.1    (+2 -2 lines)
MODIFY mod/journal/Attic/report.php   Rev. 1.34.6.1    (+3 -6 lines)
MODIFY mod/workshop/Attic/view.php   Rev. 1.59.2.2    (+5 -27 lines)
MODIFY mod/data/lib.php   Rev. 1.113.2.6    (+11 -12 lines)
MODIFY mod/journal/Attic/lib.php   Rev. 1.79.2.1    (+2 -2 lines)
MODIFY mod/forum/index.php   Rev. 1.90.2.3    (+2 -2 lines)
MODIFY mod/data/import.php   Rev. 1.12.2.2    (+3 -6 lines)
MODIFY mod/quiz/report/overview/report.php   Rev. 1.75.2.6    (+7 -32 lines)
MODIFY mod/choice/view.php   Rev. 1.93.2.2    (+9 -5 lines)
MODIFY mod/resource/mod_form.php   Rev. 1.3.2.3    (+1 -1 lines)
MODIFY mod/forum/discuss.php   Rev. 1.95.2.8    (+2 -6 lines)
MODIFY mod/forum/post.php   Rev. 1.134.2.9    (+13 -6 lines)
MODIFY mod/exercise/Attic/view.php   Rev. 1.31.2.1    (+2 -9 lines)
MODIFY mod/data/index.php   Rev. 1.12.2.1    (+2 -2 lines)
MODIFY mod/chat/report.php   Rev. 1.31.2.1    (+4 -7 lines)
MODIFY mod/data/templates.php   Rev. 1.60.2.2    (+3 -6 lines)
MODIFY mod/journal/Attic/view.php   Rev. 1.48.2.1    (+6 -11 lines)
MODIFY mod/chat/view.php   Rev. 1.55.2.2    (+26 -26 lines)
MODIFY mod/choice/report.php   Rev. 1.52.2.1    (+9 -2 lines)
MODIFY mod/glossary/mod_form.php   Rev. 1.13.2.1    (+1 -1 lines)
MODIFY mod/data/edit.php   Rev. 1.21.2.4    (+4 -8 lines)
MODIFY mod/hotpot/report.php   Rev. 1.26.2.3    (+3 -5 lines)
Petr Skoda committed 56 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 16/May/07 02:29 AM
MDL-9780 Groups 181 cleanup - part 3
DEL group/groupui/Attic/getgroupsingrouping-xml.php   Rev. 1.3.4.1    (+0 -0 lines)
DEL group/groupui/Attic/createautomaticgrouping-form.js   Rev. 1.1.4.1    (+0 -0 lines)
DEL group/groupui/Attic/creategroup-form.html   Rev. 1.3.4.1    (+0 -0 lines)
DEL group/groupui/Attic/form.html   Rev. 1.1.4.1    (+0 -0 lines)
DEL group/groupui/Attic/editgroupingsettings-form.js   Rev. 1.1.4.1    (+0 -0 lines)
DEL group/groupui/Attic/editgroupsettings-xml.php   Rev. 1.3.4.1    (+0 -0 lines)
DEL group/groupui/Attic/editgroupingsettings-xml.php   Rev. 1.3.4.1    (+0 -0 lines)
DEL group/groupui/Attic/addmembers-xml.php   Rev. 1.4.4.1    (+0 -0 lines)
DEL group/groupui/Attic/addmembers-form.js   Rev. 1.1.4.1    (+0 -0 lines)
DEL group/groupui/Attic/printgrouping.php   Rev. 1.4.2.2    (+0 -0 lines)
DEL group/groupui/Attic/createautomaticgrouping-xml.php   Rev. 1.3.4.1    (+0 -0 lines)
DEL group/groupui/Attic/main-form.html   Rev. 1.3.2.1    (+0 -0 lines)
DEL group/groupui/Attic/util-form.js   Rev. 1.1.4.1    (+0 -0 lines)
DEL group/groupui/Attic/yahoo.js   Rev. 1.1.4.1    (+0 -0 lines)
DEL group/groupui/Attic/connection.js   Rev. 1.1.4.1    (+0 -0 lines)
DEL group/groupui/Attic/getnonmembers-xml.php   Rev. 1.3.4.1    (+0 -0 lines)
DEL course/Attic/groups-edit.html   Rev. 1.20.2.1    (+0 -0 lines)
DEL group/groupui/Attic/getgroupingpermissions-xml.php   Rev. 1.3.4.1    (+0 -0 lines)
DEL group/groupui/Attic/removegroupfromgrouping.js   Rev. 1.1.4.1    (+0 -0 lines)
DEL group/groupui/Attic/editgroupsettings-form.js   Rev. 1.1.4.1    (+0 -0 lines)
DEL group/groupui/Attic/creategrouping-xml.php   Rev. 1.3.4.1    (+0 -0 lines)
DEL group/groupui/Attic/getgroupsnotingrouping-xml.php   Rev. 1.3.4.1    (+0 -0 lines)
DEL course/Attic/groups.php   Rev. 1.33.2.3    (+0 -0 lines)
DEL group/groupui/Attic/addgroupstogrouping-form.js   Rev. 1.1.4.1    (+0 -0 lines)
DEL group/groupui/Attic/creategrouping-form.js   Rev. 1.1.4.1    (+0 -0 lines)
DEL group/groupui/Attic/addmembers-form.html   Rev. 1.2.4.1    (+0 -0 lines)
DEL course/Attic/group.php   Rev. 1.29.6.1    (+0 -0 lines)
DEL group/groupui/Attic/creategrouping-form.html   Rev. 1.2.4.1    (+0 -0 lines)
DEL group/groupui/Attic/getgroupings-xml.php   Rev. 1.3.4.1    (+0 -0 lines)
DEL group/groupui/Attic/index.php   Rev. 1.4.4.2    (+0 -0 lines)
DEL group/groupui/Attic/removemembers-xml.php   Rev. 1.4.4.1    (+0 -0 lines)
DEL group/groupui/Attic/editgroupsettings-form.html   Rev. 1.2.4.1    (+0 -0 lines)
DEL group/groupui/Attic/removegroupfromgrouping-xml.php   Rev. 1.3.4.1    (+0 -0 lines)
DEL group/groupui/Attic/creategroup-xml.php   Rev. 1.3.4.1    (+0 -0 lines)
DEL group/groupui/Attic/ajax.js   Rev. 1.1.4.1    (+0 -0 lines)
DEL group/groupui/Attic/editgroupingpermissions-form.js   Rev. 1.1.4.1    (+0 -0 lines)
DEL group/groupui/Attic/deletegrouping.js   Rev. 1.1.4.1    (+0 -0 lines)
DEL group/groupui/Attic/getmembers-xml.php   Rev. 1.3.4.1    (+0 -0 lines)
DEL group/groupui/Attic/main-buttons-form.js   Rev. 1.1.4.1    (+0 -0 lines)
DEL group/groupui/Attic/getgroupingsettings-xml.php   Rev. 1.3.4.1    (+0 -0 lines)
DEL group/groupui/Attic/form.css   Rev. 1.1.4.1    (+0 -0 lines)
DEL group/groupui/Attic/editgroupingpermissions-form.html   Rev. 1.2.4.1    (+0 -0 lines)
DEL group/groupui/Attic/main-selects-form.js   Rev. 1.2.4.1    (+0 -0 lines)
DEL group/groupui/Attic/createautomaticgrouping-form.html   Rev. 1.2.4.1    (+0 -0 lines)
DEL group/groupui/Attic/editgroupingsettings-form.html   Rev. 1.2.4.1    (+0 -0 lines)
DEL group/groupui/Attic/main-init-form.js   Rev. 1.1.4.1    (+0 -0 lines)
DEL group/groupui/Attic/getgroupsettings-xml.php   Rev. 1.3.4.1    (+0 -0 lines)
DEL group/groupui/Attic/removemembers.js   Rev. 1.1.4.1    (+0 -0 lines)
DEL group/groupui/Attic/addgroupstogrouping-form.html   Rev. 1.2.4.1    (+0 -0 lines)
DEL group/groupui/Attic/deletegrouping-xml.php   Rev. 1.3.4.1    (+0 -0 lines)
DEL group/groupui/Attic/deletegroup-xml.php   Rev. 1.3.4.1    (+0 -0 lines)
DEL group/groupui/Attic/editgroupingpermissions-xml.php   Rev. 1.3.4.1    (+0 -0 lines)
DEL group/groupui/Attic/deletegroup.js   Rev. 1.1.4.1    (+0 -0 lines)
DEL course/Attic/group-edit.html   Rev. 1.12.4.1    (+0 -0 lines)
DEL group/groupui/Attic/addgroupstogrouping-xml.php   Rev. 1.3.4.1    (+0 -0 lines)
DEL group/groupui/Attic/creategroup-form.js   Rev. 1.1.4.1    (+0 -0 lines)
Petr Skoda committed 104 files to 'Moodle CVS' - 16/May/07 02:31 AM
MDL-9780 Groups 181 cleanup - merged from MOODLE_18_STABLE
DEL group/groupui/Attic/editgroupsettings-form.html   Rev. 1.4    (+0 -0 lines)
DEL group/groupui/Attic/deletegrouping.js   Rev. 1.3    (+0 -0 lines)
MODIFY mod/data/view.php   Rev. 1.66    (+7 -10 lines)
MODIFY mod/quiz/report/overview/report.php   Rev. 1.82    (+7 -32 lines)
DEL group/groupui/Attic/main-form.html   Rev. 1.5    (+0 -0 lines)
MODIFY course/moodleform_mod.php   Rev. 1.9    (+1 -0 lines)
DEL group/groupui/Attic/addgroupstogrouping-xml.php   Rev. 1.5    (+0 -0 lines)
MODIFY lib/weblib.php   Rev. 1.882    (+14 -7 lines)
MODIFY mod/data/import.php   Rev. 1.17    (+3 -6 lines)
DEL group/groupui/Attic/addgroupstogrouping-form.js   Rev. 1.3    (+0 -0 lines)
MODIFY mod/hotpot/report.php   Rev. 1.31    (+3 -5 lines)
DEL group/groupui/Attic/getgroupsingrouping-xml.php   Rev. 1.5    (+0 -0 lines)
DEL group/groupui/Attic/creategroup-form.js   Rev. 1.3    (+0 -0 lines)
MODIFY mod/journal/Attic/view.php   Rev. 1.51    (+6 -11 lines)
MODIFY mod/exercise/Attic/view.php   Rev. 1.35    (+2 -9 lines)
MODIFY user/index.php   Rev. 1.174    (+4 -8 lines)
MODIFY group/Attic/edit.php   Rev. 1.7    (+22 -2 lines)
DEL group/groupui/Attic/printgrouping.php   Rev. 1.7    (+0 -0 lines)
DEL group/groupui/Attic/deletegroup-xml.php   Rev. 1.5    (+0 -0 lines)
MODIFY mod/assignment/lib.php   Rev. 1.231    (+22 -53 lines)
DEL group/groupui/Attic/getgroupingsettings-xml.php   Rev. 1.5    (+0 -0 lines)
DEL group/groupui/Attic/creategroup-form.html   Rev. 1.5    (+0 -0 lines)
DEL group/groupui/Attic/editgroupingpermissions-form.js   Rev. 1.3    (+0 -0 lines)
DEL group/groupui/Attic/creategrouping-form.js   Rev. 1.3    (+0 -0 lines)
MODIFY mod/forum/index.php   Rev. 1.95    (+2 -2 lines)
DEL group/groupui/Attic/editgroupingsettings-form.html   Rev. 1.3    (+0 -0 lines)
MODIFY group/Attic/printgrouping.php   Rev. 1.2    (+91 -0 lines)
DEL group/groupui/Attic/form.css   Rev. 1.3    (+0 -0 lines)
DEL group/groupui/Attic/removegroupfromgrouping.js   Rev. 1.3    (+0 -0 lines)
DEL group/groupui/Attic/creategrouping-xml.php   Rev. 1.5    (+0 -0 lines)
MODIFY grade/lib.php   Rev. 1.68    (+22 -38 lines)
MODIFY mod/data/lib.php   Rev. 1.121    (+11 -12 lines)
MODIFY group/lib/Attic/legacylib.php   Rev. 1.12    (+57 -33 lines)
MODIFY grade/Attic/exceptions.php   Rev. 1.13    (+6 -4 lines)
MODIFY mod/data/templates.php   Rev. 1.64    (+3 -6 lines)
MODIFY mod/forum/post.php   Rev. 1.147    (+13 -6 lines)
DEL group/groupui/Attic/index.php   Rev. 1.7    (+0 -0 lines)
MODIFY group/Attic/edit_form.php   Rev. 1.8    (+9 -4 lines)
DEL group/groupui/Attic/main-selects-form.js   Rev. 1.4    (+0 -0 lines)
DEL group/groupui/Attic/addmembers-xml.php   Rev. 1.6    (+0 -0 lines)
DEL group/groupui/Attic/getgroupsnotingrouping-xml.php   Rev. 1.5    (+0 -0 lines)
MODIFY mod/resource/mod_form.php   Rev. 1.6    (+1 -1 lines)
MODIFY mod/choice/report.php   Rev. 1.56    (+8 -2 lines)
DEL group/groupui/Attic/editgroupsettings-xml.php   Rev. 1.5    (+0 -0 lines)
MODIFY mod/choice/lib.php   Rev. 1.56    (+26 -24 lines)
DEL group/groupui/Attic/createautomaticgrouping-xml.php   Rev. 1.5    (+0 -0 lines)
DEL group/groupui/Attic/removegroupfromgrouping-xml.php   Rev. 1.5    (+0 -0 lines)
DEL group/groupui/Attic/editgroupsettings-form.js   Rev. 1.3    (+0 -0 lines)
DEL group/groupui/Attic/yahoo.js   Rev. 1.2    (+0 -0 lines)
DEL group/groupui/Attic/getgroupsettings-xml.php   Rev. 1.5    (+0 -0 lines)
MODIFY course/Attic/grades.php   Rev. 1.36    (+3 -7 lines)
DEL group/groupui/Attic/main-init-form.js   Rev. 1.3    (+0 -0 lines)
DEL group/groupui/Attic/editgroupingsettings-xml.php   Rev. 1.5    (+0 -0 lines)
MODIFY mod/workshop/Attic/view.php   Rev. 1.63    (+5 -27 lines)
MODIFY mod/choice/view.php   Rev. 1.98    (+9 -5 lines)
DEL group/groupui/Attic/removemembers-xml.php   Rev. 1.6    (+0 -0 lines)
DEL group/groupui/Attic/editgroupingpermissions-form.html   Rev. 1.3    (+0 -0 lines)
MODIFY course/lib.php   Rev. 1.500    (+3 -2 lines)
DEL group/groupui/Attic/creategrouping-form.html   Rev. 1.3    (+0 -0 lines)
DEL group/groupui/Attic/deletegrouping-xml.php   Rev. 1.5    (+0 -0 lines)
MODIFY mod/forum/discuss.php   Rev. 1.105    (+2 -6 lines)
DEL group/groupui/Attic/getmembers-xml.php   Rev. 1.5    (+0 -0 lines)
MODIFY mod/glossary/mod_form.php   Rev. 1.15    (+1 -1 lines)
DEL group/groupui/Attic/deletegroup.js   Rev. 1.3    (+0 -0 lines)
DEL group/groupui/Attic/editgroupingsettings-form.js   Rev. 1.3    (+0 -0 lines)
DEL group/groupui/Attic/addgroupstogrouping-form.html   Rev. 1.3    (+0 -0 lines)
DEL group/groupui/Attic/ajax.js   Rev. 1.3    (+0 -0 lines)
DEL group/groupui/Attic/createautomaticgrouping-form.js   Rev. 1.3    (+0 -0 lines)
DEL group/groupui/Attic/addmembers-form.html   Rev. 1.4    (+0 -0 lines)
DEL group/groupui/Attic/connection.js   Rev. 1.2    (+0 -0 lines)
MODIFY blocks/online_users/block_online_users.php   Rev. 1.50    (+3 -3 lines)
DEL group/groupui/Attic/util-form.js   Rev. 1.3    (+0 -0 lines)
MODIFY mod/assignment/index.php   Rev. 1.31    (+2 -2 lines)
MODIFY mod/data/edit.php   Rev. 1.27    (+4 -8 lines)
MODIFY group/grouping.php   Rev. 1.9    (+5 -0 lines)
MODIFY mod/chat/view.php   Rev. 1.58    (+26 -26 lines)
DEL course/Attic/groups-edit.html   Rev. 1.21    (+0 -0 lines)
MODIFY blocks/blog_tags/block_blog_tags.php   Rev. 1.20    (+2 -2 lines)
DEL group/groupui/Attic/main-buttons-form.js   Rev. 1.3    (+0 -0 lines)
MODIFY mod/quiz/report/analysis/Attic/report.php   Rev. 1.36    (+14 -11 lines)
DEL group/groupui/Attic/creategroup-xml.php   Rev. 1.5    (+0 -0 lines)
DEL group/groupui/Attic/editgroupingpermissions-xml.php   Rev. 1.5    (+0 -0 lines)
MODIFY mod/forum/subscribers.php   Rev. 1.37    (+3 -6 lines)
MODIFY blocks/news_items/block_news_items.php   Rev. 1.22    (+12 -29 lines)
DEL group/groupui/Attic/removemembers.js   Rev. 1.3    (+0 -0 lines)
MODIFY mod/forum/search.php   Rev. 1.78    (+2 -2 lines)
MODIFY mod/data/index.php   Rev. 1.15    (+2 -2 lines)
DEL group/groupui/Attic/addmembers-form.js   Rev. 1.3    (+0 -0 lines)
DEL group/groupui/Attic/getgroupings-xml.php   Rev. 1.5    (+0 -0 lines)
MODIFY mod/chat/gui_header_js/index.php   Rev. 1.26    (+2 -2 lines)
MODIFY group/index.php   Rev. 1.25    (+30 -5 lines)
MODIFY theme/standard/styles_layout.css   Rev. 1.436    (+13 -0 lines)
DEL group/groupui/Attic/form.html   Rev. 1.3    (+0 -0 lines)
DEL group/groupui/Attic/createautomaticgrouping-form.html   Rev. 1.4    (+0 -0 lines)
DEL course/Attic/group-edit.html   Rev. 1.13    (+0 -0 lines)
MODIFY mod/chat/report.php   Rev. 1.34    (+4 -7 lines)
DEL course/Attic/groups.php   Rev. 1.36    (+0 -0 lines)
MODIFY mod/journal/Attic/report.php   Rev. 1.37    (+3 -6 lines)
DEL group/groupui/Attic/getgroupingpermissions-xml.php   Rev. 1.5    (+0 -0 lines)
DEL course/Attic/group.php   Rev. 1.30    (+0 -0 lines)
MODIFY mod/forum/view.php   Rev. 1.99    (+3 -43 lines)
MODIFY mod/forum/lib.php   Rev. 1.572    (+38 -30 lines)
MODIFY grade/index.php   Rev. 1.12    (+6 -31 lines)
DEL group/groupui/Attic/getnonmembers-xml.php   Rev. 1.5    (+0 -0 lines)
[ Permalink | « Hide ]
Petr Skoda added a comment - 16/May/07 02:39 AM
committed into cvs, please report any problems
thanks for testing and reports!

Petr Skoda made changes - 16/May/07 02:39 AM
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Petr Skoda made changes - 17/May/07 04:12 AM
Link This issue will help resolve MDL-9774 [ MDL-9774 ]
[ Permalink | « Hide ]
Anthony Borrow added a comment - 23/May/07 05:40 AM
Petr/MartinD - I may be helpful to update http://docs.moodle.org/en/group/index#Groups_in_Moodle_1.8_onwards and http://docs.moodle.org/en/Groups_FAQ#Groupings so that it is consistent. From what I can tell the plan to implement groupings in 1.8 has been aborted (post release). This does not seem to be a trivial change. If folks were using 1.8 and had groupings defined, have steps been taken to create the enablegroupings record in mdl_config? I did not see any set_config statements so I am assuming not. I am concerned for those who use CVS to update their sites, all of a sudden groupings will no longer be working and I think some type of warning/documentation should exist to clarify what is happening. Thanks for your work and for keeping the Moodle code and documentation top notch. Peace - Anthony

[ Permalink | « Hide ]
Anthony Borrow added a comment - 23/May/07 05:49 AM
Petr/MartinD - I have updated the above referenced Docs - please review them to make sure that they are accurate and helpful to other users. Peace - Anthony

[ Permalink | « Hide ]
Anthony Borrow added a comment - 23/May/07 06:01 AM
Is there a way for me to replace the groups tables in my 1.8 installation and isolate the group upgrade? I'm trying to troubleshoot why there are so many fewer records in mdl_groups_members than there are in mdl_groups_members_temp. Being able to isolate the group upgrade would greatly help in testing things. Any pointers would be appreciated.

[ Permalink | « Hide ]
Petr Skoda added a comment - 23/May/07 05:18 PM
I am going to review the docs now.
The group upgrade is defined in one file only, you can have a look into group/db/upgrade.php function groups_transfer_db()
looking at the upgrade code it looks to be badly inefficient - it should have been done with SQL instead of loops with php functions

The problem could be that the script died during upgrade or if one group fails for some reason, the rest is skipped.
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators