Moodle

Groups 181 cleanup - META

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.8
  • Fix Version/s: 1.8.1
  • Component/s: Groups
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE

Description

There are several regressions, unfinished code, roles related problems and also some old bugs in groups implementation.

I am working on these problems now...

Attachments

  1. Text File
    groups_181_2.patch
    15/May/07 3:49 PM
    89 kB
    Petr Škoda (skodak)
  2. Text File
    groups_181.patch
    15/May/07 5:21 AM
    88 kB
    Petr Škoda (skodak)

Issue Links

This issue will help resolve:
MDL-9670 Groups selector not implemented Blocker Closed
MDL-9806 orphaned group participants cannot select group on chat module and in database module when belonging to more than one group Blocker Closed
MDL-9769 Group selection in grading and viewing student results is gone Critical Closed
MDL-9365 Resources have groups setting Major Closed
MDL-8914 Groups not functioning in gradebook in 1.8beta Major Closed
MDL-9520 groups_groupids_to_groups should return groups indexed by group ID Major Closed
MDL-9127 Grouping problem with moodle 1.8 Major Closed
MDL-9438 Forums and separated groups: impossible to diplay messages of all groups a participant belongs to Minor Closed
MDL-9807 Current group don't saves in $SESSION (value destroys after page will be reloaded) Minor Closed
MDL-9774 Gradebook sort buttons in 1.8+ yield empty list Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

unfinished patch attached

Show
Petr Škoda (skodak) added a comment - unfinished patch attached
Hide
Permalink
Petr Škoda (skodak) added a comment -

the patch above is ready for testing

Show
Petr Škoda (skodak) added a comment - the patch above is ready for testing
Hide
Permalink
Martin Dougiamas added a comment -

OK, I'm testing it now. Thanks, Petr!

Show
Martin Dougiamas added a comment - OK, I'm testing it now. Thanks, Petr!
Hide
Permalink
Andrea Bicciolo added a comment -

Thanks Petr. I've patched a production site which makes extensive use of separated groups in chat and databases. Currently all seems working corerctly, we are monitoring the resultes in the next hours.

Show
Andrea Bicciolo added a comment - Thanks Petr. I've patched a production site which makes extensive use of separated groups in chat and databases. Currently all seems working corerctly, we are monitoring the resultes in the next hours.
Hide
Permalink
Ray Lawrence added a comment -

Hi,
Just updated from anon CVS (UK). Resources still have groups settings (MDL-9365).

How long will it take for me to be able to check the 181_2.patch via anon CVS?

Show
Ray Lawrence added a comment - Hi, Just updated from anon CVS (UK). Resources still have groups settings (MDL-9365). How long will it take for me to be able to check the 181_2.patch via anon CVS?
Hide
Permalink
Martin Dougiamas added a comment -

Petr, groups are all looking really good, apart from those few small interface things we talked about in Skype (moving menu to left again, and hiding groupings fully)

Check it in!

Thanks for the excellent catch! :-D

Show
Martin Dougiamas added a comment - Petr, groups are all looking really good, apart from those few small interface things we talked about in Skype (moving menu to left again, and hiding groupings fully) Check it in! Thanks for the excellent catch! :-D
Hide
Permalink
Petr Škoda (skodak) added a comment -

committed into cvs, please report any problems
thanks for testing and reports!

Show
Petr Škoda (skodak) added a comment - committed into cvs, please report any problems thanks for testing and reports!
Hide
Permalink
Anthony Borrow added a comment -

Petr/MartinD - I may be helpful to update http://docs.moodle.org/en/group/index#Groups_in_Moodle_1.8_onwards and http://docs.moodle.org/en/Groups_FAQ#Groupings so that it is consistent. From what I can tell the plan to implement groupings in 1.8 has been aborted (post release). This does not seem to be a trivial change. If folks were using 1.8 and had groupings defined, have steps been taken to create the enablegroupings record in mdl_config? I did not see any set_config statements so I am assuming not. I am concerned for those who use CVS to update their sites, all of a sudden groupings will no longer be working and I think some type of warning/documentation should exist to clarify what is happening. Thanks for your work and for keeping the Moodle code and documentation top notch. Peace - Anthony

Show
Anthony Borrow added a comment - Petr/MartinD - I may be helpful to update http://docs.moodle.org/en/group/index#Groups_in_Moodle_1.8_onwards and http://docs.moodle.org/en/Groups_FAQ#Groupings so that it is consistent. From what I can tell the plan to implement groupings in 1.8 has been aborted (post release). This does not seem to be a trivial change. If folks were using 1.8 and had groupings defined, have steps been taken to create the enablegroupings record in mdl_config? I did not see any set_config statements so I am assuming not. I am concerned for those who use CVS to update their sites, all of a sudden groupings will no longer be working and I think some type of warning/documentation should exist to clarify what is happening. Thanks for your work and for keeping the Moodle code and documentation top notch. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

Petr/MartinD - I have updated the above referenced Docs - please review them to make sure that they are accurate and helpful to other users. Peace - Anthony

Show
Anthony Borrow added a comment - Petr/MartinD - I have updated the above referenced Docs - please review them to make sure that they are accurate and helpful to other users. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

Is there a way for me to replace the groups tables in my 1.8 installation and isolate the group upgrade? I'm trying to troubleshoot why there are so many fewer records in mdl_groups_members than there are in mdl_groups_members_temp. Being able to isolate the group upgrade would greatly help in testing things. Any pointers would be appreciated.

Show
Anthony Borrow added a comment - Is there a way for me to replace the groups tables in my 1.8 installation and isolate the group upgrade? I'm trying to troubleshoot why there are so many fewer records in mdl_groups_members than there are in mdl_groups_members_temp. Being able to isolate the group upgrade would greatly help in testing things. Any pointers would be appreciated.
Hide
Permalink
Petr Škoda (skodak) added a comment -

I am going to review the docs now.
The group upgrade is defined in one file only, you can have a look into group/db/upgrade.php function groups_transfer_db()
looking at the upgrade code it looks to be badly inefficient - it should have been done with SQL instead of loops with php functions

The problem could be that the script died during upgrade or if one group fails for some reason, the rest is skipped.

Show
Petr Škoda (skodak) added a comment - I am going to review the docs now. The group upgrade is defined in one file only, you can have a look into group/db/upgrade.php function groups_transfer_db() looking at the upgrade code it looks to be badly inefficient - it should have been done with SQL instead of loops with php functions The problem could be that the script died during upgrade or if one group fails for some reason, the rest is skipped.

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.