|
I think this is no longer a problem in the latest code ... assigning to Petr to confirm.
thanks!!
I will work on it more today... It is good to know when ufo.js is fixed... you will be able to put Themes and Policy forms back to newer improved look...
I had to have some rest... but I am going to put some debug code into UFO... and see what the varibles are set to... to see if I can come up with a fix for you... Hmmm http://www.tbshs.herts.sch.uk/o.htm
I have amend ... cleanupIELeaks ... it shows that the inner loop is huge... I get it to jump out at 160 ... to stop system crashing... I am trying to work out how to get the size of this object array at the moment. cleanupIELeaks: function() { I have committed a temporary workaround into ufo and reverted previous changes in policy and theme selector.
It uses a counter and breaks from the loop after 1000 iterations, I guess we might report it upstream. Could you please test my workaround inside the leak workaround, I would like to close it before the release, which is expected tomorrow thanks for the diagnosing of this trouble!!! Yup new UFO works... I put in an alert... and on my system it gets upto the 1000 loops... and has to use the break to escape!
Tested it on policy and themes... they now do not crash... So you can commit that one... I will keep seeing if there is a better solution in the long run... where did the original idea for "cleanupIELeaks" come from? Since it crashed both IE6 and IE7... it seems strange that it got in. I reckon most people did not report it... though being a problem on all IE6 and IE7... because once it crashed... when they reloaded the pages... the changes had already been made to the database... so they were not presented with the policy again... so had no real reason to get annoyed by what they see as a single crash... thanks for testing
you can try to report it upstream, I know very little about this script myself. I guess they should be able to reproduce this quite easily, maybe nobody expected us to be embedding html files with object (for accessibility reasons) instead of iframe. closing for now Upstream... Can do... but... are you meaning moodle 1.9 or Microsoft...
Do a google search for... cleanupIELeaks it appears everywhere!!!
UFO is from http://www.bobbyvandersluis.com/ufo/ I think if I write to the authors... and tell them about our use of object and the problem with UFO... they might suggest that we go back to iframe! To see how far the loop went... I took out the break and put in window.status = j; And the loop got upto 50,000 before I stopped it! -
I am hoping to get hold of the UFO author and explain the necessary changes... some point next week. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
============