Moodle

Groups from groupings not moved to "Not in a grouping"

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.8
  • Fix Version/s: 1.8.1
  • Component/s: Groups
  • Labels:
    None
  • Database:
    MySQL
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE

Description

To reproduce the bug it is needed to have a Moodle 1.8 "pre group patch" from Petr Skoda. Using this older Moodle version:

1. create orphaned groups in a course
2. update Moodle with the latest 1.8 CVS version containing Petr's group fixes
3. in the same course of point #1 go to the Groups page: orphaned groups does not show, thus cannot be edited.

New groups can be created and people assigned to them. Orphaned groups are still functioning correctly across all course's activities, but there is no way to edit them.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

Strange works fine for me:

1/ installed fresh original 1.8.0
2/ created course, 3 users, 2 orphan groups and enrolled students and assigned groups
3/ upgraded to latest 1.8+
4/ I can access those 2 original groups and edit them, assign users into groups etc.

Groups created in non-orphan groupings are not visible - that was intentional because groupings do not work yet as expected and require db changes and some rewriting of code

I am going to try upgrade from 1.7 now...

Show
Petr Škoda (skodak) added a comment - Strange works fine for me: 1/ installed fresh original 1.8.0 2/ created course, 3 users, 2 orphan groups and enrolled students and assigned groups 3/ upgraded to latest 1.8+ 4/ I can access those 2 original groups and edit them, assign users into groups etc. Groups created in non-orphan groupings are not visible - that was intentional because groupings do not work yet as expected and require db changes and some rewriting of code I am going to try upgrade from 1.7 now...
Hide
Permalink
Andrea Bicciolo added a comment -

Wow, probably the problem is here: the groups not showing was in grouping while I was thinking they were orphaned. There is any chances to get those group orphaned again to check if the problem is now non-visible-grouping?

Show
Andrea Bicciolo added a comment - Wow, probably the problem is here: the groups not showing was in grouping while I was thinking they were orphaned. There is any chances to get those group orphaned again to check if the problem is now non-visible-grouping?
Hide
Permalink
Petr Škoda (skodak) added a comment -

sure, add following into your config.php
$CFG->enablegroupings = true;

Show
Petr Škoda (skodak) added a comment - sure, add following into your config.php $CFG->enablegroupings = true;
Hide
Permalink
Andrea Bicciolo added a comment -

Thanks. Groups was grouped. The problem is the exact opposite of what i thought, but you are already aware so I think you can close the bug.

Many thanks.

Show
Andrea Bicciolo added a comment - Thanks. Groups was grouped. The problem is the exact opposite of what i thought, but you are already aware so I think you can close the bug. Many thanks.
Hide
Permalink
Petr Škoda (skodak) added a comment -

thanks for all the testing,
now I know I have to mention this change in release notes

Show
Petr Škoda (skodak) added a comment - thanks for all the testing, now I know I have to mention this change in release notes
Hide
Permalink
Petr Škoda (skodak) added a comment -

reopening - all groups from all groupings are shown in group selector - this is IMO a major problem, because only groups from active grouping should be shown.

This is a major problem IMO, because it will cause a breakage now - or later when we fix it

Show
Petr Škoda (skodak) added a comment - reopening - all groups from all groupings are shown in group selector - this is IMO a major problem, because only groups from active grouping should be shown. This is a major problem IMO, because it will cause a breakage now - or later when we fix it
Hide
Permalink
Petr Škoda (skodak) added a comment -

I am going to patch the upgrade a bit to move the groups from groupings to not in a grouping and some more related internal groups code fixes

Show
Petr Škoda (skodak) added a comment - I am going to patch the upgrade a bit to move the groups from groupings to not in a grouping and some more related internal groups code fixes
Hide
Permalink
Petr Škoda (skodak) added a comment -

attached patch should solve it

Show
Petr Škoda (skodak) added a comment - attached patch should solve it
Hide
Permalink
Martin Dougiamas added a comment -

Looks good, go for it!

Show
Martin Dougiamas added a comment - Looks good, go for it!
Hide
Permalink
Petr Škoda (skodak) added a comment -

fixed in cvs, it should not cause confusion any more

thanks for the report again.

Show
Petr Škoda (skodak) added a comment - fixed in cvs, it should not cause confusion any more thanks for the report again.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.