Moodle

Course request button is only available when front page display options when logged in includes List of courses

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.8
  • Fix Version/s: 1.9.4
  • Component/s: Administration
  • Labels:
    None
  • Environment:
    any
  • Database:
    Any
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Set up site with logged in options combo list or category list.
Enable course requests.
Log in as user allowed to request courses (with manage:activities capability?)
Cannot see Course request button
Change front page when logged in to include list of courses.
Log in as user allowed to request courses
View all courses
Request course button visible

Issue Links

This issue is duplicated by:
MDL-16297 I've turned on the ability for all users to request a course. The button to request a course shows for some users and not others. Minor Closed
MDL-16439 course request button is not visible on the choosen category Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Arnaud saint-Georges added a comment - - edited

It's a very sad issue. Indeed, I discovered yesterday that some teachers have requested for some courses for six months!

I have been working with Moodle 1.8.2, then 1.8.3, then 1.8.4 .
Six months ago, I tried the Course Request feature but didn't succeed because I couldn't never see the button "Approval" or "Request".
Unfortunately, I leaved "Course Request" setting enabled.

My front page is designed to include course categories (not all courses).

As Admin, I never saw this "Approval" button excepted yesterday when I went to the URL "http://moodle.uhb.fr/course/pending.php"!
But some of my teachers saw this button after they "search" for some courses and then click on "All courses" button...

Show
Arnaud saint-Georges added a comment - - edited It's a very sad issue. Indeed, I discovered yesterday that some teachers have requested for some courses for six months! I have been working with Moodle 1.8.2, then 1.8.3, then 1.8.4 . Six months ago, I tried the Course Request feature but didn't succeed because I couldn't never see the button "Approval" or "Request". Unfortunately, I leaved "Course Request" setting enabled. My front page is designed to include course categories (not all courses). As Admin, I never saw this "Approval" button excepted yesterday when I went to the URL "http://moodle.uhb.fr/course/pending.php"! But some of my teachers saw this button after they "search" for some courses and then click on "All courses" button...
Hide
Permalink
Mary Parke added a comment -

We are on version 1.9.2 and seem to have similar problem. The course request button does not appear to all faculty. Rather, they see a description of what the button does (that the site administrator sets up) but no form to fill out.

It doesn't seem to be a role permissions issue as both those who can see and those who can't are assigned to the same role.

Show
Mary Parke added a comment - We are on version 1.9.2 and seem to have similar problem. The course request button does not appear to all faculty. Rather, they see a description of what the button does (that the site administrator sets up) but no form to fill out. It doesn't seem to be a role permissions issue as both those who can see and those who can't are assigned to the same role.
Hide
Permalink
Mary Parke added a comment -

You may be able to get around the button by providing a link to the page where the form lives:

http://[yoursite]/course/request.php

Am testing this right now with our faculty...

Show
Mary Parke added a comment - You may be able to get around the button by providing a link to the page where the form lives: http://[yoursite]/course/request.php Am testing this right now with our faculty...
Hide
Permalink
Tim Hunt added a comment -

Grabbing a bunch of related course category editing bugs that I plan to work on. Sorry for all the emails.

Show
Tim Hunt added a comment - Grabbing a bunch of related course category editing bugs that I plan to work on. Sorry for all the emails.
Hide
Permalink
Matt Campbell added a comment -

You may want to take a look at the course creation block, and MDL-6160. Neither of them are doing anything particularly fancy and would probably address these issues. The course creation block is using some deprecated code to determine if a user has course editing rights on any course in the site, so you might have to update that.

Show
Matt Campbell added a comment - You may want to take a look at the course creation block, and MDL-6160. Neither of them are doing anything particularly fancy and would probably address these issues. The course creation block is using some deprecated code to determine if a user has course editing rights on any course in the site, so you might have to update that.
Hide
Permalink
Tim Hunt added a comment -

The course request code was a mess. I have just done a major clean-up including

  • Rewrite all the forms to use formslib and improve usability.
  • Put the place where admins need to go to process approvals in the admin menu.
  • Show the request course/pending requests button on the page for the category that requested courses get added to.
Show
Tim Hunt added a comment - The course request code was a mess. I have just done a major clean-up including
  • Rewrite all the forms to use formslib and improve usability.
  • Put the place where admins need to go to process approvals in the admin menu.
  • Show the request course/pending requests button on the page for the category that requested courses get added to.
Hide
Permalink
Ray Lawrence added a comment -

Nice enhancements. Thanks.

Adding the course request option for authenticated users is a bad move. It will cause problems in every school in the land.

I think that prior to your fixes that anyone is editing teacher somewhere on the site has this capability. This would be a more useful default imo.

Show
Ray Lawrence added a comment - Nice enhancements. Thanks. Adding the course request option for authenticated users is a bad move. It will cause problems in every school in the land. I think that prior to your fixes that anyone is editing teacher somewhere on the site has this capability. This would be a more useful default imo.
Hide
Permalink
Tim Hunt added a comment -

The old code was:

if ($CFG->enablecourserequests and isloggedin() and !isguest() and !has_capability('moodle/course:create', $systemcontext)) { /// Print link to request a new course print_single_button('request.php', NULL, get_string('courserequest'), 'get'); }

That looks like it is visible to all users to me.

Anyway, as part of a separate improvement, Petr added a capability, so admins can make the button available to some users, but not others, but that was a new feature, as far as I can see.

Show
Tim Hunt added a comment - The old code was: if ($CFG->enablecourserequests and isloggedin() and !isguest() and !has_capability('moodle/course:create', $systemcontext)) { /// Print link to request a new course print_single_button('request.php', NULL, get_string('courserequest'), 'get'); } That looks like it is visible to all users to me. Anyway, as part of a separate improvement, Petr added a capability, so admins can make the button available to some users, but not others, but that was a new feature, as far as I can see.

People

Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.