Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 1.8, 1.8.1, 1.9
-
Component/s: Accessibility
-
Labels:None
-
Environment:HideDocument type: XHTML 1.0 Strict.
http://validator.w3.org/check?verbose=1;outline=1;uri=http%3A%2F%2Fmoodle.org%2Fhelp.php%3Ffile%3Dindex.html -3 errors repeated, no headings.
http://validator.w3.org/check?verbose=1;outline=1;uri=http%3A%2F%2Fmoodle.org%2Fhelp.php%3Ffile%3Dgroupmode.html -3 errors.ShowDocument type: XHTML 1.0 Strict. http://validator.w3.org/check?verbose=1;outline=1;uri=http%3A%2F%2Fmoodle.org%2Fhelp.php%3Ffile%3Dindex.html -3 errors repeated, no headings. http://validator.w3.org/check?verbose=1;outline=1;uri=http%3A%2F%2Fmoodle.org%2Fhelp.php%3Ffile%3Dgroupmode.html -3 errors.
-
Affected Branches:MOODLE_18_STABLE, MOODLE_19_STABLE
-
Fixed Branches:MOODLE_18_STABLE, MOODLE_19_STABLE
Description
Following on from bug MDL-7861 "Strict XHTML 1.0", I am building up a patch to fix stray ampersands, poor semantics, etc. in help HTML files (lang/en_utf8/help/*). This is what I'm tackling:
1 Well-formed XML
- Stray ampersands, regular expression /&[^a^l^g^q^n^#]/ (Not perfect, but a start). Specific searches &file, &bug, &mod.
2 Semantics
- Each */index.html should start with a <h2> </h2>, except help/index.html which should start <h1> </h1>
- Other headings, regular expression /<p><b>(.*?)</b></p>/, should be replaced variously with <h2>$1</h2>, <h3>$1</h3> as appropriate - a headache!
NOTES,
- I want to be pragmatic. - should we aim for Strict DTD for help? Would Transitional be sufficient?
- I'm ONLY fixing English language, en_utf8 - how can we systematically fix other languages.
Attachments
Issue Links
| This issue blocks: | ||||
| MDL-12902 | Multi-language help should be accessible, XHTML Strict and semantic |
|
|
|
| This issue has a non-specific relationship to: | ||||
| MDL-14319 | Bad XHTML in help files |
|
|
|
| This issue has been marked as being related by: | ||||
| MDL-11158 | & needs fix to & in block_tag_youtube for 'en' and other language packs |
|
|
|
As well as help files, I fixed some stray ampersands in string files, en_utf8/enrol_authorize.php, en_utf8/moodle.php
I'm attaching version 2 of the patch (v1 was 4 April) - anyone want to review? There are still "Other headings" to fix (x100!), but I may just commit what I've done.