Moodle

Moodle redirect instructor to system configuration page if restore is canceled in middle

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.8
  • Fix Version/s: 1.8.4, 1.9, 2.0
  • Component/s: Backup
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE

Description

I'm starting to contribute back to the moodle community about some customizations/bug fixes we made here at SFSU, as we haven't got a chance to organize these and contribute them back to the community yet.

In original state moodle redirects instructor to system configuration page if restore is cancelled in middle. This is unwanted becuase instructors do not have access to admin page so they will be logged out. In this bug fix we have changed the code to redirect user to respective course index page if restore is canceled.

File(s) effected: /backup/restore.php

Change :
Replaced
#107 print_continue("$CFG->wwwroot/$CFG->admin/index.php");
with
#107 print_continue("$CFG->wwwroot/course/view.php?id=".$id);

Please consider to check this into the moodle core code. Thanks!

Activity

Hide
Dan Poltawski added a comment -

Hi Wen, this seems like it'd be quite annoying as a teacher, thanks for the fix! I've commited it into CVS for 1.9 and above

Show
Dan Poltawski added a comment - Hi Wen, this seems like it'd be quite annoying as a teacher, thanks for the fix! I've commited it into CVS for 1.9 and above
Hide
Eloy Lafuente (stronk7) added a comment -

Hi Dan,

thanks a lot for getting this done! B-)

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Hi Dan, thanks a lot for getting this done! B-) Ciao
Hide
Eloy Lafuente (stronk7) added a comment -

One more thing... can I suggest to backport this bug to 18_STABLE too. When they are trivial to fix, it's recommended to backport them to current stable release too.

TIA and re-ciao

Show
Eloy Lafuente (stronk7) added a comment - One more thing... can I suggest to backport this bug to 18_STABLE too. When they are trivial to fix, it's recommended to backport them to current stable release too. TIA and re-ciao
Hide
Dan Poltawski added a comment -

Thanks Eloy, Done

Show
Dan Poltawski added a comment - Thanks Eloy, Done

People

Vote (7)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: