Moodle

rounded corner theme problem with right to left languages

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9
  • Component/s: Themes
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

go to http://test.moodle.com/ and select "fa" in the language pop up menu (the first after Euskara (eu))

Issue Links

This issue is blocked by:
MDL-10075 Can't add rtl css files. Does Moodle load theme/config.php several times with different $CFG set? Blocker Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Urs Hunkler added a comment - - edited

I am working on the rtl issue. Hope to find a flexible solution. You may look at the linked issue.

Show
Urs Hunkler added a comment - - edited I am working on the rtl issue. Hope to find a flexible solution. You may look at the linked issue.
Hide
Permalink
Mauno Korpelainen added a comment -

Hi Urs,

I tested this with minor changes to lib/custom_corners_lib.php, lib/weblib.php and theme/custom_corners/user_styles.css

I changed

<div class="wrap">
<div class="bt"><div></div></div>
....
<div class="bb"><div></div></div>
</div>

to a "three image box" - left image, border image and right image for top and bottom of the box using

<DIV id="box">
<DIV id="box_t">
<DIV id="box_tl">
<DIV id="box_tr"></DIV></DIV></DIV>
....
<DIV id=box_b>
<DIV id=box_bl>
<DIV id=box_br></DIV></DIV></DIV>
</DIV>

It worked fine with both rtl and ltr languages and without a need to use styles_rtl.css at all or any other fixes. I will test some more (first I will try the order tl-t-tr...bl-b-br with some new css because I did not test that yet) and send you some mail later...

Show
Mauno Korpelainen added a comment - Hi Urs, I tested this with minor changes to lib/custom_corners_lib.php, lib/weblib.php and theme/custom_corners/user_styles.css I changed <div class="wrap"> <div class="bt"><div></div></div> .... <div class="bb"><div></div></div> </div> to a "three image box" - left image, border image and right image for top and bottom of the box using <DIV id="box"> <DIV id="box_t"> <DIV id="box_tl"> <DIV id="box_tr"></DIV></DIV></DIV> .... <DIV id=box_b> <DIV id=box_bl> <DIV id=box_br></DIV></DIV></DIV> </DIV> It worked fine with both rtl and ltr languages and without a need to use styles_rtl.css at all or any other fixes. I will test some more (first I will try the order tl-t-tr...bl-b-br with some new css because I did not test that yet) and send you some mail later...
Hide
Permalink
Urs Hunkler added a comment -

Solved with the fix for MDL-10075.

Show
Urs Hunkler added a comment - Solved with the fix for MDL-10075.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.