Moodle QA

Failed as per rather long winded comments on MDLQA-231 with an outlines of the results. I don't think the scores were calculated correctly but would love someone else to decipher them!

Teresa, thanks for running this test. I'm going to reset it now, since MDL-23492 is marked as fixed. Please see Dan's comment in MDL-23492 for further information on SCORM activity grading.

Teresa, I've just added you as a watcher, as I'm wondering whether I made a mistake resetting the test if you failed it after Dan resolved MDL-23492? If so, please add a comment to MDL-23492 requesting that it is re-opened and mark this test as failed (again!) Apologies for my mistake.

See comments in MDLQA-231 re me not knowing what the scores should be... they all still look like the highest attempt...

It seems that this test, as for MDLQA-231, requires a particular SCORM package in order to be able to run the test properly. Thus I'm going to post in the SCORM module forum to ask whether anyone can help provide SCORM packages for testing. If we don't obtain one soon, I will copy these comments, then remove this test from Moodle 2.0 QA Cycle 1. Once we have a SCORM package, the test can be added to the next QA cycle.

adding Dan as a watcher - have created MDL-23751 (complete with video of testing!) as strange crashing behaviour during second SCORM attempt.

I have tested this issue using Ostyn's prodding SCO. My process was as follows:

For 2 student users:
Access Prodding SCO

1. Initialize();
2. set value cmi.core.score.raw
3. Commit();
4. set value cmi.core.lesson_status to either "completed" or "passed" (the two both work interchangeably to indicate completed attempt)
5. LMSFinish();

Sally Student's attempts cmi.core.score.raw:
40, 40, 40

Sam Student's attempts cmi.core.score.raw:
25, 50, 100

With the Attempts Grading setting set to Highest Grade, reporting to the gradebook was correct. 40 for Sally, 100 for Sam.
With the Attempts Grading setting set to Average Attempt, reporting to the gradebook was unchanged from Highest Grade.
With the Attempts Grading setting set to First Attempt, reporting to the gradebook was unchanged from Highest Grade.
With the Attempts Grading setting set to Last Attempt, reporting to the gradebook was unchanged from Highest Grade.

I also logged in as Sam student to look at the SCORM results view for student users. When grading method was set to last attempt, Sam's grade in this view was shown as "50", which would seem to indicate that it's not actually rendering up the "last" score recorded. This is very obvious as the view shows a list of all 3 attempts.

Hi Amy,

thanks for testing - one of the things that might be confusing here is that changing the grade method won't change any grades already pushed to the gradebook. - The grading method will only be used next time a user makes another attempt.

I think we have some code lying around here that we wrote for one of our clients that updated gradebook entries based on the SCORM settings but we never tidied this up and put it in core... can you please re-test using new attempts each time you change the grading method and see if that works?

There should probably be an open feature request in the tracker to improve this..... I'll try to remember to dig out the code that we had to update grades......

thanks,

Dan

hmmm.... ignore that last comment, looking at the code it looks like we did add the grade updating functions.... I'll have a closer look at this.

I can't continue to test this at all now due to the 404 error when navigating to another page - see MDL-23751 for details (just watch the 30sec video posted today!) .

Dan, awesome that you caught that. Will wait to see what you find out. Because attempts grading is cumulative, it really makes the most sense if a change to that setting resets what's in the gradebook...

Regards,
A

TOC duplication error fixed - now waiting for the 404 error to be fixed. Would love to be able to test this using the 'normal' web interface students would use.

Thanks everyone for your help with testing. I'm rewording the test a little based on Dan's comments. (Dan, please let me know if it requires further rewording.)

we think all the outstanding issues on this have been fixed and this should now pass correctly. - thanks to everyone who has helped track the issues down.

Thanks Dan, just resetting the test...

YEAH!!

adding note about auto continue due to comments in MDL-23751 from Dan about this not working correctly for a while.