Moodle Community Sites

CVS Developer Module: ability to add comment without approving or rejecting

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Won't Fix
  • Component/s: moodle.org
  • Labels:
    None

Description

It would be nice to be able to add a comment (at least in the message field) about the status of a particular CVS request. When I have tried to do this, I have changed the message and tried to save changes but because the path field is listed as required the changes cannot be saved. I think the path field should only be required if the approved field is checked.

Issue Links

This issue has a non-specific relationship to:
MDLSITE-410 Improve functionality of CVS admin interface Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anthony Borrow added a comment -

Perhaps an alternative would be to simply put none in the path field; however, I'm not sure how the system would handle it but that would seem to correspond to all.

Show
Anthony Borrow added a comment - Perhaps an alternative would be to simply put none in the path field; however, I'm not sure how the system would handle it but that would seem to correspond to all.
Hide
Permalink
Anthony Borrow added a comment -

Matthieu - I noticed the CVS developer chat tab and a new enabled button; however, I am not sure what the enabled checkbox is for so I have been avoiding it. Do you have any thoughts on how we might be able to make some comments. Another feature that might be nice would be some type of history. I tried to take a look at the logs for that module; however, it appears that it may be taking too much memory and not working. Peace - Anthony

Show
Anthony Borrow added a comment - Matthieu - I noticed the CVS developer chat tab and a new enabled button; however, I am not sure what the enabled checkbox is for so I have been avoiding it. Do you have any thoughts on how we might be able to make some comments. Another feature that might be nice would be some type of history. I tried to take a look at the logs for that module; however, it appears that it may be taking too much memory and not working. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

Here's what happened when I tried to hit the logs logo for the CVS module.

Show
Anthony Borrow added a comment - Here's what happened when I tried to hit the logs logo for the CVS module.
Hide
Permalink
Mathieu Petit-Clair added a comment -

Anthony - I don't seem to have access to this at all... I think you'll have to ask Martin about it.

Show
Mathieu Petit-Clair added a comment - Anthony - I don't seem to have access to this at all... I think you'll have to ask Martin about it.
Hide
Permalink
Anthony Borrow added a comment -

Matthieu - For some reason I thought Martin had said you were doing some of the work on this but it could just be some misfired neurons. I'll follow up with Martin and see how he wants to handle this. I do know that the code is not in CVS which I presume is for security reasons. In any case, I will check and let you know what I find out. Peace - Anthony

Show
Anthony Borrow added a comment - Matthieu - For some reason I thought Martin had said you were doing some of the work on this but it could just be some misfired neurons. I'll follow up with Martin and see how he wants to handle this. I do know that the code is not in CVS which I presume is for security reasons. In any case, I will check and let you know what I find out. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

I've added MD as a watcher and hope that he might be able to refresh my memory about who was working on the CVS write access module so that we know who to assign this to. Peace - Anthony

Show
Anthony Borrow added a comment - I've added MD as a watcher and hope that he might be able to refresh my memory about who was working on the CVS write access module so that we know who to assign this to. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

Martin - Just a follow up to see who was working on the code for the CVS write access module. It would be nice to have some type of mechanism to comment on particular requests. Currently I am using Moodle messaging between Michael Blake and Koen to work on things but ideally there would be some type of comment tool available within this module. Obviously this is not a high priority but I at least would like to get this re-assigned to the right person. Peace - Anthony

Show
Anthony Borrow added a comment - Martin - Just a follow up to see who was working on the code for the CVS write access module. It would be nice to have some type of mechanism to comment on particular requests. Currently I am using Moodle messaging between Michael Blake and Koen to work on things but ideally there would be some type of comment tool available within this module. Obviously this is not a high priority but I at least would like to get this re-assigned to the right person. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

I'm dropping the priority on this to trivial as it is really low impact and more of a wish-list item.

Show
Anthony Borrow added a comment - I'm dropping the priority on this to trivial as it is really low impact and more of a wish-list item.
Hide
Permalink
Anthony Borrow added a comment -

I think what I need could be accomplished by simply removing the required field on the directory path. If we wanted, we could make it a conditionally required field (i.e. it is only required if the approval check box is checked). Otherwise, it will just update the entry. If I had access to the code I could probably work up a quick patch. Peace - Anthony

Show
Anthony Borrow added a comment - I think what I need could be accomplished by simply removing the required field on the directory path. If we wanted, we could make it a conditionally required field (i.e. it is only required if the approval check box is checked). Otherwise, it will just update the entry. If I had access to the code I could probably work up a quick patch. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

Re-assigning to myself and resolving as won't fix. I am simply rejecting applications that may not be needed and can go back and review in the database if needed. Ideally, it would be nice to be able to review through the UI submitted but rejected requests. Peace - Anthony

Show
Anthony Borrow added a comment - Re-assigning to myself and resolving as won't fix. I am simply rejecting applications that may not be needed and can go back and review in the database if needed. Ideally, it would be nice to be able to review through the UI submitted but rejected requests. Peace - Anthony

People

Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.