Issue Details (XML | Word | Printable)

Key: MDLSITE-425
Type: Task Task
Status: Open Open
Priority: Minor Minor
Assignee: Eloy Lafuente (stronk7)
Reporter: Helen Foster
Votes: 0
Watchers: 3
Operations

If you were logged in you would be able to see more operations.
Moodle.org Sites

Check for any deleted lang strings

Created: 24/Apr/08 06:24 PM   Updated: 16/May/08 03:41 PM
Component/s: CVS repository

Issue Links:
Relates

Participants: Eloy Lafuente (stronk7), Helen Foster and Nicolas Martignoni
Security Level: None


 Description  « Hide
According to the coding guidelines, http://docs.moodle.org/en/Coding lang strings should never be deleted, however developers often forget this ;-)

Eloy, please could you run a detection script comparing the situation now with 3 months ago.


 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Helen Foster added a comment - 24/Apr/08 06:26 PM
VIP ( = Very Important People) watchers added for further comments about possible strategies.

Eloy Lafuente (stronk7) added a comment - 24/Apr/08 07:52 PM
Oh, VIP watchers, what a responsibility!

This poor developer will try to do his work successfully!

:-D Ciao :-)

Eloy Lafuente (stronk7) added a comment - 24/Apr/08 08:19 PM
Well, I've executed the comparison script with today's HEAD against 3 months ago HEAD and I've got these strings deleted since then:

< blog.php:addotags
< blog.php:addptags
< blog.php:otags
< blog.php:ptags
< countries.php:CS
< countries.php:FX
< countries.php:KO
< countries.php:TP
< countries.php:WA
< countries.php:ZR
< grades.php:aggregationcoefextrahelp
< grades.php:aggregationcoefweighthelp
< grades.php:configbulkcheckboxes
< grades.php:configquickfeedback
< grades.php:errornocategorizedid
< grades.php:overallavg
< moodle.php:nostatstodisplay
< userkey.php:keyiprestrictionhelp
< userkey.php:keyvaliduntilhelp

About these strings... we should test each one to see if they are used in old stable branches:

1) If they are used in stable branches... (say 3 latest branches 1.7, 1.8 and 1.9?) then we must reintroduce them ASAP.
2) If they aren't used, they they only have been in HEAD so, it's safe to keep them deleted, IMO.

Then, two tasks:

A) I think that this task of searching for uses... could be easily automated, to provide the detection script with that useful info.

B The other task would be to detect string files that have changed "a lot" to see if the change is good enough or no. This could be automated too if somebody knows a good algorithm to measure diferences between strings (sure it exists).

In any case... perhaps it would be a goo idea to:

- Move this script to, say, cvs.moodle.org (we need a local checkout of all the branches + head) in the host running the detection script.
- Create some list in lists.moodle.org allowing people to get subscribed to it (Could be 2-3 lists, one with daily changes and another with monthly changes).
- Make the script to send results to that list.

How does it sound?

Ciao :-)

Nicolas Martignoni added a comment - 24/Apr/08 10:00 PM
Eloy,

My (modest) +1 for your points 1) and 2) and your suggestions A and B.

For B, Levenshtein algorithm (see http://en.wikipedia.org/wiki/Levenshtein_distance) could be a candidate.

Ciao ;-)

Nicolas Martignoni added a comment - 24/Apr/08 10:01 PM
Sorry, I can't edit my previous comment, where Jira added a paren at the end of the URL :-( Here is the correct one (sorry for the spam).

http://en.wikipedia.org/wiki/Levenshtein_distance

Helen Foster added a comment - 16/May/08 03:41 PM
Fix deleted lang strings added as a new issue - MDL-14866.