Moodle Community Sites

See my comments of Feb 8, 2008 and Apr 12, 2008 (my time) in MDL-9683

EDIT: Whoa! Now I can edit and delete again! Just a few minutes ago I posted a comment on another issue (MDL-9989) and the edit and delete links were not there. Something weird is going on.

Well, I was just about to say, I figured it out: You can only edit comments in issues you created; you used to be able to edit comment you made regardless. But here I am back in this issue that I did create, and the edit and delete links are gone. Here we go again.

Maybe it's because ...

Wait a minute. As I am typing this comment, the Edit and Delete links in my previous comment have re-appeared!

I give up.

Here it is two months later. I just added two comments to MDL-9989 because I wasn't able to edit the first one. The Edit and Delete links are still in this issue, but not that one.

There has been no response from anyone on this issue whatsoever.

Hi Richard,

Is it the case that you can edit comments for MDLSITE issues and not comments for MDL issues?

I'm going to re-assign this issue to tracker permissions expert Michael Blake for consideration. (Michael, please feel free to assign it back to me if you'd like me to investigate the issue further.)

HF (& MB),

Thank you for responding.

Did you read my second comment in this issue? It appears that I am only able to edit comments in issues I created. I used to be able to do that in issues I did not create, like MDL-11743, but the edit and delete links on that page are no longer there. As far as I know, it is not because the other issues are MDL and this one is MDLSITE, but I could be mistaken.

I just added a comment to MDLSITE-276, which I did not create, as a test. It is not giving me (so far!) the edit and delete links. So the answer is no, that's not the reason. It is because I didn't create the issue. Do you want me to create an MDL issue as a test of the other side of the coin?

RLE

Hi Richard,
Only members of the 'developers' or 'testers' group have the ability to edit or delete issues per the current Tracker permission scheme. Users can edit issues they've logged. If you were able to edit an issue in the past, either it was one you logged, or possibly someone may have (temporarily) changed the permission scheme that applies to Tracker.

The same permission scheme applies to both MDL (main project) and MLD-SITE.

I'm going to add you to the 'testers' group so you will have the ability to edit any issue.

Richard - please verify that you can edit issues you've not logged. If all is well, please close this issue.

MB,

1. Thx for promoting me to tester, but I didn't ask for that. All I wanted was to be able to edit my own comments, in any issue, whether I created it or not, like I used to be able to do with MDL-11743, which was created by Antonio Carlos Pereira Gomes.

2. I am not aware of having been made a tester or developer last year when I was commenting on that issue. You can see the word "edited" in red after my name on several of my comments there, starting on October 17, 2007. But I'm not the only one. You can also see that flag on comments of Birdie Newborn, Romeu Klug, and onitzuka. Did someone temporarily promote them too?

3. You have confirmed my suspicion. The ability to edit or not is unrelated to whether it is an MDL or MDLSITE issue, as I said in my last comment.

4. I just went to the next issue in sequence, MDL-11744, which I neither created not commented on. I don't see any edit or delete links. Did you mean that as a tester I only had permission to edit my own comments? That's all I wanted, not just for myself, but all Moodlers.

5. I just added a comment to that issue, as a test, as you requested. I still don't see any edit or delete links. Test failed.

RLE

EDIT: I still don't see edit or delete links on the comment I made earlier, as a test, on MDLSITE-276, either. Just this one, which I created.

Richard,
1. You should be able to edit comments on issues you've created and commented on. You are not able to edit comments you've made on issues others have created.
2. I don't think you (or the others) would have been made a tester in error, the permission scheme may have allowed you to edit another person's comment. Shouldn't be able to do that now.
3. yep, same permission scheme applies to both repositories.
4. as a tester (or even a standard user) you can only edit your own comments - never another's comments. Just to reiterate, you can only edit comments you've made on issues you've created.

There is some discussion on the Jira (company that created Tracker) website about enhancements for this area. Looks like there are some updates. I'll investigate and possibly install. I agree that any user should be able to edit comments s/he made. The problem lies in how future comments relate to previous comments that may have been changed.

Do you want to be removed from the 'testers' group in Tracker?

Have modified permission scheme so that now any user can edit his/her comments, regardless of who has created the issue.

Richard, please verify.

MB,

5. You did not respond to my statement that the test failed. You had said that as a tester, which you had promoted me to, I should be able to edit my own comments on an issue I had not created. I tested that and that test failed.

6. Now that you have changed the permission scheme back to the way it used to be (I think), which is what I requested, I went back to MDLSITE-276, and on the test comment left during the previous test, I now see an edit link but not a delete link. The edit link works. Test partially successful. Or was it your intention that Moodlers should only be able to edit but not delete their own comments in issues they did not create?

RLE

Reopening, as it seems the issue is not yet resolved.

5. Regardless of what group you're in you should be able to edit comments you've created.
6. You are able to edit comments that you've created. You are only able to fully delete a comment on an issue you've created. I've tested this as a standard user and as a member of the 'testers' group.

MB,

5. Should be, but I wasn't, until you changed the permission scheme. Making me a tester was not sufficient.
6. Now, yes.
7. BTW, do you still want me to close this issue, or is it already closed because it says it is resolved, or fixed? I'm not sure what the ramifications of closing an issue are. If it is already closed, that has not prevented me from commenting on it.

RLE

Richard,
If you're happy with the resolution, you may close the issue.

Standard Tracker process: an issues is 'resolved', then another person tests it. If the tester is satisfied, the issue is 'closed'. For more info see http://docs.moodle.org/en/Tracker

MB,

Fine. As you wish, although I still don't know what all the ramifications are.

RLE

EDIT: For description of testing done, see earlier comments.

NB
After discussion about potential confusion that will arise when users have the ability to edit comments, Tracker permissions have been updated to allow editing or deleting comments only for core Moodle developers.

To correct an existing comment, create a new one and explain the previous error.

MB,

In that case I take it back. You asked me to close the issue when I was satisfied with the resolution, and I did. It seemed I had succeeded in convincing you that all Moodlers should be able to edit and delete their own comments, whether in an issue they created or not, as it used to be. I got most of that : we could edit but not delete our comments (why it would be better to be able to delete the entire content of a comment, leaving a totally empty comment, than to delete it, I don't know, but it was a compromise I could live with).

Now that I have expressed my satisfaction with that resolution, you have done a 180 degree switch so that now, if I understand you correctly, we can't even edit our own comments in issues we created unless we are core developers! So I take it back. I unclose the issue. It is now not only not fixed, it is broken worse than it was before I created the issue, because then we could at least edit our own comments in issues we created. So I uncreate the issue.

If you look in the history of this issue (which is fairly typical of issues I have commented in), you will find that I have edited the same comment five or six times, as I frequently do with forum posts. Your solution would have me post six or seven comments, each describing why all the preceding ones were wrong, thus making the issue ten times longer than it needs to be, and making it almost impossible for others to read it and follow it with understanding. Where is sanity?

RLE

Hi Richard,

Unfortunately it's not possible to provide a 30-minute editing period for tracker comments as is the case for Moodle forum posts.

Editing of forum posts for an unlimited time is not allowed because otherwise it could make discussions very difficult to follow, not knowing what has been changed in an edited post. Discussions generally take place in a forum, however issues may sometimes be discussed in the tracker too.

I hope this explains the reason for not allowing editing of tracker comments.