http://moodle.org/stats/index2.php deleted

Ciao

Is it OK if we use commas all the time? :-P

moodle_setlocale();

function localisenumber($number) {
$string = (string)number_format($number);
$locale = localeconv();
$sep = $locale['thousands_sep'];
if ($sep == ',' || $sep == '') { return $string; } else { return $string = str_replace(',', $sep, $string); }
}

In any case, as we have:

$string['decsep'] = '.'; // decimal point separator, for some languages it is ','

in en_utf8/langconfig.php

what about to add:

$string['thousandsep'] = '.'; // thousands point separator, for some languages it is '.'

And then, simply, we use it in private localisenumber() function above?

Ciao

Oki, I'll add it...ciao Reopening this.

function localisenumber($number, $numdec = 2) {

$decimalsep = get_string('decsep');
$thousandssep = get_string('thousandssep');

if (!is_numeric($number)) { return $number; }

if ((float)$number == (int)$number) { /// Integer number, no decimals return (string)number_format($number, 0, $decimalsep, $thousandssep); } else { /// Float number, apply decimals return (string)number_format($number, $numdec, $decimalsep, $thousandssep); }
}

Examples:

http://moodle.org/stats/?lang=es
http://moodle.org/stats/?lang=en

Also direct use of number_format() is not recommended anymore, we do have format_float() and unformat_float().

IMO unformating/editing shouldn't accept thousand separators at all. But (non-editable) output... that's another story we could talk more.

Anyway, this has been exclusively for stats output, using its own function and blah, blah.

PS: Oracle? NLS_NUMERIC_CHARACTERS='.,' handles that completely (specifying both the dec and thousands separator). And it's in core since ages. NP (special) there AFAIK.