Moodle Community Sites

Upgrade Moodle Docs

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Component/s: docs.moodle.org
  • Labels:
    None

Description

Currently Moodle Docs is using MediaWiki version 1.11.2. There have been a couple of security updates recently.

http://lists.wikimedia.org/pipermail/mediawiki-announce/2008-December/000080.html
http://lists.wikimedia.org/pipermail/mediawiki-announce/2009-February/000083.html

Activity

Hide
Eloy Lafuente (stronk7) added a comment -

Installed latest 1.13.5 released 2 days ago that includes all the bug/security fixes.

http://docs.moodle.org/test/Special:Version

I thought we were going to have a lot of conflicts when upgrading (due to our Realname/Theme hacks), but I only got 2 conflicts easy to resolve.

Please perform some tests (Realname, emails, registration, extensions, internet explorer....) and, if everything goes ok... I'll perform the upgrade lang by lang in the production one.

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Installed latest 1.13.5 released 2 days ago that includes all the bug/security fixes. http://docs.moodle.org/test/Special:Version I thought we were going to have a lot of conflicts when upgrading (due to our Realname/Theme hacks), but I only got 2 conflicts easy to resolve. Please perform some tests (Realname, emails, registration, extensions, internet explorer....) and, if everything goes ok... I'll perform the upgrade lang by lang in the production one. Ciao
Hide
Helen Foster added a comment -

Thanks a lot Eloy Looks great to me, though I still need to do further testing in IE6.

Changing the security level in order to ask others to help with testing.

Show
Helen Foster added a comment - Thanks a lot Eloy Looks great to me, though I still need to do further testing in IE6. Changing the security level in order to ask others to help with testing.
Hide
Helen Foster added a comment -

When attempting to edit a talk page e.g. http://docs.moodle.org/test/index.php?title=User_talk:Eloy_Lafuente_(stronk7)&action=edit I obtain the message:

User account "Eloy Lafuente (stronk7)" is not registered. Please check if you want to create/edit this page.

Signing a talk page results in the username being displayed rather than the real name.

Show
Helen Foster added a comment - When attempting to edit a talk page e.g. http://docs.moodle.org/test/index.php?title=User_talk:Eloy_Lafuente_(stronk7)&action=edit I obtain the message: User account "Eloy Lafuente (stronk7)" is not registered. Please check if you want to create/edit this page. Signing a talk page results in the username being displayed rather than the real name.
Hide
Frank Ralf added a comment -

I'm not quite sure what to test. Is there a "test suite" for documentation testing?

Show
Frank Ralf added a comment - I'm not quite sure what to test. Is there a "test suite" for documentation testing?
Hide
Helen Foster added a comment -

Frank, you can help with testing by logging into http://docs.moodle.org/test/Main_Page and trying all the things you usually do in the documentation wiki.

Show
Helen Foster added a comment - Frank, you can help with testing by logging into http://docs.moodle.org/test/Main_Page and trying all the things you usually do in the documentation wiki.
Hide
Frank Ralf added a comment -

Signature:

The user profile page shows an additional "Signature" field. Anything entered there will be used as signature, otherwise the nickname. Should be the full name (if provided) as it is now.

Show
Frank Ralf added a comment - Signature: The user profile page shows an additional "Signature" field. Anything entered there will be used as signature, otherwise the nickname. Should be the full name (if provided) as it is now.
Hide
Frank Ralf added a comment -

Screenshot of Signature field on user profile page

Show
Frank Ralf added a comment - Screenshot of Signature field on user profile page
Hide
Frank Ralf added a comment -

The grey bar on the left of the categories section is doubled. (Perhaps some nested transclusion?)

Show
Frank Ralf added a comment - The grey bar on the left of the categories section is doubled. (Perhaps some nested transclusion?)
Hide
Eloy Lafuente (stronk7) added a comment -

Aha. Just discovered that some Special pages (preferences and others) have been moved from 1.11 to 1.13 to another dir... so I've to patch those files in new location... hopefully that will fix the signature problem and others.

Stay tuned. Ciao

PS: Thanks for testing!

Show
Eloy Lafuente (stronk7) added a comment - Aha. Just discovered that some Special pages (preferences and others) have been moved from 1.11 to 1.13 to another dir... so I've to patch those files in new location... hopefully that will fix the signature problem and others. Stay tuned. Ciao PS: Thanks for testing!
Hide
Eloy Lafuente (stronk7) added a comment -

Hi, I've updated these Special pages:

-SpecialContributions
-SpecialImagelist
-SpecialListusers
-SpecialNewimages
-SpecialPreferences
-SpecialWatchlist

Please confirm everything is ok now in those areas (full names, realname, email and nick not editable in profile...) and works exactly like the english production version.

I'm updating the Parser now (it has changed of dir too!) Ciao

Show
Eloy Lafuente (stronk7) added a comment - Hi, I've updated these Special pages: -SpecialContributions -SpecialImagelist -SpecialListusers -SpecialNewimages -SpecialPreferences -SpecialWatchlist Please confirm everything is ok now in those areas (full names, realname, email and nick not editable in profile...) and works exactly like the english production version. I'm updating the Parser now (it has changed of dir too!) Ciao
Hide
Eloy Lafuente (stronk7) added a comment -

Oki, parser updated so ~~~~ does use real names again. With this all the problems reported above should be fixed. Fell free to add more... ciao

Show
Eloy Lafuente (stronk7) added a comment - Oki, parser updated so ~~~~ does use real names again. With this all the problems reported above should be fixed. Fell free to add more... ciao
Hide
Eloy Lafuente (stronk7) added a comment -

I forgot that. Fixed double-category-links too. Ciao

Show
Eloy Lafuente (stronk7) added a comment - I forgot that. Fixed double-category-links too. Ciao
Hide
Eloy Lafuente (stronk7) added a comment - - edited

Just detected that:

1) The menu in test isn't the last one. I've to copy it from prod.
2) The new breadcrumb isn't in test either. I'll copy that too.

(isn't supposed that EVERYTHING is in test? grrr. I'll copy those bits from prod to test tomorrow. I hope there aren't more changes in prod not present in test)

Ciao

Show
Eloy Lafuente (stronk7) added a comment - - edited Just detected that: 1) The menu in test isn't the last one. I've to copy it from prod. 2) The new breadcrumb isn't in test either. I'll copy that too. (isn't supposed that EVERYTHING is in test? grrr. I'll copy those bits from prod to test tomorrow. I hope there aren't more changes in prod not present in test) Ciao
Hide
Frank Ralf added a comment -
  • The signatures work correctly now.
  • Still got the above mentioned error message:

"User account "Helen Foster" is not registered. Please check if you want to create/edit this page."

on this page:
http://docs.moodle.org/test/index.php?title=User_talk:Helen_Foster&action=edit&section=53

Show
Frank Ralf added a comment -
  • The signatures work correctly now.
  • Still got the above mentioned error message:
"User account "Helen Foster" is not registered. Please check if you want to create/edit this page." on this page: http://docs.moodle.org/test/index.php?title=User_talk:Helen_Foster&action=edit&section=53
Hide
Frank Ralf added a comment -

User time doesn't show in signature

Even if I set my time in preferences the correct time doesn't show in the signatures:
http://docs.moodle.org/test/User_talk:Helen_Foster#Signature_test

Show
Frank Ralf added a comment - User time doesn't show in signature Even if I set my time in preferences the correct time doesn't show in the signatures: http://docs.moodle.org/test/User_talk:Helen_Foster#Signature_test
Hide
Eloy Lafuente (stronk7) added a comment -

Menu & breadcrumb fixed. Should be 100% the same than the one in production server.

Going to take a look to:

  • User talk page (the "... is not registered..." problem.
  • usertime in signatures (though it seems that I get correct UTC signatures here)

Ciao

Thanks for tests!

Show
Eloy Lafuente (stronk7) added a comment - Menu & breadcrumb fixed. Should be 100% the same than the one in production server. Going to take a look to:
  • User talk page (the "... is not registered..." problem.
  • usertime in signatures (though it seems that I get correct UTC signatures here)
Ciao Thanks for tests!
Hide
Eloy Lafuente (stronk7) added a comment -

Fixed the problem editing user/user talk pages. Now users by realname are properly detected there.

About the usertime in signatures... are you sure it's a bug? I get correct UTC times always (and that's the way it's supposed to work). See my latest comment in http://docs.moodle.org/test/User_talk:Helen_Foster#Signature_test

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Fixed the problem editing user/user talk pages. Now users by realname are properly detected there. About the usertime in signatures... are you sure it's a bug? I get correct UTC times always (and that's the way it's supposed to work). See my latest comment in http://docs.moodle.org/test/User_talk:Helen_Foster#Signature_test Ciao
Hide
Helen Foster added a comment -

Frank, thanks for testing, and Eloy, thanks for fixing everything

I think we can go for upgrading the production wikis now.

Show
Helen Foster added a comment - Frank, thanks for testing, and Eloy, thanks for fixing everything I think we can go for upgrading the production wikis now.
Hide
Eloy Lafuente (stronk7) added a comment -

Thanks for testing, Frank, Helen. I've upgraded the production "en" Moodle Docs to the new version some minutes ago.

I'll wait some more days to see if there are new problems to fix before continue with the rest of languages.

Helen, perhaps the upgrade could be commented in the Documentation forum or so, pointing to this bug to report any annoyance?

Thanks again and ciao

Show
Eloy Lafuente (stronk7) added a comment - Thanks for testing, Frank, Helen. I've upgraded the production "en" Moodle Docs to the new version some minutes ago. I'll wait some more days to see if there are new problems to fix before continue with the rest of languages. Helen, perhaps the upgrade could be commented in the Documentation forum or so, pointing to this bug to report any annoyance? Thanks again and ciao
Hide
Helen Foster added a comment -

Eloy, thanks a lot for upgrading the en Moodle Docs

I've just noticed in http://docs.moodle.org/en/Special:RecentChanges (using Firefox on Ubuntu) that the line spacing has been reduced, and a forced refresh doesn't fix the problem.

Show
Helen Foster added a comment - Eloy, thanks a lot for upgrading the en Moodle Docs I've just noticed in http://docs.moodle.org/en/Special:RecentChanges (using Firefox on Ubuntu) that the line spacing has been reduced, and a forced refresh doesn't fix the problem.
Hide
Helen Foster added a comment -

As requested, documentation forum announcement: http://moodle.org/mod/forum/discuss.php?d=118329

Show
Helen Foster added a comment - As requested, documentation forum announcement: http://moodle.org/mod/forum/discuss.php?d=118329
Hide
Helen Foster added a comment -

Please find attached screenshot illustrating recent changes line spacing problem.

Show
Helen Foster added a comment - Please find attached screenshot illustrating recent changes line spacing problem.
Hide
Eloy Lafuente (stronk7) added a comment -

Aha,

thanks for the screenshot! Just discovered the "enhanced recent changes" setting (in user profile), so I've been able to reproduce the bug here. Was a minor CSS adjustment... should be working ok now, both in "test" and "en". Thanks!

Show
Eloy Lafuente (stronk7) added a comment - Aha, thanks for the screenshot! Just discovered the "enhanced recent changes" setting (in user profile), so I've been able to reproduce the bug here. Was a minor CSS adjustment... should be working ok now, both in "test" and "en". Thanks!
Hide
Helen Foster added a comment -

Eloy, thanks for fixing the line spacing problem. Everything is perfect now!

A big thank you also for upgrading all the other language wikis

Show
Helen Foster added a comment - Eloy, thanks for fixing the line spacing problem. Everything is perfect now! A big thank you also for upgrading all the other language wikis
Hide
Eloy Lafuente (stronk7) added a comment -

Going to leave this open some days... awaiting for any type of problem... feel free to close it then if I forget that! TIA!

Show
Eloy Lafuente (stronk7) added a comment - Going to leave this open some days... awaiting for any type of problem... feel free to close it then if I forget that! TIA!
Hide
Frank Ralf added a comment -

Eloy, thanks for the upgrade!

As already suggested in http://moodle.org/mod/forum/discuss.php?d=117361 I would recommend implementing DPL (the "Swiss army knife of MediaWiki"):

"Dynamic Page List (DPL) is a universal reporting tool for MediaWikis, listing category members and intersections with various formats and details."
http://www.mediawiki.org/wiki/Extension:DynamicPageList

Even if not for use for the general public, I think documentation maintainers could benefit from this tool (admittedly haven't used it myself yet, only read about it).

Frank

Show
Frank Ralf added a comment - Eloy, thanks for the upgrade! As already suggested in http://moodle.org/mod/forum/discuss.php?d=117361 I would recommend implementing DPL (the "Swiss army knife of MediaWiki"): "Dynamic Page List (DPL) is a universal reporting tool for MediaWikis, listing category members and intersections with various formats and details." http://www.mediawiki.org/wiki/Extension:DynamicPageList Even if not for use for the general public, I think documentation maintainers could benefit from this tool (admittedly haven't used it myself yet, only read about it). Frank
Hide
Eloy Lafuente (stronk7) added a comment -

Hi Frank,

I leave this to Helen / Martin consideration. Initially I'm reticent to add new extensions and so on because:

  • It's non-core
  • Makes difficult the upgrading task, mainly due to our local customisation.

In any case, if finally the extension is considered as interesting I can install it on tests and see how it performs... In any case, Frank, can you add a new bug with justification and so on, adding Martin/Helen to allow them to decide? That would be perfect, leaving this bug exclusively for the recent upgrade thing.

Thanks a lot for your work, Ralf! Ciao

Show
Eloy Lafuente (stronk7) added a comment - Hi Frank, I leave this to Helen / Martin consideration. Initially I'm reticent to add new extensions and so on because:
  • It's non-core
  • Makes difficult the upgrading task, mainly due to our local customisation.
In any case, if finally the extension is considered as interesting I can install it on tests and see how it performs... In any case, Frank, can you add a new bug with justification and so on, adding Martin/Helen to allow them to decide? That would be perfect, leaving this bug exclusively for the recent upgrade thing. Thanks a lot for your work, Ralf! Ciao
Hide
Frank Ralf added a comment -

Done: MDLSITE-680

Frank

Show
Frank Ralf added a comment - Done: MDLSITE-680 Frank
Hide
Eloy Lafuente (stronk7) added a comment -

Thanks Ralf. I'm resolving this a fixed now. Ciao

Show
Eloy Lafuente (stronk7) added a comment - Thanks Ralf. I'm resolving this a fixed now. Ciao
Hide
Helen Foster added a comment -

Thanks again Eloy and everyone who helped with testing the upgrade.

Show
Helen Foster added a comment - Thanks again Eloy and everyone who helped with testing the upgrade.

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: