Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Component/s: CVS repository, moodle.org
-
Labels:None
Description
I am not sure what changed but recently changes to CVS access seem to be generating a string of emails. For the time being, I have been turning off the email subscriptions to see if that helps but we certainly do not want to be filling peoples email boxes with what they are reporting as about a hundred emails a day. Any ideas what might be happening. I will assign initially to Eloy as I believe he knows most about this but feel free to re-assign as appropriate. Peace - Anthony
Issue Links
| This issue will be resolved by: | ||||
| MDLSITE-697 | CVS Application allows spaces in the username, which makes account unusable |
|
|
|
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
Eloy - Thanks for the follow up and your help in resolving this. I was receiving them at regular 15 minute intervals and then it looks like you started your testing as I received a few more. The last one I received was at 8:29. I've linked this with MDLSITE-697 which addresses the issue with the space and adding the validity check. Would it be possible to either remove or modify Red Morris's entry to remove the space. He's not been able to checkout his code as it is now. I told him we need people to break things to help show us where things need to be improved. We all have to be good at something 
Peace - Anthony
Peace - Anthony Resolving this as fixed. I've pending to introduce username validation in the cvsadmin module but leave that for MDLSITE-697
Ciao 
Hi Anthony,
I think I've found the cause for the repeated emails.
There is one user candidate that contains spaces in his cvs username (Red Morris) and it was causing the process to break, never ending and trying to process your account changes and also Matt Campbell and others once and again.
I've added one custom check in the process to skip any user containing spaces and now the process has ended ok. Tell me if that has stopped your repeated emails.
In any case, I'm going to add one check in moodle.org cvsadmin module to pre-check those cvs usernames, preventing them to contain spaces and friends, just letters, numbers and typical .-_ chars. That should prevent problems to arrive in the future.
Ciao