Moodle Community Sites

Unit tests in cvsadmin module return blank page

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Not a bug
  • Component/s: moodle.org
  • Labels:
    None

Description

http://moodle.org/mod/cvsadmin/view.php?tab=unittest

returns blank page, seems something is breaking it... ciao

Issue Links

This issue will be resolved by:
MDL-20391 lib/simpletest/testfilelib.php causing fatal errors Major Open
MDL-20390 external.php unit tests causing fatal errors Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

I think the problem is the Unit tests in 2.0 are broken.

moodlebot: blame Jerome.

Show
Tim Hunt added a comment - I think the problem is the Unit tests in 2.0 are broken. moodlebot: blame Jerome.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Linking with some existing bugs (MDL-20390, MDL-20391) that Tim has been fixing... just in case they were the culprits of this.

Show
Eloy Lafuente (stronk7) added a comment - Linking with some existing bugs (MDL-20390, MDL-20391) that Tim has been fixing... just in case they were the culprits of this.
Hide
Permalink
Tim Hunt added a comment -

Right. Unit tests now run (without fatal errors) on my machine. And I have fixed a lot of the failures. Those bugs Eloy links to are bugs for other people to fix unit test failures.

However, there is one more MDLSITE issue here. http://moodle.org/mod/cvsadmin/view.php?tab=unittest is showing a whole bunch of failures that do not occur when I run the tests on my own computer. For example, neither Eloy nor I see the ddl and dml failures. That inconsistency is very bad. Please can you investigate Jordan. Thanks.

Show
Tim Hunt added a comment - Right. Unit tests now run (without fatal errors) on my machine. And I have fixed a lot of the failures. Those bugs Eloy links to are bugs for other people to fix unit test failures. However, there is one more MDLSITE issue here. http://moodle.org/mod/cvsadmin/view.php?tab=unittest is showing a whole bunch of failures that do not occur when I run the tests on my own computer. For example, neither Eloy nor I see the ddl and dml failures. That inconsistency is very bad. Please can you investigate Jordan. Thanks.
Hide
Permalink
Tim Hunt added a comment -

Actually, I can reproduce the problem.

If I turn off Moodle's debugging settings, then I get the same fails as http://moodle.org/mod/cvsadmin/view.php?tab=unittest.

I think you should be running with debugging on Jordan, but we should fix the problem with debugging off.

Show
Tim Hunt added a comment - Actually, I can reproduce the problem. If I turn off Moodle's debugging settings, then I get the same fails as http://moodle.org/mod/cvsadmin/view.php?tab=unittest. I think you should be running with debugging on Jordan, but we should fix the problem with debugging off.
Hide
Permalink
Tim Hunt added a comment -

So, actually the culprit is $CFG->debugdisplay: MDL-20398 - which I have just fixed. So acutally, there is no problem with the MDLSITE script. It was all MDL bugs. Resolving.

Show
Tim Hunt added a comment - So, actually the culprit is $CFG->debugdisplay: MDL-20398 - which I have just fixed. So acutally, there is no problem with the MDLSITE script. It was all MDL bugs. Resolving.
Hide
Permalink
Jerome Mouneyrac added a comment -

We changed user external file, so the unit test doesn't work anymore, I forgot about them. I apologize for that. I deleted the file, it needs to be rewritten. For the rest moodlebot should unblame me.

Show
Jerome Mouneyrac added a comment - We changed user external file, so the unit test doesn't work anymore, I forgot about them. I apologize for that. I deleted the file, it needs to be rewritten. For the rest moodlebot should unblame me.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.