Pull Requests

MDL-25834 fix for Overlay theme custom menu in IE.

Details

  • Type: Pull Request Pull Request
  • Status: Rejected Rejected
  • Priority: Minor Minor
  • Resolution: Won't Fix
  • Affects Version/s: MOODLE_20_STABLE
  • Fix Version/s: None
  • Component/s: General

Description

Fix for: http://tracker.moodle.org/browse/MDL-25834

This corrects the display of the menu in IE8.

Issue Links

This issue will help resolve:
MDL-25834 Overlay Dropdown Menu Does Not Display Properly in IE8 Blocker Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Sam Hemelryk added a comment -

Thanks John, this has been integrated now.
I made an additional commit before integration to fix white space issues including the use of tabs.

Cheers
Sam

Show
Sam Hemelryk added a comment - Thanks John, this has been integrated now. I made an additional commit before integration to fix white space issues including the use of tabs. Cheers Sam
Hide
Permalink
Sam Hemelryk added a comment -

Testers, to test:

  1. Log in as an admin
  2. Add a custom menu ( Site administration ► Appearance ► Themes ► Theme settings)
  3. Switch to the following themes Fusion, Brick, Splash, Binarius, Arialist
  4. Make sure the custom menu displays fine.

Cheers
Sam

Show
Sam Hemelryk added a comment - Testers, to test:
  1. Log in as an admin
  2. Add a custom menu ( Site administration ► Appearance ► Themes ► Theme settings)
  3. Switch to the following themes Fusion, Brick, Splash, Binarius, Arialist
  4. Make sure the custom menu displays fine.
Cheers Sam
Hide
Permalink
Aparup Banerjee added a comment -

testing this

Show
Aparup Banerjee added a comment - testing this
Hide
Permalink
Aparup Banerjee added a comment - - edited

I used the sample menu shown below the custom menu input in the Theme settings page.

Fusion - "moodle Development" doesn't expand to the 2 sub menu items.
Arialist - does show the expandable menus with any arrows to indicate that they are expandable.

the rest of the themes show up fine.

Show
Aparup Banerjee added a comment - - edited I used the sample menu shown below the custom menu input in the Theme settings page. Fusion - "moodle Development" doesn't expand to the 2 sub menu items. Arialist - does show the expandable menus with any arrows to indicate that they are expandable. the rest of the themes show up fine.
Hide
Permalink
Sam Hemelryk added a comment -

Preparing for testing again.
My appologies I provided the wrong test instructions, to test this you need to test the overlay theme, none of the others.

Show
Sam Hemelryk added a comment - Preparing for testing again. My appologies I provided the wrong test instructions, to test this you need to test the overlay theme, none of the others.
Hide
Permalink
Aparup Banerjee added a comment -

ok, for overlay theme, it displays and expands as expected.. except it doesn't really show indications for a menu item that is expandable...

Show
Aparup Banerjee added a comment - ok, for overlay theme, it displays and expands as expected.. except it doesn't really show indications for a menu item that is expandable...
Hide
Permalink
Aparup Banerjee added a comment -

okay spoke to Sam, we want those expansion arrows, failing this.

Show
Aparup Banerjee added a comment - okay spoke to Sam, we want those expansion arrows, failing this.
Hide
Permalink
Petr Škoda (skodak) added a comment -

Taking over this issue, unfortunately I have to reject it because it was not resolved before the Wednesday deadline, sorry.

Show
Petr Škoda (skodak) added a comment - Taking over this issue, unfortunately I have to reject it because it was not resolved before the Wednesday deadline, sorry.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.