Pull Requests

Fixed checkbox handling at mnet peer services form

Details

  • Type: Pull Request Pull Request
  • Status: Accepted Accepted
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: MOODLE_20_STABLE
  • Fix Version/s: None
  • Component/s: General

Description

We must use advcheckbox here so that unticked checkbox is considered as 0 and not as not-submitted in this case.

Issue Links

This issue will help resolve:
MDL-25647 Peer Services Settings not saving Critical Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Thanks!

To tester: check the status of that checkbox is properly saved (both ticked and unticked).

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Thanks! To tester: check the status of that checkbox is properly saved (both ticked and unticked). Ciao
Hide
Permalink
David Mudrak added a comment -

Sorry, the repository URL was wrong (my fault). The correct value is git://github.com/mudrd8mz/moodle.git

Show
David Mudrak added a comment - Sorry, the repository URL was wrong (my fault). The correct value is git://github.com/mudrd8mz/moodle.git
Hide
Permalink
Petr Škoda (skodak) added a comment -

Integrated, thanks!

Show
Petr Škoda (skodak) added a comment - Integrated, thanks!
Hide
Permalink
Eloy Lafuente (stronk7) added a comment - - edited

testet, thanks!

Edited: *tested

Show
Eloy Lafuente (stronk7) added a comment - - edited testet, thanks! Edited: *tested

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.