[#PULL-244] Removed duplicate string definitions - Moodle Tracker

Details

Type: Pull Request
Status: Accepted
Priority: Minor
Resolution: Fixed
Affects Version/s: MOODLE_20_STABLE
Fix Version/s: None
Component/s: General
Labels:
- pullweek-2011-06

Pull from Repository:
git://github.com/mudrd8mz/moodle.git
Pull Branch:
~~MDL-17357~~-duplicate-strings
Pull Diff URL:
https://github.com/mudrd8mz/moodle/compare/master...MDL-17357-duplicate-strings

Description

This patch fixes syntax issues detected in string files. To detect multiple string definitions, a script https://github.com/mudrd8mz/toolbox/blob/master/checkmultistring/checkmultistring.php was used. There is still one left string in the Quiz module. Tim Hunt asked for not-touching mod/quiz/ as he works on a massive rewrite so I keep it untouched.

TESTING: no testing needed as the patch should not add nor remove any string effectively

Issue Links

This issue will help resolve:
MDL-17357	Remove duplicate string definitions

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 07/Feb/11 10:54 PM

Integrated. Thanks.

Show

Eloy Lafuente (stronk7) added a comment - 07/Feb/11 10:54 PM Integrated. Thanks.

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 07/Feb/11 10:55 PM

The only test I did was to review all the changes were really duplicates (due to unsorted files that was not 100% clear).

Show

Eloy Lafuente (stronk7) added a comment - 07/Feb/11 10:55 PM The only test I did was to review all the changes were really duplicates (due to unsorted files that was not 100% clear).

People

Assignee:

Eloy Lafuente (stronk7)

Reporter:

David Mudrak

Tester:

Eloy Lafuente (stronk7)

Vote (0)

Watch (0)

Dates

Created:

07/Feb/11 10:27 PM

Updated:

09/Feb/11 7:29 PM

Resolved:

09/Feb/11 7:29 PM

Pull Requests

Removed duplicate string definitions