Pull Requests

Repository: Dropbox does not list files if directory name contains a space

Details

  • Type: Pull Request Pull Request
  • Status: Accepted Accepted
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: MOODLE_20_STABLE
  • Fix Version/s: None
  • Component/s: General

Description

To test it:
1. enable dropbox repository plugin: site administration->plugins->repositories->dropbox
2. Add a few folder and files with spaces
2. Use dropbox plugin in file picker, browsing the folders with space, and try to pick a file with space, it should work without problem

Issue Links

This issue will be resolved by:
MDL-26798 Repository: Dropbox does not list files if directory name contains a space Blocker Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Dongsheng,
I've reviewed and tested this.
It will be integrated once Petr has come online and we have decided how we are going to handle integration between master and MOODLE_20_STABLE which now exists.

Cheers
Sam

Show
Sam Hemelryk added a comment - Thanks Dongsheng, I've reviewed and tested this. It will be integrated once Petr has come online and we have decided how we are going to handle integration between master and MOODLE_20_STABLE which now exists. Cheers Sam
Hide
Permalink
Sam Hemelryk added a comment -

Thanks this has been merged to master and cherry-picked to MOODLE_20_STABLE.

Cheers
Sam

Show
Sam Hemelryk added a comment - Thanks this has been merged to master and cherry-picked to MOODLE_20_STABLE. Cheers Sam
Hide
Permalink
Glenn Ansley added a comment -

Confirmed. In 2.0 stable, i could not view or select files inside dropbox folder structure where folder namess contained spaced. I was able to both view and select in integrations

Show
Glenn Ansley added a comment - Confirmed. In 2.0 stable, i could not view or select files inside dropbox folder structure where folder namess contained spaced. I was able to both view and select in integrations

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.