Pull Requests

MDL-23188 Implement custom menu where possible in core themes

Details

  • Type: Pull Request Pull Request
  • Status: Rejected Rejected
  • Priority: Minor Minor
  • Resolution: Won't Fix
  • Affects Version/s: MOODLE_20_STABLE
  • Fix Version/s: None
  • Component/s: General

Description

This adds custom menu to the Serenity and Anomaly themes, the last two core themes without custom menu and should resolve MDL-23188 completely. Also fixes a float issue in Serenity in internet explorer 7.

To test, use serenity and anomaly themes and confirm that the custom menu appears.

Issue Links

Activity

Hide
John Stabinger added a comment -

linking issue

Show
John Stabinger added a comment - linking issue
Hide
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Petr Škoda (skodak) added a comment -

rejecting, the branch does not contain any commits, the cherry picking form master failed and the author field is incorrect (please fix your git.config - use real username and valid email address there)

thanks

Show
Petr Škoda (skodak) added a comment - rejecting, the branch does not contain any commits, the cherry picking form master failed and the author field is incorrect (please fix your git.config - use real username and valid email address there) thanks

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: