commit 933f65148d7ee47ad56d8554936245d79aa62b83
Author: root <root@srv-xen-moodle08.tauntons.ac.uk>
Date:   Wed Oct 14 09:21:42 2009 +0100

    Fixed E_NOTICEs displayed on Concern Module pages

diff --git a/mod/ilpconcern/concerns_view.php b/mod/ilpconcern/concerns_view.php
index e89c13e..b663a80 100644
--- a/mod/ilpconcern/concerns_view.php
+++ b/mod/ilpconcern/concerns_view.php
@@ -310,16 +310,16 @@ if($action == 'updateconcern'){
     $tabs = array();
        $tabrows = array();
 
-        if($CFG->ilpconcern_report1 == 1){
+        if(!empty($CFG->ilpconcern_report1) && $CFG->ilpconcern_report1 == 1){
         $tabrows[] = new tabobject('0', "$link_values&amp;status=0", get_string('report1', 'ilpconcern'));
         }
-        if($CFG->ilpconcern_report2 == 1){
+        if(!empty($CFG->ilpconcern_report2) && $CFG->ilpconcern_report2 == 1){
         $tabrows[] = new tabobject('1', "$link_values&amp;status=1", get_string('report2', 'ilpconcern'));
         }
-        if($CFG->ilpconcern_report3 == 1){
+        if(!empty($CFG->ilpconcern_report3) && $CFG->ilpconcern_report3 == 1){
         $tabrows[] = new tabobject('2', "$link_values&amp;status=2", get_string('report3', 'ilpconcern'));
         }
-        if($CFG->ilpconcern_report4 == 1){
+        if(!empty($CFG->ilpconcern_report4) && $CFG->ilpconcern_report4 == 1){
         $tabrows[] = new tabobject('3', "$link_values&amp;status=3", get_string('report4', 'ilpconcern'));
         }
 
@@ -336,16 +336,16 @@ if($action == 'updateconcern'){
 
         echo '<div class="addbox">';
 
-            if($CFG->ilpconcern_report1 == 1 && (has_capability('mod/ilpconcern:addreport1', $context) || ($USER->id == $user->id && has_capability('mod/ilpconcern:addownreport1', $context)))) {
+            if(!empty($CFG->ilpconcern_report1) && $CFG->ilpconcern_report1 == 1 && (has_capability('mod/ilpconcern:addreport1', $context) || ($USER->id == $user->id && has_capability('mod/ilpconcern:addownreport1', $context)))) {
                 echo '<a href="'.$link_values.'&amp;action=updateconcern&amp;status=0">'.get_string('addconcern', 'ilpconcern', get_string('report1', 'ilpconcern')).'</a>';
             }
-            if($CFG->ilpconcern_report2 == 1 && (has_capability('mod/ilpconcern:addreport2', $context) || ($USER->id == $user->id && has_capability('mod/ilpconcern:addownreport2', $context)))) {
+            if(!empty($CFG->ilpconcern_report2) && $CFG->ilpconcern_report2 == 1 && (has_capability('mod/ilpconcern:addreport2', $context) || ($USER->id == $user->id && has_capability('mod/ilpconcern:addownreport2', $context)))) {
                 echo '<a href="'.$link_values.'&amp;action=updateconcern&amp;status=1">'.get_string('addconcern', 'ilpconcern', get_string('report2', 'ilpconcern')).'</a>';
             }
-            if($CFG->ilpconcern_report3 == 1 && (has_capability('mod/ilpconcern:addreport3', $context) || ($USER->id == $user->id && has_capability('mod/ilpconcern:addownreport3', $context)))) {
+            if(!empty($CFG->ilpconcern_report3) && $CFG->ilpconcern_report3 == 1 && (has_capability('mod/ilpconcern:addreport3', $context) || ($USER->id == $user->id && has_capability('mod/ilpconcern:addownreport3', $context)))) {
                 echo '<a href="'.$link_values.'&amp;action=updateconcern&amp;status=2">'.get_string('addconcern', 'ilpconcern', get_string('report3', 'ilpconcern')).'</a>';
             }
-            if($CFG->ilpconcern_report4 == 1 && (has_capability('mod/ilpconcern:addreport4', $context) || ($USER->id == $user->id && has_capability('mod/ilpconcern:addownreport4', $context)))) {
+            if(!empty($CFG->ilpconcern_report4) && $CFG->ilpconcern_report4 == 1 && (has_capability('mod/ilpconcern:addreport4', $context) || ($USER->id == $user->id && has_capability('mod/ilpconcern:addownreport4', $context)))) {
                 echo '<a href="'.$link_values.'&amp;action=updateconcern&amp;status=3">'.get_string('addconcern', 'ilpconcern', get_string('report4', 'ilpconcern')).'</a>';
             }
 
diff --git a/mod/ilpconcern/view_students.php b/mod/ilpconcern/view_students.php
index 00684ec..1a025b0 100644
--- a/mod/ilpconcern/view_students.php
+++ b/mod/ilpconcern/view_students.php
@@ -198,24 +198,24 @@
     $tablecolumns = array('picture', 'fullname');
     $tableheaders = array('', get_string('fullname'));
 
-    if($CFG->ilpconcern_status_per_student == 1){
+    if(!empty($CFG->ilpconcern_status_per_student) && $CFG->ilpconcern_status_per_student == 1){
         $tablecolumns[] .= 'status';
         $tableheaders[] .= get_string('studentstatus', 'ilpconcern');
     }
 
-    if($CFG->ilpconcern_report1 == 1){
+    if(!empty($CFG->ilpconcern_report1) && $CFG->ilpconcern_report1 == 1){
         $tablecolumns[] .= 'report1';
         $tableheaders[] .= '';
     }
-    if($CFG->ilpconcern_report2 == 1){
+    if(!empty($CFG->ilpconcern_report2) && $CFG->ilpconcern_report2 == 1){
         $tablecolumns[] .= 'report2';
         $tableheaders[] .= '';
     }
-    if($CFG->ilpconcern_report3 == 1){
+    if(!empty($CFG->ilpconcern_report3) && $CFG->ilpconcern_report3 == 1){
         $tablecolumns[] .= 'report3';
         $tableheaders[] .= '';
     }
-    if($CFG->ilpconcern_report4 == 1){
+    if(!empty($CFG->ilpconcern_report4) && $CFG->ilpconcern_report4 == 1){
         $tablecolumns[] .= 'report4';
         $tableheaders[] .= '';
     }
@@ -426,22 +426,22 @@
                 $row[] .= '<span class="status-'.$studentstatus.'">'.$thisstudentstatus.'</span>';
             }
 
-            if($CFG->ilpconcern_report1 == 1){
+            if(!empty($CFG->ilpconcern_report1) && $CFG->ilpconcern_report1 == 1){
                 $report1total = count_records_sql('SELECT COUNT(*) FROM '.$CFG->prefix.'ilpconcern_posts WHERE setforuserid = '.$auser->id.' AND status = 0' );
                 $report1text  = '<a href="concerns_view.php'.$link_values.'&amp;userid='.$auser->id.'&amp;status=0">'.$report1total.' '.get_string('report1plural', 'ilpconcern').'</a>';
                 $row[] .= $report1text;
             }
-            if($CFG->ilpconcern_report2 == 1){
+            if(!empty($CFG->ilpconcern_report2) && $CFG->ilpconcern_report2 == 1){
                 $report2total = count_records_sql('SELECT COUNT(*) FROM '.$CFG->prefix.'ilpconcern_posts WHERE setforuserid = '.$auser->id.' AND status = 1' );
                 $report2text  = '<a href="concerns_view.php'.$link_values.'&amp;userid='.$auser->id.'&amp;status=1">'.$report2total.' '.get_string('report2plural', 'ilpconcern').'</a>';
                 $row[] .= $report2text;
             }
-            if($CFG->ilpconcern_report3 == 1){
+            if(!empty($CFG->ilpconcern_report3) && $CFG->ilpconcern_report3 == 1){
                 $report3total = count_records_sql('SELECT COUNT(*) FROM '.$CFG->prefix.'ilpconcern_posts WHERE setforuserid = '.$auser->id.' AND status = 2' );
                 $report3text  = '<a href="concerns_view.php'.$link_values.'&amp;userid='.$auser->id.'&amp;status=2">'.$report3total.' '.get_string('report3plural', 'ilpconcern').'</a>';
                 $row[] .= $report3text;
             }
-            if($CFG->ilpconcern_report4 == 1){
+            if(!empty($CFG->ilpconcern_report4) && $CFG->ilpconcern_report4 == 1){
                 $report4total = count_records_sql('SELECT COUNT(*) FROM '.$CFG->prefix.'ilpconcern_posts WHERE setforuserid = '.$auser->id.' AND status = 3' );
                 $report4text  = '<a href="concerns_view.php'.$link_values.'&amp;userid='.$auser->id.'&amp;status=3">'.$report4total.' '.get_string('report4plural', 'ilpconcern').'</a>';
                 $row[] .= $report4text;