Moodle Tracker

[CONTRIB-3643] ouwiki: page deletion capability - should not it be given to all non-student roles?

Mon, 14 May 2012 19:50:36 +0800

mod/ouwiki:deletepage is currently granted to manager only, so teachers are not able to delete pages in ouwikies in the own courses.

[CONTRIB-3524] Should support 'Show Description' feature

Thu, 15 Mar 2012 19:58:20 +0800

The ouwiki module should support the show description feature to display the module's description on the front page

[CONTRIB-3360] OU wiki: Should define capabilities used: error get_in_or_equal() does not accept empty arrays

Dependency — Thu, 26 Jan 2012 06:56:00 +0800

moodle_database::get_in_or_equal() does not accept empty arrays

Stack trace:

line 595 of /lib/dml/moodle_database.php: coding_exception thrown
line 6410 of /lib/accesslib.php: call to moodle_database->get_in_or_equal()
line 7161 of /lib/accesslib.php: call to context_module->get_capabilities()
line 69 of /admin/roles/lib.php: call to fetch_context_capabilities()
line 261 of /admin/roles/lib.php: call to capability_table_base->__construct()
line 191 of /admin/roles/permissions.php: call to permissions_table->__construct()

[CONTRIB-3319] Bug when trying to display Index of the Wiki or History

Sun, 22 Jan 2012 21:14:03 +0800

This has to be fixed by a programmer : required_param() requires $parname and $type to be specified (parameter: id)
Stack trace:
line 487 of /lib/moodlelib.php: coding_exception thrown
line 32 of /mod/ouwiki/wikiindex.php: call to required_param()

Moodle 2.2+ (Build: 20111223)

[CONTRIB-3309] Badly defined foreign keys in ouwiki

Mon, 19 Dec 2011 22:40:50 +0800

Attached patch fixes the issue

[CONTRIB-3235] OUWiki module sometime fails to be deleted

Mon, 7 Nov 2011 22:16:26 +0800

In ouwiki version 2011031800, deleting a wiki isn't coded correctly. Please apply attached patch file.

[CONTRIB-3209] Missing language string for capability deletepage

Fri, 14 Oct 2011 21:59:43 +0800

Missing language string for capability deletepage

[CONTRIB-2584] unable to revert to old page version

Tue, 7 Dec 2010 19:45:15 +0800

After choosing a version to revert to (in the History page)
I get a page asking me to confirm the revert operation.
Clicking the confirm button does not revert to the selected version
and display the page again.

Changing revert.php line 36 from:

if($confirmed) {

To:

if($confirmed or $_POST['confirm']) {

Solved this issue.

I am using version 2010042201

[CONTRIB-2574] OU search: Change wording for 'More results' link

Thu, 2 Dec 2010 19:16:26 +0800

Change text from 'Find more results' to 'More results', some people thought it meant to start a whole new search.

[CONTRIB-2564] OU search: Generated query includes a lot of duplicate, unnecessary information

Tue, 30 Nov 2010 20:54:02 +0800

When searching all forums (eg) on a course, the OU search system generates queries with horrible, duplicated and unnecessary data. These queries should be tidied to make it easier to track down problems (also might possibly improve performance).

[CONTRIB-2560] OU search: Causes errors for very long words (>255 characters)

Fri, 26 Nov 2010 23:51:06 +0800

In modules that use the OU search block, typing in a very long word (qqqqqqqqq... and so on for more than 255 characters) caused an error as it tries to insert them into the full-text search index table (blocks_ousearch_words).

I will fix this by restricting words to 255 characters and doing the same on search so that you can also search for them. The number will be a constant so it could potentially be reduced much further in future (but that will require upgrade).

[CONTRIB-2488] OU search: Search with groups broken in MySQL

Wed, 3 Nov 2010 23:44:11 +0800

The OU search block fails in MySQL when you search a wiki, forum, or blog that is using groups. This is due to a missing space.

[CONTRIB-2486] Wiki: 'Create page' lets you create page that already exists

Wed, 3 Nov 2010 20:04:25 +0800

1. On a wiki, create a page called Frog.

2. Go back to start page. Type Frog in 'Create page' box again and click create
button.

This should print an error warning you that the page already exists. At present
it tries to 'create' the page again, which is silly.

[CONTRIB-2482] OU wiki: Non-JS mode does not override timeout when in 3 minute mode

Wed, 3 Nov 2010 01:39:51 +0800

In OU wiki, when not using JavaScript, all pages are supposed to have a 15 minute editing timeout.

When you choose the 3 minute timeout option for testing (which affects JS users), the non-JS timeout should remain at 15 minutes. In fact, it about half changes, but users are still told they have 15 minutes.

Correct fix is to make it 15 mins without JS.

[CONTRIB-2481] OU wiki: Timeout feature does not work

Tue, 2 Nov 2010 23:12:47 +0800

Somebody broke the timeout feature. It appears to have no effect at present.

[CONTRIB-2477] OU wiki: 'Create page' appears for visible groups when you don't have access (OU 11056)

Mon, 1 Nov 2010 19:31:02 +0800

Create a 'group' wiki with visible groups.

Visit wiki as student. Change group to a group that isn't yours. There is a
'Create page' button (although if you click it you get a 'permission denied'
error). This button should not be present because you don't have access to
create pages in somebody else's group

[CONTRIB-2470] OU wiki, OU search: Add/update files needed to create 'stable build'

Thu, 28 Oct 2010 22:19:47 +0800

We need to put in some support files for ousearch, and update the ones for ouwiki, so that stable build works.

[CONTRIB-2458] OU wiki: individual wiki / view in group does not honour course default grouping

Fri, 22 Oct 2010 00:39:57 +0800

When using individual wikis, if you have permission to view only people in your own group, then it should use the course 'default grouping id' to restrict the groups that are considered.

[CONTRIB-2403] Call-time pass-by-reference has been deprecated

Fri, 1 Oct 2010 17:22:19 +0800

I tried using OU Wiki in 1.9.5. I can add the activity, but it asks me to first create a page. When I click "Create page" I get
PHP Warning: Call-time pass-by-reference has been deprecated in C:\inetpub\wwwroot\moodle\mod\ouwiki\edit.php on line 338

[CONTRIB-2340] OU wiki: Not in synch with recent OU changes

Tue, 7 Sep 2010 00:59:37 +0800

The OU wiki has not been kept in synch with recent OU changes, since the introduction of annotation (intended to replace comments, but actually available alongside comments for now), but also including some other improvements.

Under this bug I am going to synchronize the two code bases and we will try to keep in synch from now on.

There will hopefully be a stable version of OU wiki, initially in about a month, then becoming 'really' stable (equivalent to OU live release) in December.

[CONTRIB-2067] ouwiki: lets you click Save/Preview twice, causes confusion

Tue, 18 May 2010 19:52:08 +0800

In OU wiki when editing a page, it does not disable the Save/Preview buttons after clicking them. This means users can submit the form twice, which causes confusing errors.

[CONTRIB-2054] Replace OUSite config variable in OU contributed modules

Tue, 11 May 2010 23:41:10 +0800

We're removing the $CFG->ousite variable in OU moodle and replacing it with a more flexible system based on a new object ouflags. So rather than doing if (isset($CFG->ousite) ) to switch on ou specific bits of our contrib code, we should in future use if (class_exists('ouflags')).

The impact on non-ou sites of this change is non-existent!

[CONTRIB-2017] ouwiki: added get_last_modified API (to support OU requirements)

Thu, 22 Apr 2010 19:42:40 +0800

I added a new api function ouwiki_get_last_modified; this is for use by a dashboard feature we have here. It isn't called anywhere in core code, however it might be useful to other integrators.

[CONTRIB-1944] Distinguish the search string within the ouwiki from the global search string

Sat, 27 Mar 2010 00:08:55 +0800

The 'Search' feature within ouwiki uses the same string as in the site global 'Search' feature. Some users have expressed confusion between these.

I suggest adjusting the ouwiki search string to 'Search wiki', which should solve the issue.

[CONTRIB-1845] ouwiki: error when trying to delete own comments

Tue, 23 Feb 2010 18:33:02 +0800

When you are not admin and try to delete your own comment (so that you get the 'are you sure' prompt), the delete fails.

[CONTRIB-1807] hebrew translation

Tue, 28 Sep 2010 22:42:07 +0800

hebrew translation

(thank you for a beautiful module!)

[CONTRIB-1788] Link on the My page incorrect (fix inside)

Blockers — Fri, 5 Feb 2010 21:10:47 +0800

The link shown on the My page for a wiki incorrectly uses /mod/ouwiki/view.php?wid=<id from the wiki table> and yields the error "A required parameter (id) was missing" when clicked.

The fix is to modify /mod/ouwiki/lib.php line 433 to use the course module id:

$CFG->wwwroot.'/mod/ouwiki/view.php?id='.$new[$wiki->id]->cmid.'">'.

[CONTRIB-1726] OU wiki: Long page names cause database insert errors

Fri, 15 Jan 2010 20:49:12 +0800

If you create a wiki page containing a link to a very long page name, such as

[[This is a really long page name. It goes on and on and on and on. In fact it's not so much a name as a paragraph. I just want to keep typing! Forever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever and ever!]]

then this causes database errors because the name is more than 255 characters long.

My proposed solution is to limit page name length to 200 characters; if you specify a longer link (such as the above) then only the first 200 characters will actually be a link. I might be nice and make it cut off at word boundary a la shorten_text, not sure.

[CONTRIB-1679] ouwiki: 'Add section' fails with apostrophes in names

Tue, 8 Dec 2009 19:38:40 +0800

(reported by our QA)

In the text for 'adding a new section to this page'I included a couple of
apostrophes (screenprint 1). They both seem to have a \ prefix added
(screenprints 2 and 3).

I tried putting in some other apostrophes in the text but they did not gain the
\ prefix (screenprint 3).

[CONTRIB-1673] Support | syntax for page name and link different

Thu, 3 Dec 2009 23:14:16 +0800

Normal wiki syntax lets you do [[page name | display text]] and ouwiki should do the same so that you can specify what the page is to be called, but link to it with a different text string.

[CONTRIB-1672] ouwiki link on mymoodle broken

Blockers — Tue, 2 Feb 2010 23:33:46 +0800

link generates a coursemodule error. This is becuase I've used wid not id (based on original core wiki mymoodle integration) and passed the id from the ouwiki table not the coursemodule id which the view page expects.

[CONTRIB-1481] Contrib OU wiki undefined index HTTP_USER_AGENT notices in PHP log

Tue, 18 Aug 2009 18:35:22 +0800

The following notices are appearing, the second notice only when debugging is
turned on, in the PHP logs:

[18-Aug-2009 01:05:11] PHP Notice: Undefined index: HTTP_USER_AGENT in
/vle/www_root/mod/ouwiki/feed-wikihistory.php on line 36
[18-Aug-2009 01:05:11] PHP Warning: Cannot modify header information - headers
already sent by (output started at
/vle/www_root/mod/ouwiki/feed-wikihistory.php:36) in
/vle/www_root/mod/ouwiki/feed-wikihistory.php on line 44

[CONTRIB-1441] Adding two minor functions to ouwiki - print_overview and user_outline

Sat, 25 Jul 2009 00:30:23 +0800

Adding two minor function to lib.php:- ouwiki_print_overview and ouwiki_user_outline.

[CONTRIB-1381] OU wiki: Improve user interface for adding pages, sections

Mon, 29 Jun 2009 23:38:22 +0800

Improve OU wiki user interface following usability testing:

1) Add new 'Create page' button that appears at the bottom when viewing pages. This makes it easier to create a page. It creates a new page, adding a link to the bottom of the page you started from.

2) Add new 'Create section' button, also below the page. This starts the 'edit section' view with a new blank section at the end of the document, containing a heading and information about your name. This is supposed to encourage students who are scared of editing other people's work but want to add something.

[CONTRIB-1370] OU wiki: Invalid XHTML issues

Tue, 23 Jun 2009 00:26:14 +0800

The ouwiki has some XHTML validation errors:

1) When printing the 'this page is linked from' list at the bottom of page, a closing </div> is omitted.

2) The comment form does not have a <div> around the elements inside <form>.

3) A label has an incorrect for= attribute.

[CONTRIB-1080] ouwiki: Copy/paste in HTML editor can result in duplicate section IDs

Mon, 2 Mar 2009 22:54:09 +0900

ouwiki adds id= to headings to distinguish them as sections for commenting etc.

Unfortunately if you use html editor and copy/paste a section when writing a new section, you end up with two with the same ID!

this breaks all sorts of things

[CONTRIB-1036] ouwiki: When a page has not been created, the edit tab shouldn't be available

Wed, 18 Feb 2009 00:47:52 +0900

Our technical testing didn't like that the 'Edit' tab is available at the point where you view a wiki page that hasn't been created. They felt this was confusing as you should not be able to edit an uncreated page.

I have made it grey out the edit tab in that case (note: the tab is inactive - depends on your theme how it appears).

[CONTRIB-1024] ouwiki: string is not correctly escaped for JavaScript, + YUI issue

Tue, 10 Feb 2009 20:59:24 +0900

The 'lockcancelled' string is sent to JavaScript without being escaped for that language. There may be other strings. In addition there is another YUI error (missing include) that I probably need to fix.

[CONTRIB-1004] Paste from Word causes 'Data Too Long' error in IE6

Fri, 26 Jun 2009 00:54:42 +0800

If you copy and past entries from Word into the OUWiki, you get an error:

Database problem: Data too long for column 'xhtml' at row 1 (code OUWIKI-E:\Websites\...oursite...\root\moodle183\mod\ouwiki\ouwiki.php/1614)

It appears to be generated because of the additional markup from Word text, as the actual entries are not excessively long. The workaround we are currently using is to ask students to use the Word Cleanup button or use text mode for editing, but this seems beyond the capability of some of our students.

[CONTRIB-985] OU wiki: Improve accessibility of 'diff' page

Wed, 21 Jan 2009 02:09:01 +0900

The diff page on the ouwiki is not very usable with screenreaders. We are going to make the following changes:

1) Show a different information message at the start when there are no changes, or when there are no changes to words (ie only html changes that don't get marked by the diff system).

2) Standardise 'added' and 'deleted' display sso these both use images before and after. Add a sentence (visible only to screenreader users) that tells people this is happening. This is supposed to let screenreader users know that they can use their 'skip to image' shortcut to jump to the next change.

[Note: I changed an existing language string, advice_diff, to add this hidden text. Sorry.]

[CONTRIB-976] OU wiki: Add contributed language pack

Thu, 15 Jan 2009 23:59:29 +0900

French language pack was submitted, must add this to cvs.

[CONTRIB-975] OU wiki: Two strings not localisable in ouwiki.js

Thu, 15 Jan 2009 19:42:03 +0900

There are two strings 'Close comments' and 'Close comment form' in the JavaScript which cannot be localised.

[CONTRIB-864] fix ouwiki whitespace according to official coding style recommendations

Sun, 16 Jan 2011 05:47:00 +0800

fix ouwiki whitespace according to official coding style recommendations

[CONTRIB-861] store ouwiki templates in db

Sun, 16 Jan 2011 05:41:24 +0800

store ouwiki templates in db

[CONTRIB-860] convert ouwiki dml calls

Sun, 16 Jan 2011 05:41:13 +0800

convert ouwiki dml calls

[CONTRIB-859] add separa basicpage_magic.php

Tue, 4 Nov 2008 18:01:39 +0900

add separa basicpage_magic.php

[CONTRIB-858] rename ouwiki.php to locallib.php

Tue, 4 Nov 2008 18:03:09 +0900

rename ouwiki.php to locallib.php

[CONTRIB-857] convert ou search

Mon, 9 Jan 2012 19:30:15 +0800

adding a list of tasks for later

[CONTRIB-856] convert ouwiki exceptions to standard exceptions

Thu, 6 Nov 2008 00:33:41 +0900

convert ouwiki exceptions to standard exceptions

[CONTRIB-855] do not use REQUEST_URI for url guessing, reconstruct url instead

Tue, 4 Nov 2008 18:01:22 +0900

do not use REQUEST_URI for url guessing, reconstruct url instead

[CONTRIB-770] OUwiki review

Sun, 16 Jan 2011 05:40:45 +0800

review OU wiki

[CONTRIB-769] OUWiki broken rss icon image

Thu, 30 Oct 2008 01:46:46 +0900

There is an "/i/" missing in following url:
img src="'.$CFG->pixpath.'/rss.gif" alt=""

found in:
history.php
wikihistory.php