Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-10

Dialogue entries not backed up

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4.3
    • Fix Version/s: None
    • Component/s: Module: Dialogue
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_14_STABLE

      Description

      During the backup only one - last - dialogue entry is backed up.

      Proposed (and tested) solution - in the mod/dialogue/backuplib.php change the lines as follows:

      #95

      now: $status = backup_dialogue_entries($bf,$preferences,$conversation->id);

      proposed: $status = backup_dialogue_entries($bf,$preferences,$dialogue);

      We need to back up entries for the whole dialogue, not only for the last processed conversation, so consequently:

      #105

      now: function backup_dialogue_entries ($bf,$preferences,$conversationid) {

      proposed: function backup_dialogue_entries ($bf,$preferences,$dialogue) {

      #111

      now: $dialogue_entries = get_records(dialogue_entries,conversationid,$conversationid,id);

      proposed: $dialogue_entries = get_records(dialogue_entries,dialogueid,$dialogue,id);

      Dan

        Attachments

          Activity

            People

            Assignee:
            dougiamas Martin Dougiamas
            Reporter:
            mixik Daniel Miksik
            Participants:
            Component watchers:
            Troy Williams
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: