Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-10

Dialogue entries not backed up

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.4.3
    • None
    • Module: Dialogue
    • None
    • All
    • MOODLE_14_STABLE

    Description

      During the backup only one - last - dialogue entry is backed up.

      Proposed (and tested) solution - in the mod/dialogue/backuplib.php change the lines as follows:

      #95

      now: $status = backup_dialogue_entries($bf,$preferences,$conversation->id);

      proposed: $status = backup_dialogue_entries($bf,$preferences,$dialogue);

      We need to back up entries for the whole dialogue, not only for the last processed conversation, so consequently:

      #105

      now: function backup_dialogue_entries ($bf,$preferences,$conversationid) {

      proposed: function backup_dialogue_entries ($bf,$preferences,$dialogue) {

      #111

      now: $dialogue_entries = get_records(dialogue_entries,conversationid,$conversationid,id);

      proposed: $dialogue_entries = get_records(dialogue_entries,dialogueid,$dialogue,id);

      Dan

      Attachments

        Activity

          People

            dougiamas Martin Dougiamas
            mixik Daniel Miksik
            Troy Williams
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: