Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-1503

Export Attendance file corrupted if Manager's email not set

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.9.4
    • 1.9.5
    • None
    • None
    • Mac OS X 10.4, PHP 5.2.5, MySQL 5.0.41
    • Easy
    • MOODLE_19_STABLE
    • MOODLE_19_STABLE

    Description

      Steps to reproduce:
      1. Set facetoface_addchangemanageremail global setting to "No" in site admin > modules > activities > face-to-face
      2. Create a face-to-face (uncheck all send notice to manager boxes)
      3. Export attendance (Excel or OpenDocument format)

      What should happen:
      File contains face-to-face attendance details

      What actually happens:
      File corrupted. See attached file for example.

      Fix:
      Bug is caused by attempt to write an object property that has not been set. Attached patch (download-attendance.patch.txt) provides fix by checking property is set before writing.

      Attachments

        1. Corrupted Attendance File.xls
          5 kB
          Simon Coggins
        2. download-attendance.patch.txt
          1 kB
          Simon Coggins

        Activity

          People

            francois Francois Marier
            simoncoggins Simon Coggins
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              13/May/09