Add-ons
  1. Add-ons
  2. CONTRIB-1613

When marking students as "seen", teacher receives a notification e-mail

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.5
    • Fix Version/s: None
    • Component/s: Module: Scheduler
    • Labels:
      None
    • Environment:
      Ubuntu Server 8.04 LTS
    • Affected Branches:
      MOODLE_19_STABLE
    • Rank:
      21645

      Description

      When the teacher marks a student as "seen" in the main teacher view, and notifications are enabled, he receives a notification e-mail that the appointment has been "cancelled or moved". This is apparently incorrect.

      The e-mail is generated in the function scheduler_delete_calendar_events() in locallib.php. It seems that this part of the code is executed only in the above case. (The notification sent when a student cancels the appointment is generated in a different part of the code.) In any case, it seems highly unexpected that scheduler_delete_calendar_events(), which is supposed to modify the calendar, has the side effect of sending e-mails.

      I therefore propose to remove the part of the code that sends this e-mail; see patch attached.

        Activity

        Hide
        Scott Krajewski added a comment -

        scheduler_delete_calendar_events is called in studentview.controller.php when a savechoice or disengage happens. This is confusing when the appointment can have multiple students. When it has multiple students the teacher gets an email from each student that the appointment has been "cancelled or moved."

        Show
        Scott Krajewski added a comment - scheduler_delete_calendar_events is called in studentview.controller.php when a savechoice or disengage happens. This is confusing when the appointment can have multiple students. When it has multiple students the teacher gets an email from each student that the appointment has been "cancelled or moved."
        Hide
        Henning Bostelmann added a comment -

        This is fixed in the 2.0 branch.

        Show
        Henning Bostelmann added a comment - This is fixed in the 2.0 branch.
        Hide
        Henning Bostelmann added a comment -

        Closing all resolved scheduler issues that had no activity in the past month.

        Show
        Henning Bostelmann added a comment - Closing all resolved scheduler issues that had no activity in the past month.

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development