Add-ons
  1. Add-ons
  2. CONTRIB-1695

Run time warning error in Course Menu (YUI menu)

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9, 1.9.1, 1.9.2, 1.9.3, 1.9.4, 1.9.5, 1.9.7
    • Fix Version/s: None
    • Component/s: Block: YUI menu
    • Labels:
      None
    • Environment:
      PHP 5.2.8 FreeBSD 7, MySQL 5
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_19_STABLE
    • Rank:
      22602

      Description

      I have just done a CVS update of blocks/yui_menu and tested it on 1.9.5 and 1.9.7 moodle test installs with Debugging "Shaow all reasonable PHP debug messages". I get this warning when executing admin/index.php:

      Warning: Call-time pass-by-reference has been deprecated in /usr/home/markp/public_html/moo-t95/blocks/yui_menu/block_yui_menu.php on line 63

      I running php 5.2.8 and I think it's an issue with php 5 having more strict rules about parameter passing but I could be utterly wrong....

        Activity

        Hide
        Alan Trick added a comment -

        Thanks for the bug report. I'm on holidays right now but I'll look into this when I get back to work in January. For now it will probably will work fine.

        Show
        Alan Trick added a comment - Thanks for the bug report. I'm on holidays right now but I'll look into this when I get back to work in January. For now it will probably will work fine.
        Hide
        Alan Trick added a comment -

        It's not 5.2.8, we're using 5.2.9 and it's not an issue here. It turns out there's a PHP setting (allow_call_time_pass_reference) that is turned on by default (source: http://wiki.php.net/rfc/calltimebyref). I guess you have it turned off.

        I've made some changes and I think it's fixed, but I haven't been able to trigger the problem, so I'm not 100% sure it's fixed. Please test it and let me know.

        Show
        Alan Trick added a comment - It's not 5.2.8, we're using 5.2.9 and it's not an issue here. It turns out there's a PHP setting (allow_call_time_pass_reference) that is turned on by default (source: http://wiki.php.net/rfc/calltimebyref ). I guess you have it turned off. I've made some changes and I think it's fixed, but I haven't been able to trigger the problem, so I'm not 100% sure it's fixed. Please test it and let me know.
        Hide
        Mark Pearson added a comment -

        Brilliant! Thanks Alan.
        I will check this first thing tomorrow. And a happy Russian Christmas!

        Show
        Mark Pearson added a comment - Brilliant! Thanks Alan. I will check this first thing tomorrow. And a happy Russian Christmas!
        Hide
        Mark Pearson added a comment -

        Yep. That fixed it. Ta!

        Show
        Mark Pearson added a comment - Yep. That fixed it. Ta!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development