Add-ons
  1. Add-ons
  2. CONTRIB-1709

Bring Banner/Luminis Message Broker into CONTRIB

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.8
    • Fix Version/s: 1.9
    • Component/s: Enrol: Banner/LMB
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE
    • Rank:
      34044

      Description

      I would like the Banner/Luminis Message Broker module to be reviewed and brought into CONTRIB (I am the main coder for this module).

      Attached is the most recent bundle.

      It is being actively worked on to expand the documentation and improve the coding style (it generally complies with the coding guidelines already, but some functions are not fully documented)

      -Eric

        Activity

        Hide
        Eric Merrill added a comment -

        Alrighty then... That one I uploaded (0.8.2) has a pretty bad bug on the settings page. I accidentally included the wrong version of two of the files in there.

        How about we try 0.8.3 instead...

        -eric

        Show
        Eric Merrill added a comment - Alrighty then... That one I uploaded (0.8.2) has a pretty bad bug on the settings page. I accidentally included the wrong version of two of the files in there. How about we try 0.8.3 instead... -eric
        Hide
        Anthony Borrow added a comment -

        Eric - Thanks for sharing this code with the community. I have added the code to CVS, created the Enrol: LMB component in the tracker, and bumped your privileges in the tracker so that you can manage issues related to the LMB enrollment plugin. Please review http://docs.moodle.org/en/Development:Guidelines_for_contributed_code to make sure we cover all the little details about recommendations for creating a Moodle Docs page, making use of the download server, and the Modules and Plugins entry. If you have not done so already, please apply for CVS write access to contrib/plugins/enrol/lmb and I will get that approved for you. I did rename the README file to README.txt but otherwise I did not make any changes other than deleting some of the Mac related files and the hidden SVN files. Let me know if you have any questions or need anything. Peace - Anthony

        Show
        Anthony Borrow added a comment - Eric - Thanks for sharing this code with the community. I have added the code to CVS, created the Enrol: LMB component in the tracker, and bumped your privileges in the tracker so that you can manage issues related to the LMB enrollment plugin. Please review http://docs.moodle.org/en/Development:Guidelines_for_contributed_code to make sure we cover all the little details about recommendations for creating a Moodle Docs page, making use of the download server, and the Modules and Plugins entry. If you have not done so already, please apply for CVS write access to contrib/plugins/enrol/lmb and I will get that approved for you. I did rename the README file to README.txt but otherwise I did not make any changes other than deleting some of the Mac related files and the hidden SVN files. Let me know if you have any questions or need anything. Peace - Anthony
        Hide
        Anthony Borrow added a comment -

        I am marking as resolved since the code is now in CVS, tracker component created, etc. Once CVS write access is taken care of you should have all you need to maintain things. Keep in mind that CVS commit comments should contain a Moodle tracker issue number so that it is linked to a particular issue. This goes a long way toward explaining why changes were made to the code (the obvious exception being something simple like correcting a typo). I added the code to the HEAD branch; however, if you need a separate branch for 1.9 and want to use HEAD for development purposes just let me know and we can take care of that as well. Feel free to comment here if you need anything. Peace - Anthony

        Show
        Anthony Borrow added a comment - I am marking as resolved since the code is now in CVS, tracker component created, etc. Once CVS write access is taken care of you should have all you need to maintain things. Keep in mind that CVS commit comments should contain a Moodle tracker issue number so that it is linked to a particular issue. This goes a long way toward explaining why changes were made to the code (the obvious exception being something simple like correcting a typo). I added the code to the HEAD branch; however, if you need a separate branch for 1.9 and want to use HEAD for development purposes just let me know and we can take care of that as well. Feel free to comment here if you need anything. Peace - Anthony
        Hide
        Anthony Borrow added a comment -

        p.s. - Obviously there is no need for you to apply for write access as you already have it. Thanks for creating the tracker issue to ensure that all of the little details get done with the tracker.

        Show
        Anthony Borrow added a comment - p.s. - Obviously there is no need for you to apply for write access as you already have it. Thanks for creating the tracker issue to ensure that all of the little details get done with the tracker.
        Hide
        Eric Merrill added a comment -

        Thank you very much Anthony. I do think a separate branch for the 1.9 release would be helpful. There are a few changes that will likely require large amounts of changes and testing, so it would be useful to be able to commit those to HEAD as a dev trunk (and eventually for Moodle 2.0 work). I don't know if I can create a new trunk in the LMB project or if you need to.

        Thanks
        -Eric

        Show
        Eric Merrill added a comment - Thank you very much Anthony. I do think a separate branch for the 1.9 release would be helpful. There are a few changes that will likely require large amounts of changes and testing, so it would be useful to be able to commit those to HEAD as a dev trunk (and eventually for Moodle 2.0 work). I don't know if I can create a new trunk in the LMB project or if you need to. Thanks -Eric
        Hide
        Eric Merrill added a comment -

        Also, would it be possible to change the tracker project name to Banner/LMB (or Banner-LMB) from just LMB?

        Thanks again,
        -Eric

        Show
        Eric Merrill added a comment - Also, would it be possible to change the tracker project name to Banner/LMB (or Banner-LMB) from just LMB? Thanks again, -Eric
        Hide
        Anthony Borrow added a comment -

        Eric - I have added the code to the MOODLE_19_STABLE branch of CONTRIB so you should have two branches now to work with. Let me know if you need anything. Peace - Anthony

        Show
        Anthony Borrow added a comment - Eric - I have added the code to the MOODLE_19_STABLE branch of CONTRIB so you should have two branches now to work with. Let me know if you need anything. Peace - Anthony
        Hide
        Anthony Borrow added a comment -

        Eric - I have renamed the tracker component to Enrol: Banner-LMB; however, I usually like for it to be the name of the plugin as it makes it easier to find but I will make an exception in this case. The initial Enrol I find important in order to help keep things organized in the tracker so that all the enrollment types, modules, blocks, etc. are grouped together. When folks are searching for the component, I find that helps them quickly find what they are looking for. Is there a reason to re-open the issue or do you think we can resolve it? Peace - Anthony

        Show
        Anthony Borrow added a comment - Eric - I have renamed the tracker component to Enrol: Banner-LMB; however, I usually like for it to be the name of the plugin as it makes it easier to find but I will make an exception in this case. The initial Enrol I find important in order to help keep things organized in the tracker so that all the enrollment types, modules, blocks, etc. are grouped together. When folks are searching for the component, I find that helps them quickly find what they are looking for. Is there a reason to re-open the issue or do you think we can resolve it? Peace - Anthony
        Hide
        Eric Merrill added a comment -

        I knew it would have 'Enrol: ' on the front. While the code for it is LMB, I've been trying to make it Banner/LMB (or something similar) wherever it is actually shown to a person (ie in descriptions), because there have been multiple people who I have talked to who though that their school had to have Luminis Message Broker for it to work, which is not the case, they just need Banner, and LMB adds additional functionality. So thanks for changing that for me.

        I had just reopened the ticket because I wasn't sure if you would see my two additional requests. Resolving it again now.

        Thanks
        -Eric

        Show
        Eric Merrill added a comment - I knew it would have 'Enrol: ' on the front. While the code for it is LMB, I've been trying to make it Banner/LMB (or something similar) wherever it is actually shown to a person (ie in descriptions), because there have been multiple people who I have talked to who though that their school had to have Luminis Message Broker for it to work, which is not the case, they just need Banner, and LMB adds additional functionality. So thanks for changing that for me. I had just reopened the ticket because I wasn't sure if you would see my two additional requests. Resolving it again now. Thanks -Eric
        Hide
        Anthony Borrow added a comment -

        Eric - Yes, even if an issue is resolved, I continue to get further comments on the issue. I do not have strong feelings about whether it is Banner/LMB or Banner-LMB. Would the / work better for you to keep things consistent? I typically use the dash but that is just personal preference so if you have reason for using the slash I can switch it no problem. Peace - Anthony

        Show
        Anthony Borrow added a comment - Eric - Yes, even if an issue is resolved, I continue to get further comments on the issue. I do not have strong feelings about whether it is Banner/LMB or Banner-LMB. Would the / work better for you to keep things consistent? I typically use the dash but that is just personal preference so if you have reason for using the slash I can switch it no problem. Peace - Anthony
        Hide
        Eric Merrill added a comment -

        I use the / generally, but don't really care. Wasn't sure if a project name could have a / in the tracker.

        -eric

        Show
        Eric Merrill added a comment - I use the / generally, but don't really care. Wasn't sure if a project name could have a / in the tracker. -eric
        Hide
        Anthony Borrow added a comment -

        No problem, I went ahead and switched it to the /. Just to explain a little my rationale, my role is to help facilitate and keep things consistent; however, I try as much as possible to give folks as much autonomy over their contributions. So if it is just a matter of taste, then the contributor's desire trumps mine; however, if it is something that may inhibit functionality then I suggest a little stronger. Thanks again for all your contributions to the Moodle community. Peace - Anthony

        Show
        Anthony Borrow added a comment - No problem, I went ahead and switched it to the /. Just to explain a little my rationale, my role is to help facilitate and keep things consistent; however, I try as much as possible to give folks as much autonomy over their contributions. So if it is just a matter of taste, then the contributor's desire trumps mine; however, if it is something that may inhibit functionality then I suggest a little stronger. Thanks again for all your contributions to the Moodle community. Peace - Anthony
        Hide
        Clark Shah-Nelson added a comment -

        Hi all,

        Now I see 0.8.2 and 0.8.3 attached above.

        The "official" LMB Digester page (http://moodle.org/mod/data/view.php?d=13&rid=849&filter=1 ) still has links to the "latest version" etc. to Oakland.edu - and are only version 0.8.0

        Currently, when looking for the latest version I would check the discussion forum, tracker, plugins page, and also email Eric Merrill... It would be fantastic if the latest and greatest official version were in 1 place with all links pointing to that one place - this is part of the reason why I was emphatic about getting it into contrib - so that there's no hunting for the newest version.

        Thanks!
        clark

        Show
        Clark Shah-Nelson added a comment - Hi all, Now I see 0.8.2 and 0.8.3 attached above. The "official" LMB Digester page ( http://moodle.org/mod/data/view.php?d=13&rid=849&filter=1 ) still has links to the "latest version" etc. to Oakland.edu - and are only version 0.8.0 Currently, when looking for the latest version I would check the discussion forum, tracker, plugins page, and also email Eric Merrill... It would be fantastic if the latest and greatest official version were in 1 place with all links pointing to that one place - this is part of the reason why I was emphatic about getting it into contrib - so that there's no hunting for the newest version. Thanks! clark
        Hide
        Eric Merrill added a comment -

        Yeah, currently the contrib CVS contains the newest version (and it always should). I just haven't bundled it all and 'published' it to the various places.

        I usually bundle it periodically, as I feel that the new features and bug fixes warrant.

        -eric

        Show
        Eric Merrill added a comment - Yeah, currently the contrib CVS contains the newest version (and it always should). I just haven't bundled it all and 'published' it to the various places. I usually bundle it periodically, as I feel that the new features and bug fixes warrant. -eric
        Hide
        Anthony Borrow added a comment -

        Eric - Is there any reason why you just don't use Moodle's download server which will "bundle" automatically?

        Then it would just be a matter of updating the M&P entry to:

        http://download.moodle.org/download.php/plugins19/enrol/lmb.zip (for 1.9 branch)

        and

        http://download.moodle.org/download.php/plugins/enrol/lmb.zip (for HEAD)

        The goal is that you are able to spend your time focused on coding rather than bundling or packaging. The zip files will be auto-updated every 24 hours if you make changes to CVS.

        If you do update the M&P entry let me know so that I can get that re-approved promptly. Let me know if you have any questions.

        Peace - Anthony

        Show
        Anthony Borrow added a comment - Eric - Is there any reason why you just don't use Moodle's download server which will "bundle" automatically? Then it would just be a matter of updating the M&P entry to: http://download.moodle.org/download.php/plugins19/enrol/lmb.zip (for 1.9 branch) and http://download.moodle.org/download.php/plugins/enrol/lmb.zip (for HEAD) The goal is that you are able to spend your time focused on coding rather than bundling or packaging. The zip files will be auto-updated every 24 hours if you make changes to CVS. If you do update the M&P entry let me know so that I can get that re-approved promptly. Let me know if you have any questions. Peace - Anthony
        Hide
        Anthony Borrow added a comment -

        p.s. - Using the Moodle download server will also allow us to keep track of the number of downloads and show up on the http://download.moodle.org/stats.php page.

        Show
        Anthony Borrow added a comment - p.s. - Using the Moodle download server will also allow us to keep track of the number of downloads and show up on the http://download.moodle.org/stats.php page.
        Hide
        Eric Merrill added a comment -

        Part of the problem was that none of the docs explained where the download link would be, particularly if you used branches...

        But yeah, Ill get those updated in a bit.

        -eric

        Show
        Eric Merrill added a comment - Part of the problem was that none of the docs explained where the download link would be, particularly if you used branches... But yeah, Ill get those updated in a bit. -eric
        Hide
        Anthony Borrow added a comment -

        Eric - No worries, I have updated the Docs to help explain it a little more clearly. At one point I thought I had it in there. I try to mention this when I am adding code to CVS but I sometimes forget. Another similar reminder that I give is to encourage developers to begin all CVS commit comments with a Moodle tracker number as it helps with documentation. Sometimes that means creating a tracker issue for one's self but unless the change is a simple typo having documentation as to why the change was needed is helpful. Let me know if you need anything else. Peace - Anthony

        Show
        Anthony Borrow added a comment - Eric - No worries, I have updated the Docs to help explain it a little more clearly. At one point I thought I had it in there. I try to mention this when I am adding code to CVS but I sometimes forget. Another similar reminder that I give is to encourage developers to begin all CVS commit comments with a Moodle tracker number as it helps with documentation. Sometimes that means creating a tracker issue for one's self but unless the change is a simple typo having documentation as to why the change was needed is helpful. Let me know if you need anything else. Peace - Anthony
        Hide
        Clark Shah-Nelson added a comment -

        Hey Eric,

        Just checking - the 0.8.3 version above is the latest and greatest, right? I had also tried the plugins and modules page and it was still linking to oakland.edu and seemed to be an older version.

        Thanks,
        Clark

        Show
        Clark Shah-Nelson added a comment - Hey Eric, Just checking - the 0.8.3 version above is the latest and greatest, right? I had also tried the plugins and modules page and it was still linking to oakland.edu and seemed to be an older version. Thanks, Clark
        Hide
        Anthony Borrow added a comment -

        Clark - The links I give above in the 04/Mar/10 12:16 AM comment are technically the most up to date.

        Eric - What are your thoughts on updating the download link on the M&P entry so that it points to the Moodle download server?

        Peace - Anthony

        Show
        Anthony Borrow added a comment - Clark - The links I give above in the 04/Mar/10 12:16 AM comment are technically the most up to date. Eric - What are your thoughts on updating the download link on the M&P entry so that it points to the Moodle download server? Peace - Anthony
        Hide
        Eric Merrill added a comment -

        I've updated the link in the listing - if you can approve it

        -eric

        Show
        Eric Merrill added a comment - I've updated the link in the listing - if you can approve it -eric
        Hide
        Anthony Borrow added a comment -

        Thanks Eric - I have re-approved the entry. Peace - Anthony

        Show
        Anthony Borrow added a comment - Thanks Eric - I have re-approved the entry. Peace - Anthony
        Hide
        Anthony Borrow added a comment -

        Closing all of my resolved issues. Peace - Anthony

        Show
        Anthony Borrow added a comment - Closing all of my resolved issues. Peace - Anthony

          People

          • Votes:
            17 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development