Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: Block: Quickmail
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE

      Description

      I'm creating issues for the top ten most popular blocks and modules to ensure that they are ready for Moodle 2.0. Hopefully we will be able to divide and conquer. If you are unable to work on this, please feel free to reassign as needed. Do not hesitate to let me know how I can be helpful. Peace - Anthony

        Gliffy Diagrams

          Activity

          Hide
          Anthony Borrow added a comment -

          Wen - Just an FYI that I have added you as a watcher. Peace - Anthony

          Show
          Anthony Borrow added a comment - Wen - Just an FYI that I have added you as a watcher. Peace - Anthony
          Hide
          Anthony Borrow added a comment -

          Mark and others - I have also added Robert Russo (both tracker accounts as I was not sure which one he is using) as a watcher to this issue. Ideally, and I forget all the issues, it would be good to have a union of the various version of the quickmail block(s). I know that Wen had done one for large courses and am not sure if that is incompatible with the normal quickmail block. In any case, having one solid quickmail block for Moodle 2.0 is the goal that everyone can collaborate on. Let me know if I need to referee but you all are good team players so I am sure we can make things happen. Peace - Anthony

          Show
          Anthony Borrow added a comment - Mark and others - I have also added Robert Russo (both tracker accounts as I was not sure which one he is using) as a watcher to this issue. Ideally, and I forget all the issues, it would be good to have a union of the various version of the quickmail block(s). I know that Wen had done one for large courses and am not sure if that is incompatible with the normal quickmail block. In any case, having one solid quickmail block for Moodle 2.0 is the goal that everyone can collaborate on. Let me know if I need to referee but you all are good team players so I am sure we can make things happen. Peace - Anthony
          Hide
          Robert Russo added a comment -

          I would love to join forces with the other quickmails out there.

          Show
          Robert Russo added a comment - I would love to join forces with the other quickmails out there.
          Hide
          Clifford Tham added a comment -

          Not sure what the status of this issue is, but I'd like to consolidate at least the 2 different versions of Quickmail (i.e., Quickmail and Quickmail for Large courses). If no one has taken up the torch on this yet, I'd like to start working on unifying the features in both Quickmail blocks, make this version compatible with both Moodle 2.0 and Moodle 1.9+

          Show
          Clifford Tham added a comment - Not sure what the status of this issue is, but I'd like to consolidate at least the 2 different versions of Quickmail (i.e., Quickmail and Quickmail for Large courses). If no one has taken up the torch on this yet, I'd like to start working on unifying the features in both Quickmail blocks, make this version compatible with both Moodle 2.0 and Moodle 1.9+
          Hide
          Mark Nielsen added a comment -

          Hi Clifford, please feel free to pursue upgrade plans. I haven't made any as of yet.

          Show
          Mark Nielsen added a comment - Hi Clifford, please feel free to pursue upgrade plans. I haven't made any as of yet.
          Hide
          Shaun Meyer added a comment - - edited

          I am interesting in coding towards Quickmail for Moodle 2.0.

          Where is this project at? I would like to avoid re-inventing the wheel.

          Show
          Shaun Meyer added a comment - - edited I am interesting in coding towards Quickmail for Moodle 2.0. Where is this project at? I would like to avoid re-inventing the wheel.
          Hide
          Mark Nielsen added a comment -

          No plans have been made and no work that I know of.

          Show
          Mark Nielsen added a comment - No plans have been made and no work that I know of.
          Hide
          Jason Fehr added a comment -

          This was next on my list of things to do and it would be nice to work with someone else. Feel free to email me and we can come up with a plan of attack.

          Show
          Jason Fehr added a comment - This was next on my list of things to do and it would be nice to work with someone else. Feel free to email me and we can come up with a plan of attack.
          Hide
          Clifford Tham added a comment - - edited

          Actually, I have started working on it (albeit slowly). Gimme another 2 weeks or so and I'll commit what I have so far. Looking at the Quickmail code, it just seemed like this would be a good opportunity to refactor it, so it's taking a little longer than anticipated.

          Show
          Clifford Tham added a comment - - edited Actually, I have started working on it (albeit slowly). Gimme another 2 weeks or so and I'll commit what I have so far. Looking at the Quickmail code, it just seemed like this would be a good opportunity to refactor it, so it's taking a little longer than anticipated.
          Hide
          Charles Fulton added a comment -

          I should probably chime in that I've done a 2.0 rewrite of the standard quickmail (i.e. not quickmail for large courses) but I haven't finished testing. I suppose I should just throw it out there .

          Show
          Charles Fulton added a comment - I should probably chime in that I've done a 2.0 rewrite of the standard quickmail (i.e. not quickmail for large courses) but I haven't finished testing. I suppose I should just throw it out there .
          Hide
          Shaun Meyer added a comment -

          It seems like we have about 150% of a QuickMail 2.0 version, that's great.

          Where is the community Quickmail source repository? I'm a little confused about the status of CVS contrib now that Moodle is focusing on git development. Any place to upload + compare these versions would be useful.

          Show
          Shaun Meyer added a comment - It seems like we have about 150% of a QuickMail 2.0 version, that's great. Where is the community Quickmail source repository? I'm a little confused about the status of CVS contrib now that Moodle is focusing on git development. Any place to upload + compare these versions would be useful.
          Hide
          Michael Spall added a comment -

          I would echo the sentiment of everyone releasing their code regardless of polish. Looking at the direction of Moodle, I would recommend github if you don't already have a location. The next step could be to organize a code sprint to get all the good ideas rolled into one and polish off the bugs. One more thing that might help. Since it is easier to write code than to read code , include comments and explanations of your code so that we can follow the decisions that you made.

          Show
          Michael Spall added a comment - I would echo the sentiment of everyone releasing their code regardless of polish. Looking at the direction of Moodle, I would recommend github if you don't already have a location. The next step could be to organize a code sprint to get all the good ideas rolled into one and polish off the bugs. One more thing that might help. Since it is easier to write code than to read code , include comments and explanations of your code so that we can follow the decisions that you made.
          Hide
          Shaun Meyer added a comment -

          I have created https://github.com/meyersh/moodle-block_quickmail and I would be happy to pull in everyone's changes, add contributors, etc as part of any "code sprint".

          I'm new to the git scene and willing to be flexible if this isn't optimal.

          Show
          Shaun Meyer added a comment - I have created https://github.com/meyersh/moodle-block_quickmail and I would be happy to pull in everyone's changes, add contributors, etc as part of any "code sprint". I'm new to the git scene and willing to be flexible if this isn't optimal.
          Hide
          Charles Fulton added a comment -

          I've uploaded my development code here: https://github.com/mackensen/moodle/tree/quickmail/blocks/quickmail. I haven't tested this in a production environment but I think it's basically feature-complete.

          Show
          Charles Fulton added a comment - I've uploaded my development code here: https://github.com/mackensen/moodle/tree/quickmail/blocks/quickmail . I haven't tested this in a production environment but I think it's basically feature-complete.
          Hide
          Jason Fehr added a comment -

          Thanks Charles. I'm downloading it now for testing,

          Show
          Jason Fehr added a comment - Thanks Charles. I'm downloading it now for testing,
          Hide
          Shaun Meyer added a comment -

          Thanks, Charles. I've only taken a brief look at it but have already merged these changes into the repo I've previously published.

          Show
          Shaun Meyer added a comment - Thanks, Charles. I've only taken a brief look at it but have already merged these changes into the repo I've previously published.
          Hide
          Philip Cali added a comment -

          Hi,

          We recently ported our 1.9 Quickmail block we use here at LSU (which is a modified Quickmail) to 2.0.

          The new features:

          • Drafts area
          • Multiple attachments (makes use of the Files API)
          • User email signatures
          • Role filters (say I only want to send to my TA's)

          2.0 improvements:

          • Complete refactoring of the ui (using mforms, and Moodley output printouts)
          • jQuery replaced about 200 lines of nasty javascript
          • Attachments can be retrieved, via the files API in email history!

          Do you want me to make this code available either on github or some other form?

          Show
          Philip Cali added a comment - Hi, We recently ported our 1.9 Quickmail block we use here at LSU (which is a modified Quickmail) to 2.0. The new features: Drafts area Multiple attachments (makes use of the Files API) User email signatures Role filters (say I only want to send to my TA's) 2.0 improvements: Complete refactoring of the ui (using mforms, and Moodley output printouts) jQuery replaced about 200 lines of nasty javascript Attachments can be retrieved, via the files API in email history! Do you want me to make this code available either on github or some other form?
          Hide
          Shaun Meyer added a comment -

          Philip, those UI changes sound pretty impressive. I, for one, would love to see the plugin. Github seems to be in vogue currently.

          Show
          Shaun Meyer added a comment - Philip, those UI changes sound pretty impressive. I, for one, would love to see the plugin. Github seems to be in vogue currently.
          Hide
          Philip Cali added a comment -

          LSU quickmail 04/18/2011

          Show
          Philip Cali added a comment - LSU quickmail 04/18/2011
          Hide
          Philip Cali added a comment - - edited

          We are waiting for organizational permission to host our software on github. For now, I'll put a zip archive here. I will say that the block hasn't been tested on a production environment, so any feedback is welcomed.

          I'll update the ticket when we get a github account.

          Show
          Philip Cali added a comment - - edited We are waiting for organizational permission to host our software on github. For now, I'll put a zip archive here. I will say that the block hasn't been tested on a production environment, so any feedback is welcomed. I'll update the ticket when we get a github account.
          Hide
          Philip Cali added a comment -

          LSU quickmail 04/18/2011

          Show
          Philip Cali added a comment - LSU quickmail 04/18/2011
          Hide
          Adub Adub added a comment -

          First off, I'd like to say thank you Philip for the updated module! I really appreciate it.

          Now, I have a question about the mailing process. It appears that I can only email someone if I have a group created in a course.

          In short, no groups = no email.

          Is there a reason/fix for this? Like why can't I just email all students enrolled in the course by default?

          Show
          Adub Adub added a comment - First off, I'd like to say thank you Philip for the updated module! I really appreciate it. Now, I have a question about the mailing process. It appears that I can only email someone if I have a group created in a course. In short, no groups = no email. Is there a reason/fix for this? Like why can't I just email all students enrolled in the course by default?
          Hide
          Philip Cali added a comment -

          LSU quickmail 04/29/2011

          Good catch... Fixed that bug.

          Added admin settings and other config options.

          Also... icons!

          Show
          Philip Cali added a comment - LSU quickmail 04/29/2011 Good catch... Fixed that bug. Added admin settings and other config options. Also... icons!
          Hide
          Jason Fehr added a comment -

          I found another bug. When I installed quickmail I got an error stating that /lib/jquery.js was missing. I added jquery to my Moodle lib directory in core but I don't believe this is the proper approach. The block should be self sufficient and reference jquery within its own sub-structure.

          I realize that this means that Moodle installations could have multiple versions of jquery lying around but it wouldn't bring up the error I saw, nor would it create versioning issues if two separate blocks used differing versions of jquery.

          Show
          Jason Fehr added a comment - I found another bug. When I installed quickmail I got an error stating that /lib/jquery.js was missing. I added jquery to my Moodle lib directory in core but I don't believe this is the proper approach. The block should be self sufficient and reference jquery within its own sub-structure. I realize that this means that Moodle installations could have multiple versions of jquery lying around but it wouldn't bring up the error I saw, nor would it create versioning issues if two separate blocks used differing versions of jquery.
          Hide
          Stephen Porter added a comment -

          We just added the quickmail block in our test environment that we have migrated from 1.9 to 2.02+ and now wherever the quickmail block is enabled and used, we get this error on the course page:
          Error reading from database
          When we hide the quickmail feature, the course is available again.
          We would like to have the quickmail feature in our production environment.
          Any thoughts on fixing this issue?

          Show
          Stephen Porter added a comment - We just added the quickmail block in our test environment that we have migrated from 1.9 to 2.02+ and now wherever the quickmail block is enabled and used, we get this error on the course page: Error reading from database When we hide the quickmail feature, the course is available again. We would like to have the quickmail feature in our production environment. Any thoughts on fixing this issue?
          Hide
          Philip Cali added a comment -

          Latest build: 05/17/2011

          This should fix the aforementioned issues.

          Show
          Philip Cali added a comment - Latest build: 05/17/2011 This should fix the aforementioned issues.
          Hide
          Tobias Bäumlin added a comment -

          I get the exactly same behavior even with the latest release

          Show
          Tobias Bäumlin added a comment - I get the exactly same behavior even with the latest release
          Hide
          Philip Cali added a comment -

          Wow, I just realized I uploaded the same version...

          I was scratching my head over here because the one I am playing with in my dev instance is working great. Hooray for uploaded files

          I'm going to bump in a couple of minutes.

          Show
          Philip Cali added a comment - Wow, I just realized I uploaded the same version... I was scratching my head over here because the one I am playing with in my dev instance is working great. Hooray for uploaded files I'm going to bump in a couple of minutes.
          Hide
          Philip Cali added a comment -

          Sorry for the inconvenience... This one is the latest.

          Show
          Philip Cali added a comment - Sorry for the inconvenience... This one is the latest.
          Hide
          Stephen Beaudry added a comment - - edited

          Hey guys,

          Adding a few comments, as someone coming into this discussion somewhat cold. Hoping I can save someone else a little digging.

          1) I had to read through every comment from top to bottom twice, to figure out that there are two completely different codebases being discussed here. One that is available for download from the attachements to this tracker issue, and another from the github location https://github.com/meyersh/moodle-block_quickmail

          2) I initially tried the version from the attachment to this discussion, but never got past the 'checkplugins' part of the upgrade process... simply hangs at a white screen. This was tried against both '2.0.1' and '2.0.3+' versions.

          3) I had better success installing the version from github.

          • Simply unzipped the download from there
          • Moved the resulting folder to my dirroot/blocks directory
          • renamed the folder to 'quickmail'
          • did the update in the moodle interface.

          4) In testing this version, 3 errors were noted:
          a) When viewing the quickmail history tab, there are two missing langage definitions (for column headings):

          • block_quickmail|action
          • block_quickmail|attachment
            FIX: (for english only) Add the following lines to dirroot/blocks/quickmail/lang/en/block_quickmail.php:
            $string['action'] = 'Action';
            $string['attachment'] = 'Attachment';

          b) When trying to send a message to the users, the message must include at least one carriage return, otherwise the verification for the HTML editor fails. My Guess is that this is actually an error in the mform->htmleditor, and that it might affect other items as well, but it certainly impacts here, because the rule to verify the input is being called. To replicate, try sending a quickmail with only a single sentance. You'll see an error appear about 'field cannot be empty' when submitting.
          Bandaid FIX: comment out the 'addRule' line in dirroot/blocks/quickmail/email_form.php at line 41, so it doesn't require input in the htmleditor. Otherwise, tell the users that it's a feature to prevent short messages that would be rejected as spam.

          Cheers,

          ...Steve...

          Show
          Stephen Beaudry added a comment - - edited Hey guys, Adding a few comments, as someone coming into this discussion somewhat cold. Hoping I can save someone else a little digging. 1) I had to read through every comment from top to bottom twice, to figure out that there are two completely different codebases being discussed here. One that is available for download from the attachements to this tracker issue, and another from the github location https://github.com/meyersh/moodle-block_quickmail 2) I initially tried the version from the attachment to this discussion, but never got past the 'checkplugins' part of the upgrade process... simply hangs at a white screen. This was tried against both '2.0.1' and '2.0.3+' versions. 3) I had better success installing the version from github. Simply unzipped the download from there Moved the resulting folder to my dirroot/blocks directory renamed the folder to 'quickmail' did the update in the moodle interface. 4) In testing this version, 3 errors were noted: a) When viewing the quickmail history tab, there are two missing langage definitions (for column headings): block_quickmail|action block_quickmail|attachment FIX: (for english only) Add the following lines to dirroot/blocks/quickmail/lang/en/block_quickmail.php: $string ['action'] = 'Action'; $string ['attachment'] = 'Attachment'; b) When trying to send a message to the users, the message must include at least one carriage return, otherwise the verification for the HTML editor fails. My Guess is that this is actually an error in the mform->htmleditor, and that it might affect other items as well, but it certainly impacts here, because the rule to verify the input is being called. To replicate, try sending a quickmail with only a single sentance. You'll see an error appear about 'field cannot be empty' when submitting. Bandaid FIX: comment out the 'addRule' line in dirroot/blocks/quickmail/email_form.php at line 41, so it doesn't require input in the htmleditor. Otherwise, tell the users that it's a feature to prevent short messages that would be rejected as spam. Cheers, ...Steve...
          Hide
          Edwinna Lucyk added a comment -

          I am commenting here because I cannot seem to find an answer in the Quickmail forum.
          I very much want to upgrade to MOODLE 2.0 before the new school year but the teachers in my 6-12 school rely heavily on Quickmail. Is there a target date for when Quickmail will be compatible with 2.0?
          Edwinna

          Show
          Edwinna Lucyk added a comment - I am commenting here because I cannot seem to find an answer in the Quickmail forum. I very much want to upgrade to MOODLE 2.0 before the new school year but the teachers in my 6-12 school rely heavily on Quickmail. Is there a target date for when Quickmail will be compatible with 2.0? Edwinna
          Hide
          Kimber Warden added a comment -

          I downloaded the 5/23/11 version and installed it on Moodle 2.0.2. After I compose an e-mail and click "Send Email," I get this error: Error 503 Service Unavailable
          Service Unavailable

          Guru Meditation:
          XID: 1985515318

          Is there a fix?

          Show
          Kimber Warden added a comment - I downloaded the 5/23/11 version and installed it on Moodle 2.0.2. After I compose an e-mail and click "Send Email," I get this error: Error 503 Service Unavailable Service Unavailable Guru Meditation: XID: 1985515318 Is there a fix?
          Hide
          Andreas Grupp added a comment -

          I just installed the 05_23_2011 version on Moodle 2.1.1+ (Build: 20110826). Everything worked great! As I translated the language file to German you can find it under attachments. Andreas

          Show
          Andreas Grupp added a comment - I just installed the 05_23_2011 version on Moodle 2.1.1+ (Build: 20110826). Everything worked great! As I translated the language file to German you can find it under attachments. Andreas
          Hide
          Gerardo A. Mendoza added a comment -

          I just installed 05-23-2011 version on Moodle 2.0.4. I can send mails from teacher to students and student to teacher, but when I review the history I can't see the emails received, just sent. I review the settings and it's ok. Any idea about the problem? I've read that I can see both emails, sent and received.

          Show
          Gerardo A. Mendoza added a comment - I just installed 05-23-2011 version on Moodle 2.0.4. I can send mails from teacher to students and student to teacher, but when I review the history I can't see the emails received, just sent. I review the settings and it's ok. Any idea about the problem? I've read that I can see both emails, sent and received.
          Hide
          Julien THOMAS added a comment -

          Hi, I'm actually searching a way to use Quickmail with Moodle 2.1.
          I downloaded the github version and installed it but i've always the same error message when I want to compose a new mail.
          "There are no users you are capable of emailing". Nevertheless, there are always more than ten students in the courses I add the block.
          Is there a solution to this ?

          Thanks.

          Julien

          Show
          Julien THOMAS added a comment - Hi, I'm actually searching a way to use Quickmail with Moodle 2.1. I downloaded the github version and installed it but i've always the same error message when I want to compose a new mail. "There are no users you are capable of emailing". Nevertheless, there are always more than ten students in the courses I add the block. Is there a solution to this ? Thanks. Julien
          Hide
          Amanda Doughty added a comment -

          I have come across a strange bug which I am unable to replicate on all of our Moodle instances. The problem application uses:

          Moodle version 2011070101.08
          Quickmail version 2011021812

          MySQL database on Redhat OS

          Error message when saving an admin setting (/admin/settings.php?section=debugging):

          ( ! ) Fatal error: Call to undefined method admin_settingpage::get_records() in /moodle/trunk/search/lib.php on line 42
          Call Stack

          1. Time Memory Function Location
            1 0.0005 715112 {main}

            ( ) ../settings.php:0
            2 0.9124 69341360 admin_write_settings( ) ../settings.php:38
            3 0.9296 69447216 admin_get_root( ) ../adminlib.php:6004
            4 1.0665 68807512 require( '/moodle/trunk/admin/settings/plugins.php' ) ../adminlib.php:5905
            5 1.1697 69251888 include( '/moodle/trunk/blocks/search/settings.php' ) ../plugins.php:42
            6 1.1713 69266904 search_collect_searchables( ) ../settings.php:80

          The error was caused because the global variable $DB referenced the wrong type of object. This was due to the following code in blocks/quickmail/settings.php:

          $defaults = array_map(function ($sn) use ($DB)

          { return $DB->get_field('role', 'id', array('shortname' => $sn)); }

          , array('editingteacher', 'teacher', 'student'));

          Using $DB in parent scope rather than global scope caused the problem. It is fixed by changing this code to:

          $defaults = array_map(function ($sn)

          { global $DB; return $DB->get_field('role', 'id', array('shortname' => $sn)); }

          I would love to understand how $DB comes to reference an admin_settingspage object? I would also like to understand why I don't get the same error in my local version on Ubuntu. I suspect it is linked to persistence of database connections? If anyone can throw any light on this then my 5 day headache would be over.

          Show
          Amanda Doughty added a comment - I have come across a strange bug which I am unable to replicate on all of our Moodle instances. The problem application uses: Moodle version 2011070101.08 Quickmail version 2011021812 MySQL database on Redhat OS Error message when saving an admin setting (/admin/settings.php?section=debugging): ( ! ) Fatal error: Call to undefined method admin_settingpage::get_records() in /moodle/trunk/search/lib.php on line 42 Call Stack Time Memory Function Location 1 0.0005 715112 {main} ( ) ../settings.php:0 2 0.9124 69341360 admin_write_settings( ) ../settings.php:38 3 0.9296 69447216 admin_get_root( ) ../adminlib.php:6004 4 1.0665 68807512 require( '/moodle/trunk/admin/settings/plugins.php' ) ../adminlib.php:5905 5 1.1697 69251888 include( '/moodle/trunk/blocks/search/settings.php' ) ../plugins.php:42 6 1.1713 69266904 search_collect_searchables( ) ../settings.php:80 The error was caused because the global variable $DB referenced the wrong type of object. This was due to the following code in blocks/quickmail/settings.php: $defaults = array_map(function ($sn) use ($DB) { return $DB->get_field('role', 'id', array('shortname' => $sn)); } , array('editingteacher', 'teacher', 'student')); Using $DB in parent scope rather than global scope caused the problem. It is fixed by changing this code to: $defaults = array_map(function ($sn) { global $DB; return $DB->get_field('role', 'id', array('shortname' => $sn)); } I would love to understand how $DB comes to reference an admin_settingspage object? I would also like to understand why I don't get the same error in my local version on Ubuntu. I suspect it is linked to persistence of database connections? If anyone can throw any light on this then my 5 day headache would be over.
          Hide
          Mark Nielsen added a comment -

          Hey All,

          Thanks for all of the great work on this. I did a code review of the project and added 2 more configs (off by default). You can see the pull request here: https://github.com/meyersh/moodle-block_quickmail/pull/1

          Cheers,
          Mark

          Show
          Mark Nielsen added a comment - Hey All, Thanks for all of the great work on this. I did a code review of the project and added 2 more configs (off by default). You can see the pull request here: https://github.com/meyersh/moodle-block_quickmail/pull/1 Cheers, Mark
          Hide
          Shaun Meyer added a comment -

          I've integrated Mark's request into the github repo (https://github.com/meyersh/moodle-block_quickmail) and will start testing soon.

          Show
          Shaun Meyer added a comment - I've integrated Mark's request into the github repo ( https://github.com/meyersh/moodle-block_quickmail ) and will start testing soon.
          Hide
          Anthony Borrow added a comment -

          Just an update here that the quickmail block is looking for a maintainer. I am grateful to Mark Nielsen for his many contributions and help with maintaining the block. I'm not sure if LSU might be willing to take over leadership or if someone else might be interested. Let me know of any interest so that we can get things straightened out here in the tracker, in the older Modules and Plugins database and the new Moodle Plugins (http://moodle.org/plugins) system. If a maintainer does not emerge here in the tracker, we may want to post something in the forums let them know about this opportunity. Peace - Anthony

          Show
          Anthony Borrow added a comment - Just an update here that the quickmail block is looking for a maintainer. I am grateful to Mark Nielsen for his many contributions and help with maintaining the block. I'm not sure if LSU might be willing to take over leadership or if someone else might be interested. Let me know of any interest so that we can get things straightened out here in the tracker, in the older Modules and Plugins database and the new Moodle Plugins ( http://moodle.org/plugins ) system. If a maintainer does not emerge here in the tracker, we may want to post something in the forums let them know about this opportunity. Peace - Anthony
          Hide
          Shaun Meyer added a comment -

          Still learning git, I have created a branch for LSU-Patches on the github repo in which I've added two commits reflecting Phillip's Apr-23 and May-5 quickmail attachments.

          If I find the time and ambition this coming week, I will give them a more thorough read to see how far the two plugins have diverged.

          The more eyes that can look at this, the better.

          Phillip, what is the state of your request for permission to host this code? Let me know if/when that goes through and I'd be happy to grant you/your group committer rights to my github.

          Show
          Shaun Meyer added a comment - Still learning git, I have created a branch for LSU-Patches on the github repo in which I've added two commits reflecting Phillip's Apr-23 and May-5 quickmail attachments. If I find the time and ambition this coming week, I will give them a more thorough read to see how far the two plugins have diverged. The more eyes that can look at this, the better. Phillip, what is the state of your request for permission to host this code? Let me know if/when that goes through and I'd be happy to grant you/your group committer rights to my github.
          Hide
          Michelle Ervin added a comment -

          I don't know much about the coding and such, but I just tried to install the 5/23 file and got this error:
          "Parse error: syntax error, unexpected T_FUNCTION in /home/ellteac1/public_html/moodle/blocks/quickmail/lib.php on line 65"

          Any ideas what this means? Can I fix it on my end?
          Thank you!

          Show
          Michelle Ervin added a comment - I don't know much about the coding and such, but I just tried to install the 5/23 file and got this error: "Parse error: syntax error, unexpected T_FUNCTION in /home/ellteac1/public_html/moodle/blocks/quickmail/lib.php on line 65" Any ideas what this means? Can I fix it on my end? Thank you!
          Hide
          Longfei Yu added a comment -

          Thanks for this nice plugin!

          But I have a small bug. If I click the "Compose new Email", then go to the Email page, if I do not select anyone, but click the "Cancel" button, nothing will happen. The "Cancel" button only works (redirect to the course page) only if I pick some Recipients. Thanks.

          Show
          Longfei Yu added a comment - Thanks for this nice plugin! But I have a small bug. If I click the "Compose new Email", then go to the Email page, if I do not select anyone, but click the "Cancel" button, nothing will happen. The "Cancel" button only works (redirect to the course page) only if I pick some Recipients. Thanks.
          Hide
          Caroline Moore added a comment -

          I just tested the version of Quickmail in the new Moodle Plugins system on Moodle 2.2, and I found a pretty significant bug. I've posted a separate tracker item for it here: http://tracker.moodle.org/browse/CONTRIB-3341

          Show
          Caroline Moore added a comment - I just tested the version of Quickmail in the new Moodle Plugins system on Moodle 2.2, and I found a pretty significant bug. I've posted a separate tracker item for it here: http://tracker.moodle.org/browse/CONTRIB-3341
          Hide
          Walter Horowitz added a comment -

          Tried Quickmail on the newly released 2.3 and this is the message, "Coding error detected, it must be fixed by a programmer: Invalid field definition in table

          {block_quickmail_log}

          : XMLDB_TYPE_INTEGER field "alternateid" has invalid default".

          Debug info:
          Error code: codingerror
          Stack trace:
          line 454 of /lib/ddl/sql_generator.php: coding_exception thrown
          line 699 of /lib/ddl/sql_generator.php: call to sql_generator->getFieldSQL()
          line 522 of /lib/ddl/database_manager.php: call to sql_generator->getAddFieldSQL()
          line 52 of /blocks/quickmail/db/upgrade.php: call to database_manager->add_field()
          line 811 of /lib/upgradelib.php: call to xmldb_block_quickmail_upgrade()
          line 360 of /lib/upgradelib.php: call to upgrade_plugins_blocks()
          line 1524 of /lib/upgradelib.php: call to upgrade_plugins()
          line 329 of /admin/index.php: call to upgrade_noncore()

          My database is PostreSQl 9.1.4

          Is there anything I can do to help? I have never worked on PHP code, but I will try if that is what is needed.

          Show
          Walter Horowitz added a comment - Tried Quickmail on the newly released 2.3 and this is the message, "Coding error detected, it must be fixed by a programmer: Invalid field definition in table {block_quickmail_log} : XMLDB_TYPE_INTEGER field "alternateid" has invalid default". Debug info: Error code: codingerror Stack trace: line 454 of /lib/ddl/sql_generator.php: coding_exception thrown line 699 of /lib/ddl/sql_generator.php: call to sql_generator->getFieldSQL() line 522 of /lib/ddl/database_manager.php: call to sql_generator->getAddFieldSQL() line 52 of /blocks/quickmail/db/upgrade.php: call to database_manager->add_field() line 811 of /lib/upgradelib.php: call to xmldb_block_quickmail_upgrade() line 360 of /lib/upgradelib.php: call to upgrade_plugins_blocks() line 1524 of /lib/upgradelib.php: call to upgrade_plugins() line 329 of /admin/index.php: call to upgrade_noncore() My database is PostreSQl 9.1.4 Is there anything I can do to help? I have never worked on PHP code, but I will try if that is what is needed.
          Hide
          Charles Fulton added a comment -

          Walter: that's fixed in the latest releases on github. You can download that from https://github.com/lsuits/quickmail.

          Show
          Charles Fulton added a comment - Walter: that's fixed in the latest releases on github. You can download that from https://github.com/lsuits/quickmail .
          Hide
          Walter Horowitz added a comment -

          Thanks for the suggestion to try github. However, that didn't work for me. This time I got this:
          Table "block_quickmail_drafts" does not exist

          More information about this error

          Debug info:
          Error code: ddltablenotexist
          Stack trace:
          line 144 of /lib/ddl/database_manager.php: ddl_table_missing_exception thrown
          line 53 of /blocks/quickmail/db/upgrade.php: call to database_manager->field_exists()
          line 811 of /lib/upgradelib.php: call to xmldb_block_quickmail_upgrade()
          line 360 of /lib/upgradelib.php: call to upgrade_plugins_blocks()
          line 1524 of /lib/upgradelib.php: call to upgrade_plugins()
          line 329 of /admin/index.php: call to upgrade_noncore()

          Show
          Walter Horowitz added a comment - Thanks for the suggestion to try github. However, that didn't work for me. This time I got this: Table "block_quickmail_drafts" does not exist More information about this error Debug info: Error code: ddltablenotexist Stack trace: line 144 of /lib/ddl/database_manager.php: ddl_table_missing_exception thrown line 53 of /blocks/quickmail/db/upgrade.php: call to database_manager->field_exists() line 811 of /lib/upgradelib.php: call to xmldb_block_quickmail_upgrade() line 360 of /lib/upgradelib.php: call to upgrade_plugins_blocks() line 1524 of /lib/upgradelib.php: call to upgrade_plugins() line 329 of /admin/index.php: call to upgrade_noncore()
          Hide
          Walter Horowitz added a comment -

          I had an idea that perhaps if I included the quickmail block as part of my upgrade, then it would work. However, it does not and I get the "Table "block_quickmail_drafts" does not exist" error with either the current github version or the 2.2 version.

          Show
          Walter Horowitz added a comment - I had an idea that perhaps if I included the quickmail block as part of my upgrade, then it would work. However, it does not and I get the "Table "block_quickmail_drafts" does not exist" error with either the current github version or the 2.2 version.
          Hide
          Walter Horowitz added a comment -

          I found a fix that works for me. I upgraded 1.9 to 2.2 and was told the quickmail block was missing. I then deleted the quickmail block which deletes the database entries for quickmail. I then added back the latest version of quickmail and this worked. Since I can live without the quickmail history from last year, I am now a happy camper.

          Show
          Walter Horowitz added a comment - I found a fix that works for me. I upgraded 1.9 to 2.2 and was told the quickmail block was missing. I then deleted the quickmail block which deletes the database entries for quickmail. I then added back the latest version of quickmail and this worked. Since I can live without the quickmail history from last year, I am now a happy camper.
          Hide
          Anthony Borrow added a comment -

          I'm going to mark this as closed since the 2.x version is available at http://moodle.org/plugins/view.php?plugin=block_quickmail and being maintained by Phillip Cali at LSU. Peace - Anthony

          Show
          Anthony Borrow added a comment - I'm going to mark this as closed since the 2.x version is available at http://moodle.org/plugins/view.php?plugin=block_quickmail and being maintained by Phillip Cali at LSU. Peace - Anthony
          Hide
          Kyriakos Terzopoulos added a comment -

          Does not seem to work on 2.4 version of moodle

          Show
          Kyriakos Terzopoulos added a comment - Does not seem to work on 2.4 version of moodle
          Hide
          Julien Thomas added a comment -

          It works for me with 2.4

          Show
          Julien Thomas added a comment - It works for me with 2.4
          Hide
          Kyriakos Terzopoulos added a comment - - edited

          Nevermind, it was my installation that had the problem

          Show
          Kyriakos Terzopoulos added a comment - - edited Nevermind, it was my installation that had the problem
          Hide
          Janet Smith added a comment -

          I noticed the Quickmail block doesn't have a settings button like most blocks do on the block configuration page. You have to search to find the settings. Is there a specific reason for this or could one be added? I also noticed when I install the latest code in Moodle 2.4, even searching doesn't bring up the settings, I had to find them in the database to modify them.

          Thanks!

          Show
          Janet Smith added a comment - I noticed the Quickmail block doesn't have a settings button like most blocks do on the block configuration page. You have to search to find the settings. Is there a specific reason for this or could one be added? I also noticed when I install the latest code in Moodle 2.4, even searching doesn't bring up the settings, I had to find them in the database to modify them. Thanks!

            Dates

            • Created:
              Updated:
              Resolved:

              Development