Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-2091

SimpleSAML_Configuration::resolvePath() Windows Drive Check

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.9.8
    • Fix Version/s: None
    • Labels:
      None
    • Environment:
      Windows Server 2003, Apache 2.2, PHP 5.2.13, MySQL
    • Database:
      MySQL
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE

      Description

      I've found a bug with SimpleSAML_Configuration::resolvePath() that is also posted on the MoodleRooms site: http://development.moodlerooms.com/mod/forum/discuss.php?d=143

      SimpleSAML_Configuration::resolvePath() checks for Unix root paths but not Windows. Here is the modification I made to fix it.

      File: Moodle/auth/gsaml/samllib/Configuration.php
      Line: 115
      From: if ($path[0] !== '/') $path = $this->getBaseDir() . $path;
      To: if ($path[0] !== '/' && !(ctype_alpha($path[0]) && $path[1] == ':')) $path = $this->getBaseDir() . $path;

      Basically added detection for <Letter>: indicating a Windows drive.

        Attachments

          Activity

            People

            Assignee:
            jrh18 Jason Hardin
            Reporter:
            ryanp Ryan Panning
            Participants:
            Component watchers:
            Jason Hardin
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: