Add-ons
  1. Add-ons
  2. CONTRIB-287

Windows Share Web Client does not work on versions 1.8 and 1.9

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.8.5, 1.9, 1.9.1, 2.0
    • Fix Version/s: 1.7
    • Component/s: Block: smb_web_client
    • Labels:
      None
    • Environment:
      Linux based web server
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_17_STABLE
    • Rank:
      37136

      Description

      The Windows Share Web Client available in Modules and plugins references ../../auth/ldap/lib.php which is no longer distributed with Moodle as of version 1.8.

      This makes the block non-functional in a default installation of Moodle.

      I looked at the code and discovered that all the functions referenced in lib.php are available in auth.php, so I modified the code to use auth.php instead of lib.php.

      Attached is the block, tested and working on both 1.8 and 1.9. I have also modified the block so it only appears if the user is logged into the system.

        Activity

        Hide
        Anthony Borrow added a comment -

        Ted - I'm moving this to the Block: smb_web_client component now that we have created it. Guy Thomas sent me the 1.7 and 1.8 zip files and we have uploaded those to CVS. The 17STABLE branch uses the /auth/ldap/lib.php file and the 18STABLE versions (and beyond) will use the /auth/ldap/auth.php. Thanks for catching this and brining it to our attention. I'm going to resolved this as fixed. Peace - Anthony

        Show
        Anthony Borrow added a comment - Ted - I'm moving this to the Block: smb_web_client component now that we have created it. Guy Thomas sent me the 1.7 and 1.8 zip files and we have uploaded those to CVS. The 17STABLE branch uses the /auth/ldap/lib.php file and the 18STABLE versions (and beyond) will use the /auth/ldap/auth.php. Thanks for catching this and brining it to our attention. I'm going to resolved this as fixed. Peace - Anthony
        Hide
        Anthony Borrow added a comment -

        Guy - I've added you as the QA Assignee and am assigning this to you in case there are any follow up comments from Ted. Peace - Anthony

        Show
        Anthony Borrow added a comment - Guy - I've added you as the QA Assignee and am assigning this to you in case there are any follow up comments from Ted. Peace - Anthony

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development