Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.1, 2.2
    • Fix Version/s: None
    • Component/s: Module: Certificate
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE

      Description

      The code $pdf->SetProtection(array('print')) in certificate.php for the types prevents users from printing (http://moodle.org/mod/forum/discuss.php?d=193292). Either introduce a new setting for the certificate to allow printing or not, or just delete this line altogether. Personally I can not see why you would only want them to view it and not print.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            joseph.jacelone Joseph Jacelone added a comment -

            This security is currently affecting a number of our client's and it would be great to either have this as an editable setting or not have it hard coded into the module at all. Thanks in advance for all your help in getting this issue resolved!

            Show
            joseph.jacelone Joseph Jacelone added a comment - This security is currently affecting a number of our client's and it would be great to either have this as an editable setting or not have it hard coded into the module at all. Thanks in advance for all your help in getting this issue resolved!
            Hide
            mchurch Mike Churchward added a comment -

            Will this be fixed soon? This is a huge issue. I would say that if settings can't be provided, that the code should default to allow printing, rather than the other way around.

            Show
            mchurch Mike Churchward added a comment - Will this be fixed soon? This is a huge issue. I would say that if settings can't be provided, that the code should default to allow printing, rather than the other way around.
            Hide
            joseph.jacelone Joseph Jacelone added a comment - - edited

            Is there a possibility of seeing a change to the certificate module to not default to $pdf->SetProtection(array('print'))? I would think that giving a choice of settings rather then defaulting to a security feature, that does not seem to be the norm for online courses, would be the most logical option.

            Let me know your thought on this Mark, when you get a chance, and thanks ahead of time for all your hard work!

            Show
            joseph.jacelone Joseph Jacelone added a comment - - edited Is there a possibility of seeing a change to the certificate module to not default to $pdf->SetProtection(array('print'))? I would think that giving a choice of settings rather then defaulting to a security feature, that does not seem to be the norm for online courses, would be the most logical option. Let me know your thought on this Mark, when you get a chance, and thanks ahead of time for all your hard work!
            Hide
            moorejon Jonathan Moore added a comment -

            I agree users regularly want to print their certificates and have been able to do so in the past. Please provide an option of default to printing on.

            Show
            moorejon Jonathan Moore added a comment - I agree users regularly want to print their certificates and have been able to do so in the past. Please provide an option of default to printing on.
            Hide
            markn Mark Nelson added a comment -

            Hi Guys,

            I have been away on a surfing holiday and have only just arrived back. I will get onto this when I have free time. I just need to decide whether having an option is really necessary or just deleting the line altogether. There will be a fix pushed out shortly once I have decided to the git repository.

            Regards,

            Mark

            Show
            markn Mark Nelson added a comment - Hi Guys, I have been away on a surfing holiday and have only just arrived back. I will get onto this when I have free time. I just need to decide whether having an option is really necessary or just deleting the line altogether. There will be a fix pushed out shortly once I have decided to the git repository. Regards, Mark
            Hide
            joseph.jacelone Joseph Jacelone added a comment -

            Hey Mark,

            Hope your Surfing holiday was fun and shark free! Thanks for your help with this and for all the hard work!

            Sincerely,

            Joe

            Show
            joseph.jacelone Joseph Jacelone added a comment - Hey Mark, Hope your Surfing holiday was fun and shark free! Thanks for your help with this and for all the hard work! Sincerely, Joe
            Hide
            ralph_sampson@hotmail.com Matt Harris added a comment -

            Thank you Mark!!

            Show
            ralph_sampson@hotmail.com Matt Harris added a comment - Thank you Mark!!
            Hide
            markn Mark Nelson added a comment -

            Hi Guys,

            I have pushed a temporary fix for now. I am currently in the process of re-writing the certificate types, so that is is similar to the assignment type system. However, I keep making changes and am not confident with pushing the large change to the repository just yet.

            Regards,

            Mark

            Show
            markn Mark Nelson added a comment - Hi Guys, I have pushed a temporary fix for now. I am currently in the process of re-writing the certificate types, so that is is similar to the assignment type system. However, I keep making changes and am not confident with pushing the large change to the repository just yet. Regards, Mark
            Hide
            joseph.jacelone Joseph Jacelone added a comment -

            Hey Mark,

            Thank you for the update and the temp fix! I look forward to the new additions to certificate. Thank you again for developing such a helpful module!

            Sincerely,

            Joe

            Show
            joseph.jacelone Joseph Jacelone added a comment - Hey Mark, Thank you for the update and the temp fix! I look forward to the new additions to certificate. Thank you again for developing such a helpful module! Sincerely, Joe
            Hide
            tsala Helen Foster added a comment -

            Closing this resolved issue, as requested by issue assignee Mark.

            Show
            tsala Helen Foster added a comment - Closing this resolved issue, as requested by issue assignee Mark.

              People

              • Votes:
                24 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: