Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.11
    • Fix Version/s: None
    • Component/s: Module: HotPot
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE

      Description

      (Apologies as I know very little about hotpot..)

      Quizes with countdowns in them which seemed to work 1.7 no longer work in 1.8. Apologies I can't give much more details (can proably email the hotpot quiz if you'd like to try it)

        Gliffy Diagrams

          Activity

          Hide
          xxxxxxx Gordon Bateson added a comment -

          I think you are talking about the timer?

          Please could you send the quiz you are having trouble with to:
          gordon at-sign kanazawa hyphen gu dot ac dot jp

          thanks

          Show
          xxxxxxx Gordon Bateson added a comment - I think you are talking about the timer? Please could you send the quiz you are having trouble with to: gordon at-sign kanazawa hyphen gu dot ac dot jp thanks
          Hide
          xxxxxxx Gordon Bateson added a comment -

          I tried a simple JCloze with a timer and it ran fine in Moodle 1.8. It ran it from the ".jcl" file and from the ".htm" file and both times there quiz performed as expected.

          I will wait to receive your quiz so I can investigate further.

          Show
          xxxxxxx Gordon Bateson added a comment - I tried a simple JCloze with a timer and it ran fine in Moodle 1.8. It ran it from the ".jcl" file and from the ".htm" file and both times there quiz performed as expected. I will wait to receive your quiz so I can investigate further.
          Hide
          poltawski Dan Poltawski added a comment -

          Apologies for the delay, i've now sent you a mail.

          Show
          poltawski Dan Poltawski added a comment - Apologies for the delay, i've now sent you a mail.
          Hide
          xxxxxxx Gordon Bateson added a comment -

          Thanks for sending the quizzes. T

          The HotPot module is designed to work with quizzes produced with Hot Potatoes 6, but JBC is a Hot Potatoes 5 program, so it probably won't work at the moment. The next version of the HotPot module may well be able to handle HP5 quizzes.

          The JMatch quiz, did not have the timer switched on (Options -> Configure Output -> Timer, then check the box which says "Set a time limit for this exercise"). With the timer switched, the quiz can be run from the ".jcl" file or from the ".htm" file.

          The timer was a bit a red herring then I think

          However, there is an error which needs looking into:
          A required parameter (attemptid) was missing

          I will investigate that and report back.

          Show
          xxxxxxx Gordon Bateson added a comment - Thanks for sending the quizzes. T The HotPot module is designed to work with quizzes produced with Hot Potatoes 6, but JBC is a Hot Potatoes 5 program, so it probably won't work at the moment. The next version of the HotPot module may well be able to handle HP5 quizzes. The JMatch quiz, did not have the timer switched on (Options -> Configure Output -> Timer, then check the box which says "Set a time limit for this exercise"). With the timer switched, the quiz can be run from the ".jcl" file or from the ".htm" file. The timer was a bit a red herring then I think However, there is an error which needs looking into: A required parameter (attemptid) was missing I will investigate that and report back.
          Hide
          xxxxxxx Gordon Bateson added a comment -

          In "mod/hotpot/lib.php" in the "insert_form" function,

          target="'.$CFG->framename.'"

          had been replaced by

          '.$CFG->frametarget.'"

          which produces an invalid <FORM> tag and causes the "required parameter is missing" error. It seems the $CFG->frametarget property is never set.

          I reset the code to what it was in Moodle 1.7 and earlier and the error no longer appeared. I updated MOODLE_18_STABLE in CVS, and will merge the change into the main trunk tomorrow.

          In conclusion, there was no problem with the timer, but there was a problem with the the results of ALL HotPot quizzes not getting stored. I consider this problem fixed now, but if you have any further difficulties please feel free to comment some more.

          many thanks for your report
          Gordon

          Show
          xxxxxxx Gordon Bateson added a comment - In "mod/hotpot/lib.php" in the "insert_form" function, target="'.$CFG->framename.'" had been replaced by '.$CFG->frametarget.'" which produces an invalid <FORM> tag and causes the "required parameter is missing" error. It seems the $CFG->frametarget property is never set. I reset the code to what it was in Moodle 1.7 and earlier and the error no longer appeared. I updated MOODLE_18_STABLE in CVS, and will merge the change into the main trunk tomorrow. In conclusion, there was no problem with the timer, but there was a problem with the the results of ALL HotPot quizzes not getting stored. I consider this problem fixed now, but if you have any further difficulties please feel free to comment some more. many thanks for your report Gordon
          Hide
          xxxxxxx Gordon Bateson added a comment -

          I found this is the CVS change log for the "lib/hotpot" folder:

          2007-01-05 Friday 02:23 skodak

          • index.php, lib.php, view.php:

          MDL-8050 1.2 Remove all target="_top" - refactoring of previous
          commit

          MDL-8050 says:
          When the $CFG->framename is _top or blank, then don't print target="_top" in links
          and later:
          search&replace <a href="xxx" $CFG->frametarget>

          So it looks like I should leave the "$CFG->frametarget", but remove the trailing double-quote which was making the <FORM> tag invalid.

          Show
          xxxxxxx Gordon Bateson added a comment - I found this is the CVS change log for the "lib/hotpot" folder: 2007-01-05 Friday 02:23 skodak index.php, lib.php, view.php: MDL-8050 1.2 Remove all target="_top" - refactoring of previous commit MDL-8050 says: When the $CFG->framename is _top or blank, then don't print target="_top" in links and later: search&replace <a href="xxx" $CFG->frametarget> So it looks like I should leave the "$CFG->frametarget", but remove the trailing double-quote which was making the <FORM> tag invalid.
          Hide
          xxxxxxx Gordon Bateson added a comment -

          Having committed the MOODLE_18_STABLE changes, I have merged the differences between MOODLE_18_STABLE and MOODLE_18_MERGED into HEAD and updated the MOODLE_18_MERGED tag, so I will now close this issue

          Show
          xxxxxxx Gordon Bateson added a comment - Having committed the MOODLE_18_STABLE changes, I have merged the differences between MOODLE_18_STABLE and MOODLE_18_MERGED into HEAD and updated the MOODLE_18_MERGED tag, so I will now close this issue
          Hide
          xxxxxxx Gordon Bateson added a comment -

          changes addded into 18 and HEAD

          Show
          xxxxxxx Gordon Bateson added a comment - changes addded into 18 and HEAD

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development