Add-ons
  1. Add-ons
  2. CONTRIB-346

Some Bugs in original quickmail block with GROUPS

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.9, 1.9.1, 1.9.2, 1.9.3, 1.9.4
    • Fix Version/s: None
    • Component/s: Block: Quickmail
    • Labels:
      None
    • Environment:
      Moodle 1.9, PHP 5.2.5, MySQL 5.0.4.0
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_19_STABLE
    • Rank:
      21234

      Description

      First, this module is a block not a module! Second, i mean the block quickmail and not quickmail for large class. Three bugs:

      1. A bug that the coursename is not showing in the breadcrumb. If a user (in this case a admin or teacher) use this block inside a course, the breadcrumb shows frontpagecourse->quickmail. In the cvs is a fileversion who solved this problem, why you dont take this file to the plugin page, because this bug is in moodle 1.8 too?

      2. In moodle 1.9 did not work the group function. In the course settings i choose groups, in the block quickmail i choose groups like the settings in the course settings. This will not work.

      3. Next case, in moodle 1.9 did not work the group function. In the course settings i choose groups, in the block quickmail i choose groups like the settings in the course settings, but this time i say in the groups settings "Force". If i go now to the block quickmail and say send a mail, it shows me a blank_page and the debug mode shows me no error warnings.

      My question is now, arround the world the user take this block and have the same problems under moodle 1.9, can anyone fix this bugs and problems?

      Andy

        Issue Links

          Activity

          Hide
          Kenneth Newquist added a comment -

          The reason for the white page is that PHP is throwing a fatal error:

          PHP Fatal error: Call to undefined function groups_get_groups() in/[path to moodle]/blocks/quickmail/email.php on line 231, referer: http://mymoodle.edu/course/view.php?id=1561

          I know a bunch of stuff changed with group/groupings code from Moodle 1.8 to 1.9, so no doubt that's the problem here, but I don't know how to fix it.

          Show
          Kenneth Newquist added a comment - The reason for the white page is that PHP is throwing a fatal error: PHP Fatal error: Call to undefined function groups_get_groups() in/ [path to moodle] /blocks/quickmail/email.php on line 231, referer: http://mymoodle.edu/course/view.php?id=1561 I know a bunch of stuff changed with group/groupings code from Moodle 1.8 to 1.9, so no doubt that's the problem here, but I don't know how to fix it.
          Hide
          Kenneth Newquist added a comment -

          Quickmail is relying on old group functions from 1.8 that have been replaced with new public group functions in 1.9. The new functions live in /lib/grouplib.php, and Quickmail needs to be updated to use these functions instead.

          The big difference between these and the 1.8 versions is that they return an array of group objects, rather than just a simple array of group ids. The quickmail code is expecting the later, so I whipped up a patch that uses the new functions, then uses array_values to strip out the group ids and throw them into the $groups array.

          I'm not sure what the Moodle 1.9 way of fetching group ids from group objects is; I'd appreciate it if someone could post the recommended way of getting this information.

          This patch will break the 1.8 version of quickmail, so a production version would likely need some logic to figure out what version it was working under (or need to be explicitly labeled as being for 1.9).

          Using this patch I was able to:

          1) Eliminate the white screen.
          2) Get groups working again with separate and visible groups.

          Show
          Kenneth Newquist added a comment - Quickmail is relying on old group functions from 1.8 that have been replaced with new public group functions in 1.9. The new functions live in /lib/grouplib.php, and Quickmail needs to be updated to use these functions instead. The big difference between these and the 1.8 versions is that they return an array of group objects, rather than just a simple array of group ids. The quickmail code is expecting the later, so I whipped up a patch that uses the new functions, then uses array_values to strip out the group ids and throw them into the $groups array. I'm not sure what the Moodle 1.9 way of fetching group ids from group objects is; I'd appreciate it if someone could post the recommended way of getting this information. This patch will break the 1.8 version of quickmail, so a production version would likely need some logic to figure out what version it was working under (or need to be explicitly labeled as being for 1.9). Using this patch I was able to: 1) Eliminate the white screen. 2) Get groups working again with separate and visible groups.
          Hide
          Wen Hao Chuang added a comment - - edited

          There is another alternative patch provided by Nicolas (see: http://moodle.org/mod/forum/discuss.php?d=93176). I tested it and it seems to be working fine. I have also attached this file here. It works for the original "quickmail." If Mark is no longer maintaining the "quickmail" I could commit the changes into the quickmali CONTRIB folder. Let me know if anyone could help QA the new email.php and make sure it works without any problem before I commit it to CVS, thanks!

          Show
          Wen Hao Chuang added a comment - - edited There is another alternative patch provided by Nicolas (see: http://moodle.org/mod/forum/discuss.php?d=93176 ). I tested it and it seems to be working fine. I have also attached this file here. It works for the original "quickmail." If Mark is no longer maintaining the "quickmail" I could commit the changes into the quickmali CONTRIB folder. Let me know if anyone could help QA the new email.php and make sure it works without any problem before I commit it to CVS, thanks!
          Hide
          Kenneth Newquist added a comment -

          I tested Nicholas' patch, and it worked fine under Moodle 1.9.1 (Build: 20080515); no white screen, groups appear as they should.

          Ken

          Show
          Kenneth Newquist added a comment - I tested Nicholas' patch, and it worked fine under Moodle 1.9.1 (Build: 20080515); no white screen, groups appear as they should. Ken
          Hide
          Caroline Moore added a comment -

          I've also tested Nicolas' updated email.php file, and it works perfectly for me under 1.9 on two separate Moodle instances.

          Show
          Caroline Moore added a comment - I've also tested Nicolas' updated email.php file, and it works perfectly for me under 1.9 on two separate Moodle instances.
          Hide
          David Brighton added a comment -

          I could not get this to work. I have changed the email.php file as described above, but still not visible on student log in, groups setting does not seem to affect it either. I am using Moodle 1.9.2 (20080730) MySQL 5.0.22 & php 5.1.4. I can get access as a student if I override their role for quickmail to that of a teacher.

          David

          Show
          David Brighton added a comment - I could not get this to work. I have changed the email.php file as described above, but still not visible on student log in, groups setting does not seem to affect it either. I am using Moodle 1.9.2 (20080730) MySQL 5.0.22 & php 5.1.4. I can get access as a student if I override their role for quickmail to that of a teacher. David
          Hide
          Allan Macfadyen added a comment -

          The email.php from Nicloas fixed our Call to undefined function groups_get_groups() Quickmail problem following a 1.7 to 1.9 upgrade.

          Show
          Allan Macfadyen added a comment - The email.php from Nicloas fixed our Call to undefined function groups_get_groups() Quickmail problem following a 1.7 to 1.9 upgrade.
          Hide
          Scott Krajewski added a comment -

          The email.php files seems to fix the view when an admin or instructor but when a student views it with separate groups the code still calls groups_get_groups_for_current_user(). I changed it to call groups_get_user_groups() instead but I'm not seeing the group(s) that the student is in.

          Show
          Scott Krajewski added a comment - The email.php files seems to fix the view when an admin or instructor but when a student views it with separate groups the code still calls groups_get_groups_for_current_user(). I changed it to call groups_get_user_groups() instead but I'm not seeing the group(s) that the student is in.
          Hide
          Wen Hao Chuang added a comment -

          so Scott do you have a working patch that solved this groups issue? If so could you upload the attachment so that I could take a look? Thanks!

          Show
          Wen Hao Chuang added a comment - so Scott do you have a working patch that solved this groups issue? If so could you upload the attachment so that I could take a look? Thanks!
          Hide
          Neil Streeter added a comment -

          I sat down tonight and hopefully updated quickmail so that it works with our version of moodle... 1.9.2+ – The patch (attached along with my final email.php file) will make quickmail work with all group types... I hope... It has not been extensively tested but it seems to work thus far... Please comment as to whether it works for you or not...

          Neil Streeter
          eLearning Systems Administrator
          Northwestern Michigan College

          Show
          Neil Streeter added a comment - I sat down tonight and hopefully updated quickmail so that it works with our version of moodle... 1.9.2+ – The patch (attached along with my final email.php file) will make quickmail work with all group types... I hope... It has not been extensively tested but it seems to work thus far... Please comment as to whether it works for you or not... Neil Streeter eLearning Systems Administrator Northwestern Michigan College
          Hide
          Neil Streeter added a comment -

          hopefully updates quickmail for 1.9...

          Show
          Neil Streeter added a comment - hopefully updates quickmail for 1.9...
          Hide
          Scott Krajewski added a comment -

          Neil's file makes quickmail work for me both as instructor as student in a regular course. However I have noticed that in meta-courses the groups do not show up in quickmail, all people are listed as though there are no groups even though there are groups.

          Show
          Scott Krajewski added a comment - Neil's file makes quickmail work for me both as instructor as student in a regular course. However I have noticed that in meta-courses the groups do not show up in quickmail, all people are listed as though there are no groups even though there are groups.
          Hide
          Jared Stein added a comment -

          I can confirm that on our 1.9 Quickmail does not work in meta courses with groups turned on. However, Editing the Quickmail block directly and turning groups to "none" allows Quickmail to work again--just not group distinction.

          Show
          Jared Stein added a comment - I can confirm that on our 1.9 Quickmail does not work in meta courses with groups turned on. However, Editing the Quickmail block directly and turning groups to "none" allows Quickmail to work again--just not group distinction.
          Hide
          Neil Streeter added a comment -

          I will take a look at fixing meta courses next week... We will have this issue too - just haven't noticed it yet.... so I suppose I better fix it. Once I fix it I will post the results back here.

          Neil

          Show
          Neil Streeter added a comment - I will take a look at fixing meta courses next week... We will have this issue too - just haven't noticed it yet.... so I suppose I better fix it. Once I fix it I will post the results back here. Neil
          Hide
          Neil Streeter added a comment -

          Are you using 'groups of groups' by chance? I'm not sure it behaves correctly with group of groups enabled... I can not reproduce the behavior that Jared and Scott note... My groups show correctly in meta courses too. Be sure the only modified quickmail file is email.php none of the other files need to be changed. Can you list the steps to reproduce the behavior you see?

          Thanks,
          Neil

          Show
          Neil Streeter added a comment - Are you using 'groups of groups' by chance? I'm not sure it behaves correctly with group of groups enabled... I can not reproduce the behavior that Jared and Scott note... My groups show correctly in meta courses too. Be sure the only modified quickmail file is email.php none of the other files need to be changed. Can you list the steps to reproduce the behavior you see? Thanks, Neil
          Hide
          Jared Stein added a comment - - edited

          Neil, when you say "group of groups" you're referring to "Groupings", right? Yes, we do have this "experimental" feature enabled at the admin level (but not at the course level where we are seeing the Quickmail trouble). I did the following based on your directions.

          After disabling "Groupings" in the admin GUI I did the following:
          Went into a Meta course with groups enabled
          Edited Quickmail, setting Groups back to "Separate"
          Went back to the course > Quickmail > Compose
          Result: blank window with no source code.

          We haven't modified email.php on our server yet with the above patch. Should we do so now and re-test?

          Show
          Jared Stein added a comment - - edited Neil, when you say "group of groups" you're referring to "Groupings", right? Yes, we do have this "experimental" feature enabled at the admin level (but not at the course level where we are seeing the Quickmail trouble). I did the following based on your directions. After disabling "Groupings" in the admin GUI I did the following: Went into a Meta course with groups enabled Edited Quickmail, setting Groups back to "Separate" Went back to the course > Quickmail > Compose Result: blank window with no source code. We haven't modified email.php on our server yet with the above patch. Should we do so now and re-test?
          Hide
          Neil Streeter added a comment -

          Jared,

          You will need to replace the email.php file that came with quickmail with the one I attached here on 20/Aug/2008 (or, alternatively, apply the .diff patch).

          The blank screen is due to the fact that the API for getting group members has changed in 1.9 so some function calls needed to be updated in the email.php file.

          Take care,
          Neil

          Show
          Neil Streeter added a comment - Jared, You will need to replace the email.php file that came with quickmail with the one I attached here on 20/Aug/2008 (or, alternatively, apply the .diff patch). The blank screen is due to the fact that the API for getting group members has changed in 1.9 so some function calls needed to be updated in the email.php file. Take care, Neil
          Hide
          Wen Hao Chuang added a comment -

          I have also added Anthony (the CONTRIB coordinator) to the watch list.

          I have emailed Mark but haven't heard back from him yet. I have discussed with Anthony and will be happy to co-maintain this block with Mark. After I do some more testing I will be happy to commit the changes that Scott and Nicloas made into the CONTRIB folder.

          At the same time, here at SFSU, we are planning for our next internal major release, which is scheduled to be released in December 2008. This release will also cover some improvements for quickmail. If people have some comments or features requests for the quickmail (or "quickmail for large classes") please email me (whchuang at gmail dot com). Thanks!

          Show
          Wen Hao Chuang added a comment - I have also added Anthony (the CONTRIB coordinator) to the watch list. I have emailed Mark but haven't heard back from him yet. I have discussed with Anthony and will be happy to co-maintain this block with Mark. After I do some more testing I will be happy to commit the changes that Scott and Nicloas made into the CONTRIB folder. At the same time, here at SFSU, we are planning for our next internal major release, which is scheduled to be released in December 2008. This release will also cover some improvements for quickmail. If people have some comments or features requests for the quickmail (or "quickmail for large classes") please email me (whchuang at gmail dot com). Thanks!
          Hide
          Anthony Borrow added a comment -

          Wen - I too have sent Mark a message and will let you know when I hear back from him. He is welcome to comment here in the tracker as well. Peace - Anthony

          Show
          Anthony Borrow added a comment - Wen - I too have sent Mark a message and will let you know when I hear back from him. He is welcome to comment here in the tracker as well. Peace - Anthony
          Hide
          Wen Hao Chuang added a comment -

          OK, Mark has agreed that I co-maintain the quickmail block and I have tested Neil's patch - seems to work great. So I have committed this patch to the CONTRIB folder. Thanks for Neil and everyone's help about this issue. So #2 and #3 seems to be fixed now, did anyone get a chance to verify #1 issue (breadcrumb) still exist? Thanks!

          Show
          Wen Hao Chuang added a comment - OK, Mark has agreed that I co-maintain the quickmail block and I have tested Neil's patch - seems to work great. So I have committed this patch to the CONTRIB folder. Thanks for Neil and everyone's help about this issue. So #2 and #3 seems to be fixed now, did anyone get a chance to verify #1 issue (breadcrumb) still exist? Thanks!
          Hide
          Neil Streeter added a comment -

          I can not reproduce any inconsistency in the breadcrumb trail when quickmail is enabled. Perhaps at one point there was a lang string missing or malformed? I am not sure what would cause the text mentioned in #1 to be displayed.

          Take care,
          Neil

          Show
          Neil Streeter added a comment - I can not reproduce any inconsistency in the breadcrumb trail when quickmail is enabled. Perhaps at one point there was a lang string missing or malformed? I am not sure what would cause the text mentioned in #1 to be displayed. Take care, Neil
          Hide
          Wen Hao Chuang added a comment -

          Dear all, I just did some more testing and found that if I enable the Debugging mode (Site administration -> Server -> Debugging) to NORMAL, when I access the quickmail block (with the new email.php), I would get some warning/error messages (see attached screenshot). Could someone please confirm this? Thanks!

          Show
          Wen Hao Chuang added a comment - Dear all, I just did some more testing and found that if I enable the Debugging mode (Site administration -> Server -> Debugging) to NORMAL, when I access the quickmail block (with the new email.php), I would get some warning/error messages (see attached screenshot). Could someone please confirm this? Thanks!
          Hide
          Kenneth Newquist added a comment -

          I realized this is fixed in CVS, but can this be rolled into the "Module/Blocks" downloads section as well? The 'Latest Version' there doesn't include these changes.

          Show
          Kenneth Newquist added a comment - I realized this is fixed in CVS, but can this be rolled into the "Module/Blocks" downloads section as well? The 'Latest Version' there doesn't include these changes.
          Hide
          Anthony Borrow added a comment -

          Kenneth - I'm not sure exactly what you are asking. When you say the "Module/Blocks" downloads what are you referring to? Sorry for being so dense but I coming to the end of an exhausting semester of studies and my brain is maxed out. Perhaps if you provided a URL I could go and see what you are talking about. Peace - Anthony

          Show
          Anthony Borrow added a comment - Kenneth - I'm not sure exactly what you are asking. When you say the "Module/Blocks" downloads what are you referring to? Sorry for being so dense but I coming to the end of an exhausting semester of studies and my brain is maxed out. Perhaps if you provided a URL I could go and see what you are talking about. Peace - Anthony
          Hide
          Kenneth Newquist added a comment -

          Sorry, I meant the "Modules and Plugins" database:

          http://moodle.org/mod/data/view.php?id=6009

          When you look at the "Quickmail" entry in the database and click on the link for "Download Latest Version" you'll see that the latest version it refers to doesn't include this the 1.19.2.1 revision to email.php, which is in CVS.

          Ken

          Show
          Kenneth Newquist added a comment - Sorry, I meant the "Modules and Plugins" database: http://moodle.org/mod/data/view.php?id=6009 When you look at the "Quickmail" entry in the database and click on the link for "Download Latest Version" you'll see that the latest version it refers to doesn't include this the 1.19.2.1 revision to email.php, which is in CVS. Ken
          Hide
          Anthony Borrow added a comment -

          Ken - I've gone in and looked at the email.php file which was modified in the 19STABLE branch which I believe (if memory serves me correctly) is the one that Wen is maintaining for large classes. The file has not been updated in the HEAD branch (only in 19STABLE). So if you want the download you will need to use: http://download.moodle.org/download.php/plugins19/blocks/quickmail.zip. Does that make sense? I'm not sure if Wen wants to also apply the changes to HEAD. I don't remember if perhaps HEAD was being maintained by someone else. Peace - Anthony

          Show
          Anthony Borrow added a comment - Ken - I've gone in and looked at the email.php file which was modified in the 19STABLE branch which I believe (if memory serves me correctly) is the one that Wen is maintaining for large classes. The file has not been updated in the HEAD branch (only in 19STABLE). So if you want the download you will need to use: http://download.moodle.org/download.php/plugins19/blocks/quickmail.zip . Does that make sense? I'm not sure if Wen wants to also apply the changes to HEAD. I don't remember if perhaps HEAD was being maintained by someone else. Peace - Anthony
          Hide
          Wen Hao Chuang added a comment -

          Kenneth, thanks for the feedback. Anthony, I also sent you a email. I have no idea how the quickmail.zip on download.moodle.org got generated. Are they generated automatically from moodle CVS? I don't think I have direct access to the download.moodle.org area yet.. thanks!

          Show
          Wen Hao Chuang added a comment - Kenneth, thanks for the feedback. Anthony, I also sent you a email. I have no idea how the quickmail.zip on download.moodle.org got generated. Are they generated automatically from moodle CVS? I don't think I have direct access to the download.moodle.org area yet.. thanks!
          Hide
          mirek added a comment -

          last night i was playing with the quickmail block on my running 1.9.2 (Build: 20080711). i love quickmail and we used it very often on our 1.8.x installation, so i was sad, that the last downloadable build was not working on 1.9.x after upgrade because of the groupping problem.

          so i tryed the version http://download.moodle.org/download.php/plugins19/blocks/quickmail.zip (http://cvs.moodle.org is not working) and great - everything is working until i started switching the groupping modes. i found two bugs:

          1. the lines 267 and 268 - variable $group is used not correctly, because there is error about accessing to the $group as object and in the second line, where you are trying to access to the $group as not object. so i added simple is_object() checking.

          2. again - object problem but from inside of the print_group_picture() function. so the solution is again - remove original line 286 and modify original line 287 into:
          $cell1 .= print_group_picture($group, $course->id, false, true).'<br />';
          problem was, that the original value $groupobj contains only the name of the group and the function print_group_picture() access to this variable as to the object

          this works for me. i upload the file in here, so - hope - it will help.

          Show
          mirek added a comment - last night i was playing with the quickmail block on my running 1.9.2 (Build: 20080711). i love quickmail and we used it very often on our 1.8.x installation, so i was sad, that the last downloadable build was not working on 1.9.x after upgrade because of the groupping problem. so i tryed the version http://download.moodle.org/download.php/plugins19/blocks/quickmail.zip ( http://cvs.moodle.org is not working) and great - everything is working until i started switching the groupping modes. i found two bugs: 1. the lines 267 and 268 - variable $group is used not correctly, because there is error about accessing to the $group as object and in the second line, where you are trying to access to the $group as not object. so i added simple is_object() checking. 2. again - object problem but from inside of the print_group_picture() function. so the solution is again - remove original line 286 and modify original line 287 into: $cell1 .= print_group_picture($group, $course->id, false, true).'<br />'; problem was, that the original value $groupobj contains only the name of the group and the function print_group_picture() access to this variable as to the object this works for me. i upload the file in here, so - hope - it will help.
          Hide
          mirek added a comment -

          fixed two problems:

          1. the lines 267 and 268 - variable $group is used not correctly, because there is error about accessing to the $group as object and in the second line, where you are trying to access to the $group as not object. so i added simple is_object() checking.

          2. again - object problem but from inside of the print_group_picture() function. so the solution is again - remove original line 286 and modify original line 287 into:
          $cell1 .= print_group_picture($group, $course->id, false, true).'<br />';
          problem was, that the original value $groupobj contains only the name of the group and the function print_group_picture() access to this variable as to the object

          Show
          mirek added a comment - fixed two problems: 1. the lines 267 and 268 - variable $group is used not correctly, because there is error about accessing to the $group as object and in the second line, where you are trying to access to the $group as not object. so i added simple is_object() checking. 2. again - object problem but from inside of the print_group_picture() function. so the solution is again - remove original line 286 and modify original line 287 into: $cell1 .= print_group_picture($group, $course->id, false, true).'<br />'; problem was, that the original value $groupobj contains only the name of the group and the function print_group_picture() access to this variable as to the object
          Hide
          Wen Hao Chuang added a comment -

          Thanks for mirek's patch. I commited it into the CONTRIB just now (sorry for the delay). I tested it a little bit but Anthony if you get a chance could you please also help out testing it a little bit too? Thanks a lot!

          Note this is for the original quickmail block. For the "quickmail for large course" block we intentionally disabled the group feature. I believe moodleroom has a version that sort of combined the two, Mark when you get a chance do you think maybe you could post it here or email it to me? Thanks!

          Show
          Wen Hao Chuang added a comment - Thanks for mirek's patch. I commited it into the CONTRIB just now (sorry for the delay). I tested it a little bit but Anthony if you get a chance could you please also help out testing it a little bit too? Thanks a lot! Note this is for the original quickmail block. For the "quickmail for large course" block we intentionally disabled the group feature. I believe moodleroom has a version that sort of combined the two, Mark when you get a chance do you think maybe you could post it here or email it to me? Thanks!
          Hide
          Anthony Borrow added a comment -

          Wen - I am still swamped at the moment and will not be able to do any testing on this at the moment. If you still need some help with testing give me a call next week. Peace - Anthony

          Show
          Anthony Borrow added a comment - Wen - I am still swamped at the moment and will not be able to do any testing on this at the moment. If you still need some help with testing give me a call next week. Peace - Anthony
          Hide
          Anthony Borrow added a comment -

          After speaking with Wen, it would be good if we could focus on creating one good, solid quick mail block that addresses the issues with groups. From what I can tell there are not competing or mutually exclusive needs between LSU, SFSU, and MoodleRooms so I think collaboration between Mark, Robert, and Wen would be best. Robert Russo (LSU) recently emailed me some code which I have asked Wen to review. Perhaps what we can do is use the HEAD version of contrib/plugins/blocks/quickmail as a development version where each of you can work on resolving various issues. I would encourage you to make good use of the tracker so that there is good documentation of what all is being changed, by whom, and why. Then once there is agreement between the three of you changes can be merged back into the 19STABLE branch. If Wen, Mark and Robert are in agreement then we could avoid creating a separate quickmail_for_large_classes as requested in CONTRIB-694. I'm going to upload the zip file that Robert sent and also create a diff file so that folks can see what changes Robert and his team at LSU have made and suggest. I realize that collaborating takes a little extra effort; however, long term I believe that it will be in everyone's best interests. Please let me know if you have any comments/questions/concerns, etc. Peace - Anthony

          Show
          Anthony Borrow added a comment - After speaking with Wen, it would be good if we could focus on creating one good, solid quick mail block that addresses the issues with groups. From what I can tell there are not competing or mutually exclusive needs between LSU, SFSU, and MoodleRooms so I think collaboration between Mark, Robert, and Wen would be best. Robert Russo (LSU) recently emailed me some code which I have asked Wen to review. Perhaps what we can do is use the HEAD version of contrib/plugins/blocks/quickmail as a development version where each of you can work on resolving various issues. I would encourage you to make good use of the tracker so that there is good documentation of what all is being changed, by whom, and why. Then once there is agreement between the three of you changes can be merged back into the 19STABLE branch. If Wen, Mark and Robert are in agreement then we could avoid creating a separate quickmail_for_large_classes as requested in CONTRIB-694 . I'm going to upload the zip file that Robert sent and also create a diff file so that folks can see what changes Robert and his team at LSU have made and suggest. I realize that collaborating takes a little extra effort; however, long term I believe that it will be in everyone's best interests. Please let me know if you have any comments/questions/concerns, etc. Peace - Anthony
          Hide
          Anthony Borrow added a comment -

          Updated quickmail block submitted by Robert Russo (LSU).

          Show
          Anthony Borrow added a comment - Updated quickmail block submitted by Robert Russo (LSU).
          Hide
          Anthony Borrow added a comment -

          Here is a diff file between what is currently in HEAD for contrib/plugins/blocks/quickmail and the zip flie that Robert Russo (LSU) submitted to me via email. If Wen and Mark could review and test the changes and work through any areas of concern that would help. Wen seemed to have a positive initial reaction to the work Robert and Philip Cali did and is also hoping to do some of his own. Again, I would encourage each of you to create tracker issues and add each other as watchers for the changes you are working on as the tracker does provide for good documentation. By having various issues, i.e. one for each change, each feature or improvement can be discussed and agreed up on and then merged into the 19STABLE version. As always, let me know if there are questions or how I can be of assistance. If it is OK with Mark, I think it might be a good idea to add Robert and Philip to the list of folks with write access to contrib/plugins/blocks/quickmail. But I will wait for confirmation from Mark before proceeding with that. Peace - Anthony

          Show
          Anthony Borrow added a comment - Here is a diff file between what is currently in HEAD for contrib/plugins/blocks/quickmail and the zip flie that Robert Russo (LSU) submitted to me via email. If Wen and Mark could review and test the changes and work through any areas of concern that would help. Wen seemed to have a positive initial reaction to the work Robert and Philip Cali did and is also hoping to do some of his own. Again, I would encourage each of you to create tracker issues and add each other as watchers for the changes you are working on as the tracker does provide for good documentation. By having various issues, i.e. one for each change, each feature or improvement can be discussed and agreed up on and then merged into the 19STABLE version. As always, let me know if there are questions or how I can be of assistance. If it is OK with Mark, I think it might be a good idea to add Robert and Philip to the list of folks with write access to contrib/plugins/blocks/quickmail. But I will wait for confirmation from Mark before proceeding with that. Peace - Anthony
          Hide
          Anthony Borrow added a comment -

          I've added Mark, Robert, and Philip to the list of watchers of this issue so that they can comment here about the suggestions I've made about how to proceed with maintaining the quickmail block. Thanks to all of you for your work on this code. I am hoping that collaborating together we can make it better for everyone and produce one, good, solid block. Peace - Anthony

          Show
          Anthony Borrow added a comment - I've added Mark, Robert, and Philip to the list of watchers of this issue so that they can comment here about the suggestions I've made about how to proceed with maintaining the quickmail block. Thanks to all of you for your work on this code. I am hoping that collaborating together we can make it better for everyone and produce one, good, solid block. Peace - Anthony
          Hide
          Wen Hao Chuang added a comment -

          Hi Anthony, as you prefer to have communication here in the Tracker, here are my 2 cents:

          I would humbly suggest to have two folders in CONTRIB, one called quickmailv1 (which refer to the original quickmail block, with the "checkbox" type of GUI), the other called "quickmailv2" (which has the improved GUI and is more consistent with moodle standard GUI, and is more user friendly for larger courses). The "quickmailv2" one is also known as "quickmail for large classes" or "Quickmail v2", and is different from the "original" quickmail block.

          The quickmail v2 currently only enjoy a entry on the moodle Modules and plugins downloading page, and I was never able to get the quickmail_for_large_classes folder to work under CONTRIB (as you mentioned, it was pruned because it was empty, but I was never able to commit codes into this folder):

          http://moodle.org/mod/data/view.php?d=13&rid=764&filter=1

          The reason for this is that based on my observation (as the maintainer of these two blocks for a while now), there ARE still quite a few groups out there who are still using the original Quickmail block (v1) because they didn't find the "checkbox" type of GUI bothering them, and the original quickmail (generally speaking) was more responsive in terms of the GROUPS support. While the quickmailv2 (aka the "Quickmail for large classes") was initially developed here at SFSU, and we intentionally disabled the GROUP support based on our context. So although it (v2) might be more user-friendly (GUI-wise) and might be more popular than the original quickmailv1 (based on the email feedback that I got in the past), but some folks were shy away as it (v2) did not provide GROUPS support right out of the box.

          Personally, as much as I would like to consolidate and avoid confusion for all Quickmail users, I think it probably would be a good idea (as least for the near future) to keep these two projects separate, simply because they seem to have their own supporting user groups. If we suddenly remove the original quickmail and replace it with the the quickmailv2 (with totally new GUI), this might create some surprises for some user groups. Notice that Robert Russo (LSU)'s quickmail improvement (with GROUPS support) was based on the quickmailv2 work, NOT the quickmailv1, and that's why when you generated that diff file (dated 4/10/09), it created a HUGE diff file, as you were diffing two different projects.

          Again don't know if this make sense or not, sorry for the long comments. Again this is just my 2 cents. Hope this helps!

          By the way, thanks to Russo for doing such a wonderful GUI design for the GROUPS support (for v2), that design is just brilliant! We were trying to come up with a design mockup for GROUPS support for v2 but never thought of doing it this way... Good job Russo!!

          Show
          Wen Hao Chuang added a comment - Hi Anthony, as you prefer to have communication here in the Tracker, here are my 2 cents: I would humbly suggest to have two folders in CONTRIB, one called quickmailv1 (which refer to the original quickmail block, with the "checkbox" type of GUI), the other called "quickmailv2" (which has the improved GUI and is more consistent with moodle standard GUI, and is more user friendly for larger courses). The "quickmailv2" one is also known as "quickmail for large classes" or "Quickmail v2", and is different from the "original" quickmail block. The quickmail v2 currently only enjoy a entry on the moodle Modules and plugins downloading page, and I was never able to get the quickmail_for_large_classes folder to work under CONTRIB (as you mentioned, it was pruned because it was empty, but I was never able to commit codes into this folder): http://moodle.org/mod/data/view.php?d=13&rid=764&filter=1 The reason for this is that based on my observation (as the maintainer of these two blocks for a while now), there ARE still quite a few groups out there who are still using the original Quickmail block (v1) because they didn't find the "checkbox" type of GUI bothering them, and the original quickmail (generally speaking) was more responsive in terms of the GROUPS support. While the quickmailv2 (aka the "Quickmail for large classes") was initially developed here at SFSU, and we intentionally disabled the GROUP support based on our context. So although it (v2) might be more user-friendly (GUI-wise) and might be more popular than the original quickmailv1 (based on the email feedback that I got in the past), but some folks were shy away as it (v2) did not provide GROUPS support right out of the box. Personally, as much as I would like to consolidate and avoid confusion for all Quickmail users, I think it probably would be a good idea (as least for the near future) to keep these two projects separate, simply because they seem to have their own supporting user groups. If we suddenly remove the original quickmail and replace it with the the quickmailv2 (with totally new GUI), this might create some surprises for some user groups. Notice that Robert Russo (LSU)'s quickmail improvement (with GROUPS support) was based on the quickmailv2 work, NOT the quickmailv1, and that's why when you generated that diff file (dated 4/10/09), it created a HUGE diff file, as you were diffing two different projects. Again don't know if this make sense or not, sorry for the long comments. Again this is just my 2 cents. Hope this helps! By the way, thanks to Russo for doing such a wonderful GUI design for the GROUPS support (for v2), that design is just brilliant! We were trying to come up with a design mockup for GROUPS support for v2 but never thought of doing it this way... Good job Russo!!

            People

            • Votes:
              21 Vote for this issue
              Watchers:
              18 Start watching this issue

              Dates

              • Created:
                Updated:

                Development