Details

    • Type: Task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.16
    • Fix Version/s: 1.9.19
    • Component/s: Module: HotPot
    • Labels:
      None

      Description

      Gordon has supplied the latest version of the HotPot module so that it can be integrated into 1.9 before support ends.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              xxxxxxx Gordon Bateson added a comment -

              Great - thanks for setting this up Michael.

              Show
              xxxxxxx Gordon Bateson added a comment - Great - thanks for setting this up Michael.
              Hide
              abgreeve Adrian Greeve added a comment -

              A git branch for this has been created and I also removed some of the white space so that it will pass through integration.

              Show
              abgreeve Adrian Greeve added a comment - A git branch for this has been created and I also removed some of the white space so that it will pass through integration.
              Hide
              salvetore Michael de Raadt added a comment -

              Just looking at the code. This might need to have its version updated.

              Gordon, could you supply a hot potatoes file so we can test this?

              Show
              salvetore Michael de Raadt added a comment - Just looking at the code. This might need to have its version updated. Gordon, could you supply a hot potatoes file so we can test this?
              Hide
              xxxxxxx Gordon Bateson added a comment -

              Uploaded the "hotpot.zip" file which includes simple samples of each of the 5 types of Hot Potatoes quiz.

              Show
              xxxxxxx Gordon Bateson added a comment - Uploaded the "hotpot.zip" file which includes simple samples of each of the 5 types of Hot Potatoes quiz.
              Hide
              salvetore Michael de Raadt added a comment -

              Great. Thanks Gordon.

              I'll test this and see if we can get this integrated.

              Show
              salvetore Michael de Raadt added a comment - Great. Thanks Gordon. I'll test this and see if we can get this integrated.
              Hide
              salvetore Michael de Raadt added a comment -

              OK. I've had a chance to review and test this new version.

              The code looks fine to me. Most of the changes are innocuous language/help changes. The other changes seem OK. They don't conform completely to what we would expect of HQ programmers, but this module has never been maintained by us, so that is fine as far as I'm concerned.

              Functionally, the different types of questions seem to be working fine. I tested each of the samples Gordon supplied and they worked fine. I'm going to add some testing instructions to this issue, but I'd also be OK if this skipped testing.

              Show
              salvetore Michael de Raadt added a comment - OK. I've had a chance to review and test this new version. The code looks fine to me. Most of the changes are innocuous language/help changes. The other changes seem OK. They don't conform completely to what we would expect of HQ programmers, but this module has never been maintained by us, so that is fine as far as I'm concerned. Functionally, the different types of questions seem to be working fine. I tested each of the samples Gordon supplied and they worked fine. I'm going to add some testing instructions to this issue, but I'd also be OK if this skipped testing.
              Hide
              salvetore Michael de Raadt added a comment -

              Testing instructions:

              1. Update Moodle 1.9 to latest integration
              2. Log in as an admin
              3. Navigate to the site home page
              4. Navigate to Site admin > Server > Debugging and set the debugging level to the second highest level (All: ...)
              5. Navigate to Site admin > Modules > Activities > Manage activities
              6. Unhide the Hot Potatoes module
              7. Navigate to the site home page
              8. Navigate to a course
              9. Download the zip file attached to this issue and extract the files on your computer
              10. Add a Hot Potatoes Quiz activity from the Activities menu
              11. In the module configuration, next to File name click Choose or upload a file
              12. In the file browser click Upload a file
              13. Click browse and upload one of the extracted files
              14. Back in the file browser, click Choose next to the new file
              15. Back in the configuration, scroll to the bottom and click Save and display
              16. Test the quiz (it is a single question that should be easy)
              17. Repeat the last seven steps for each of the other extracted files, each representing a different type of question
              18. Navigate back to the course
              19. In the activities menu, click Hot Potatoes Quiz and see the instances collectively
              20. Click to view a report for one of the quizzes
              21. Try adjusting the settings for the report
              22. Export a report to text and Excel formats by altering the Format option in the report
              23. Navigate back to the course
              24. Click on Hot Potatoes Quiz in the Activities menu
              25. Regrade one of the quizzes
              Show
              salvetore Michael de Raadt added a comment - Testing instructions: Update Moodle 1.9 to latest integration Log in as an admin Navigate to the site home page Navigate to Site admin > Server > Debugging and set the debugging level to the second highest level (All: ...) Navigate to Site admin > Modules > Activities > Manage activities Unhide the Hot Potatoes module Navigate to the site home page Navigate to a course Download the zip file attached to this issue and extract the files on your computer Add a Hot Potatoes Quiz activity from the Activities menu In the module configuration, next to File name click Choose or upload a file In the file browser click Upload a file Click browse and upload one of the extracted files Back in the file browser, click Choose next to the new file Back in the configuration, scroll to the bottom and click Save and display Test the quiz (it is a single question that should be easy) Repeat the last seven steps for each of the other extracted files, each representing a different type of question Navigate back to the course In the activities menu, click Hot Potatoes Quiz and see the instances collectively Click to view a report for one of the quizzes Try adjusting the settings for the report Export a report to text and Excel formats by altering the Format option in the report Navigate back to the course Click on Hot Potatoes Quiz in the Activities menu Regrade one of the quizzes
              Hide
              salvetore Michael de Raadt added a comment -

              I was hoping this was going to be integrated a few months ago, but alas...

              I've asked again and hopefully it will happen soon.

              Show
              salvetore Michael de Raadt added a comment - I was hoping this was going to be integrated a few months ago, but alas... I've asked again and hopefully it will happen soon.
              Hide
              xxxxxxx Gordon Bateson added a comment -

              Thanks for you continued hard work on this issue Michael.

              Show
              xxxxxxx Gordon Bateson added a comment - Thanks for you continued hard work on this issue Michael.
              Hide
              dougiamas Martin Dougiamas added a comment -

              Thank you too, Gordon!

              Show
              dougiamas Martin Dougiamas added a comment - Thank you too, Gordon!
              Hide
              nebgor Aparup Banerjee added a comment -

              Hello,
              i've had a quick look and just 1 thing:

              • the $Id$ : i don't think that needs to be updated anymore as we're now using git ($Id$ was for CVS). that should take away updates to lots of files in the current patch.

              ps: I'm adding Dan Marsden here so he can add his say here before putting this through into 1.9

              Show
              nebgor Aparup Banerjee added a comment - Hello, i've had a quick look and just 1 thing: the $Id$ : i don't think that needs to be updated anymore as we're now using git ($Id$ was for CVS). that should take away updates to lots of files in the current patch. ps: I'm adding Dan Marsden here so he can add his say here before putting this through into 1.9
              Hide
              danmarsden Dan Marsden added a comment -

              Thanks Aparup +1 from me!! - although it would be really good if we could strip out the $id stuff before integration if possible. - thanks Gordon!

              Show
              danmarsden Dan Marsden added a comment - Thanks Aparup +1 from me!! - although it would be really good if we could strip out the $id stuff before integration if possible. - thanks Gordon!
              Hide
              nebgor Aparup Banerjee added a comment -

              ok. I've taken out the $Id$ changes. This has been integrated into MOODLE_19_STABLE.

              Feel free to test this! (test instructions provided above by Michael)

              Show
              nebgor Aparup Banerjee added a comment - ok. I've taken out the $Id$ changes. This has been integrated into MOODLE_19_STABLE. Feel free to test this! (test instructions provided above by Michael)
              Hide
              salvetore Michael de Raadt added a comment -

              Thanks for integrating this, Apu. Thanks for your input, Dan. Thanks for helping out, Adrian.

              And a big thanks to Gordon for creating the code and sticking by it.

              Show
              salvetore Michael de Raadt added a comment - Thanks for integrating this, Apu. Thanks for your input, Dan. Thanks for helping out, Adrian. And a big thanks to Gordon for creating the code and sticking by it.
              Hide
              xxxxxxx Gordon Bateson added a comment -

              Sorry to say that the recent commit for the HotPot module in Moodle 1.9 introduced a fatal error in the HotPot restore script (mod/hotpot/restorelib.php)

              Please see CONTRIB-3662 for details of symptoms and fix (easy!)

              Show
              xxxxxxx Gordon Bateson added a comment - Sorry to say that the recent commit for the HotPot module in Moodle 1.9 introduced a fatal error in the HotPot restore script (mod/hotpot/restorelib.php) Please see CONTRIB-3662 for details of symptoms and fix (easy!)

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    9/Jul/12