Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-3628

AJAX_Marking - missing "revert to draft", response files

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.2.2
    • Fix Version/s: None
    • Component/s: Block: AJAX Marking
    • Labels:
      None
    • Affected Branches:
      MOODLE_22_STABLE

      Description

      AJAX_Marking v2.1.5b7 on Firefox 11.

      This may be one problem or two different ones:

      1) The marking window does not have a "Revert to draft"/"prevent new Submissions" button like the grading dialog does.

      2) The list of response files does not load. The spinning circle icon runs until I close the window.

      Javascript error reported as the grading dialog opens:
      Error: YAHOO.util.Event is undefined
      Source File: http://moodle.sstx.org/blocks/ajax_marking/actions/grading_popup.php?userid=1390&coursemoduleid=91&courseid=2&node=20&mode=single
      Line: 239

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            mattgibson Matt Gibson added a comment -

            Hi Brian

            Thanks for the report. I can't reproduce this though. I've added a new 2.2-only beta (2.2.0b1) to the plugins DB that you could try. Perhaps something got corrupted? The file that defines YAHOO.util.Event is included on every Moodle page, so I'm not sure how it could have gone missing.

            Show
            mattgibson Matt Gibson added a comment - Hi Brian Thanks for the report. I can't reproduce this though. I've added a new 2.2-only beta (2.2.0b1) to the plugins DB that you could try. Perhaps something got corrupted? The file that defines YAHOO.util.Event is included on every Moodle page, so I'm not sure how it could have gone missing.
            Hide
            bgray Brian Gray added a comment -

            I installed your new version (2.2.0b1). The Revert to Draft button is now visible, but it does not behave as I expected. I'm still seeing the same problem with the response file section. The cancel button doesn't do what I would expect either, but I don't know if it's what you intended or not. You can see what I'm seeing on this video:

            http://youtu.be/tH0CItL9oQA

            bkg

            Show
            bgray Brian Gray added a comment - I installed your new version (2.2.0b1). The Revert to Draft button is now visible, but it does not behave as I expected. I'm still seeing the same problem with the response file section. The cancel button doesn't do what I would expect either, but I don't know if it's what you intended or not. You can see what I'm seeing on this video: http://youtu.be/tH0CItL9oQA bkg
            Hide
            mattgibson Matt Gibson added a comment -

            Hi Brian

            Thanks for the video - much clearer! There seems to be a javascript problem, but I can't reproduce it. If you could make me a temporary teacher login for your site and message me the details on moodle.org, I can look through the javascript code in my browser, which would be the quickest way to resolve this. Otherwise I can talk you through installing firebug and getting more details.

            Show
            mattgibson Matt Gibson added a comment - Hi Brian Thanks for the video - much clearer! There seems to be a javascript problem, but I can't reproduce it. If you could make me a temporary teacher login for your site and message me the details on moodle.org, I can look through the javascript code in my browser, which would be the quickest way to resolve this. Otherwise I can talk you through installing firebug and getting more details.
            Hide
            bgray Brian Gray added a comment -

            Log-in info is in a private message to you.

            Show
            bgray Brian Gray added a comment - Log-in info is in a private message to you.
            Hide
            mattgibson Matt Gibson added a comment -

            Think I've fixed this now. New code on the way...

            Show
            mattgibson Matt Gibson added a comment - Think I've fixed this now. New code on the way...
            Hide
            mattgibson Matt Gibson added a comment -

            Latest release is uploaded and ought to fix this. Please let me know if not.

            Show
            mattgibson Matt Gibson added a comment - Latest release is uploaded and ought to fix this. Please let me know if not.
            Hide
            bgray Brian Gray added a comment -

            Matt -

            The new version 2.2.0b2 solves mots of the problems, but the Revert to Draft button does not work as expected.

            When I click on the Revert button, the teacher comment is saved and the teacher response file is attached to the assignment, but the assignment is not actually changed to draft mode. I believe that this problem applies only to an Assignment of type Advanced Upload, but that's the type I use the most.

            See it in action: http://youtu.be/oZ8ZMI2wGe4

            Access to my site is still available to you - same details as before. Add assignments and submissions as needed for testing.

            bkg

            Show
            bgray Brian Gray added a comment - Matt - The new version 2.2.0b2 solves mots of the problems, but the Revert to Draft button does not work as expected. When I click on the Revert button, the teacher comment is saved and the teacher response file is attached to the assignment, but the assignment is not actually changed to draft mode. I believe that this problem applies only to an Assignment of type Advanced Upload, but that's the type I use the most. See it in action: http://youtu.be/oZ8ZMI2wGe4 Access to my site is still available to you - same details as before. Add assignments and submissions as needed for testing. bkg

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: