Add-ons
  1. Add-ons
  2. CONTRIB-3681

Call to undefined method mod_forumng_filemanager_evilhack::get_renderer()

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Blocker Blocker
    • Resolution: Unresolved
    • Affects Version/s: 2.3
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Affected Branches:
      MOODLE_23_STABLE
    • Rank:
      41348

      Description

      Not sure if this is an issue with Moodle 2.3 (and forumng not being compatible) or a bug with current ForumNG.

      Have installed the 2.2 Stable branch of forumng and get the following fatal error when trying to view a forum :

      Fatal error: Call to undefined method mod_forumng_filemanager_evilhack::get_renderer() in /home/moodle23/moodle/repository/lib.php on line 2483

        Activity

        Hide
        Sam Marshall added a comment -

        Thanks Martyn. I'm afraid it may be the case that ForumNG is not yet compatible with Moodle 2.3. We are still using Moodle 2.2 here (even on developer systems) and that is likely to be the case until at least August (even on developer systems) and possibly rather later.

        As you can tell there is a nasty hack that ForumNG requires in order to make the file manager work correctly when doing the AJAX forms on the discussion page. It sounds like this has probably broken.

        Show
        Sam Marshall added a comment - Thanks Martyn. I'm afraid it may be the case that ForumNG is not yet compatible with Moodle 2.3. We are still using Moodle 2.2 here (even on developer systems) and that is likely to be the case until at least August (even on developer systems) and possibly rather later. As you can tell there is a nasty hack that ForumNG requires in order to make the file manager work correctly when doing the AJAX forms on the discussion page. It sounds like this has probably broken.
        Hide
        Martyn Colliver added a comment -

        Thanks for replying.
        With our school changing from 1.9 to 2.X for September it seemed sensible to start building with 2.3 (as the benefits outweighed beginning building with dev code seeing that it should be released properly soon).

        Will have a look at your code and see if I can spot the problem - but more likely switch off ForumNG for now.

        Show
        Martyn Colliver added a comment - Thanks for replying. With our school changing from 1.9 to 2.X for September it seemed sensible to start building with 2.3 (as the benefits outweighed beginning building with dev code seeing that it should be released properly soon). Will have a look at your code and see if I can spot the problem - but more likely switch off ForumNG for now.
        Hide
        Ralf Krause added a comment -

        I set this error up to "blocker" because I get nothing but the fatal error in Moodle 2.3 beta (20120618)

        Fatal error: Call to undefined method mod_forumng_filemanager_evilhack_requires::yui2_lib() in /Library/Server/Web/Data/Sites/Default/moodle23/lib/ajax/ajaxlib.php on line 40

        Show
        Ralf Krause added a comment - I set this error up to "blocker" because I get nothing but the fatal error in Moodle 2.3 beta (20120618) Fatal error: Call to undefined method mod_forumng_filemanager_evilhack_requires::yui2_lib() in /Library/Server/Web/Data/Sites/Default/moodle23/lib/ajax/ajaxlib.php on line 40
        Hide
        Sam Marshall added a comment -

        Update on timing: we are now planning to move to Moodle 2.3 in our December release, for which our development period starts in September. So, I will look at and fix any problems related to OU modules (including forumng) in Moodle 2.3 shortly after that in the 'master' branch, with our first stable branch for 2.3 coming in December.

        Show
        Sam Marshall added a comment - Update on timing: we are now planning to move to Moodle 2.3 in our December release, for which our development period starts in September. So, I will look at and fix any problems related to OU modules (including forumng) in Moodle 2.3 shortly after that in the 'master' branch, with our first stable branch for 2.3 coming in December.
        Hide
        David Mudrak added a comment -

        This effectively blocks ForumNG to be tested and reviewed in recent versions. Looking forward to the patch.

        Show
        David Mudrak added a comment - This effectively blocks ForumNG to be tested and reviewed in recent versions. Looking forward to the patch.
        Hide
        Sam Marshall added a comment -

        I intend to rewrite the discussion page of ForumNG to use iframes containing standard Moodle behaviour, removing all the hacks that are necessary to dynamically add the file manager and HTML editor to the page when you click Reply or Edit.

        This is OU bug #4320 and will be addressed during development for our December release, hopefully during the first weeks of that development (which starts next week).

        For anyone who can't wait, please see https://github.com/moodleou/moodle-mod_forumng/pull/4 which includes a patch written by Nigel Cunningham to make ForumNG work on 2.3.

        Show
        Sam Marshall added a comment - I intend to rewrite the discussion page of ForumNG to use iframes containing standard Moodle behaviour, removing all the hacks that are necessary to dynamically add the file manager and HTML editor to the page when you click Reply or Edit. This is OU bug #4320 and will be addressed during development for our December release, hopefully during the first weeks of that development (which starts next week). For anyone who can't wait, please see https://github.com/moodleou/moodle-mod_forumng/pull/4 which includes a patch written by Nigel Cunningham to make ForumNG work on 2.3.
        Hide
        Sam Marshall added a comment -

        This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.

        For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

        Show
        Sam Marshall added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

          People

          • Votes:
            6 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:

              Development