Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-3679 Upgrade code to be E_STRICT compliant
  3. CONTRIB-3700

The lib.php file has several undefined variables

    XMLWordPrintable

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 2.2.3
    • None
    • Enrol: Banner/LMB
    • None
    • MOODLE_22_STABLE

    Description

      For example: process_course_section_tag() has code like:

      unset($course);
      // And then later...
      if (preg_match('{<sourcedid>.*?<source>(.+?)</source>.*?</sourcedid>}is', $tagcontents, $matches)) {
          $course->sourcedidsource = trim($matches[1]);
      }

      $course should be initialized with $course = new stdClass;

      Opening this file with an IDE like Netbeans or PhpStorm will help to identify all of these. There are around 11 give or take a few.

      The ones like the above aren't too bad, but inside email_luminis_error() there are several that are undefined that might break emailing. These are undefined:

      • $user
      • $from
      • $usetrueaddress
      • $replytoname

      Attachments

        Activity

          People

            emerrill Eric Merrill
            bushido Mark Nielsen
            Eric Merrill
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: