Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-4144 META: Code checker 1Q 2014 round
  3. CONTRIB-4163

Implement filtering of results based on diff with upstream branch

    XMLWordPrintable

Details

    • Sub-task
    • Resolution: Fixed
    • Minor
    • 2.5.6
    • 2.3.4, 2.4.1, 2.5
    • Local: Code checker
    • None
    • MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • MOODLE_25_STABLE

    Description

      From CONTRIB-4142:

      Offtopic, about Damyon comment: Well, main problem is that our codebase is plagued of codechecker errors and warnings, and the checker does it job for complete files, not for patches (and the results are always depressing no matter the patch is 100% correct or no).

      I hope the prechecker (that has the ability to restrict output to the patched lines) will help about that.

      Uhm, perhaps we could try to build that in the codechecker, say:

      1. if the site is git-based
      2. add one new setting: "branch base"
      3. extract the lines from the diff
      4. filter the results out
      5. yum!

      Research about it...

      Attachments

        Issue Links

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              stronk7 Eloy Lafuente (stronk7)
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.