Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-4198

Remove inline-css from start_toggle_section_list

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.1
    • Fix Version/s: 2.4.1, 2.4.2
    • Component/s: Course format: Topcoll
    • Labels:
      None
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE

      Description

      Hi Gareth

      First of all, thank you for a great module!

      The function start_toggle_section_list creates inline css, which makes it difficult to style the elements in an other way than the module defines. Instead of using inline css the module should rather add classes to the elements and then use the css defined within the module.

      And example could be:

      if ($this->mymobiletheme == false)

      { $class .= ' float_left'; }

      $attributes['class'] = $class;
      return html_writer::start_tag('ul', $attributes);

      The styles.css should then define the following:

      .course-content ul.float_left

      { float: left; }

        Attachments

          Activity

            People

            Assignee:
            gb2048 Gareth J Barnard
            Reporter:
            henrikthorn Henrik Thorn
            Participants:
            Component watchers:
            Gareth J Barnard
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Jan/13