Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-4374

journal_grades should return NULL if no grade

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.19
    • Fix Version/s: None
    • Component/s: Module: Journal
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_19_STABLE

      Description

      If a journal has Grades set to No grades then the function journal_grades in http://moodle.cvs.sourceforge.net/moodle/moodle/mod/journal/lib.php should return NULL or false. Currently it returns an object with maxgrade set to 0 and grade set to NULL. This has the unwanted effect of making it show up in the gradebook.

      Thus the lines 237 and 238 should be replaced by the single line

      return NULL;

        Attachments

          Activity

            People

            Assignee:
            dougiamas Martin Dougiamas
            Reporter:
            delius Gustav W Delius
            Participants:
            Component watchers:
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: