Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-4436

V2.5.2 of Collapsed Topics breaks backup

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Course format: Topcoll
    • Labels:
      None
    • Workaround:
      Hide

      Revert back to version 2.5.1.1 and restore database from backup prior to upgrade.

      Show
      Revert back to version 2.5.1.1 and restore database from backup prior to upgrade.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE

      Description

      I upgraded to the latest topcol version yesterday. The backups did not finish last night. It happened on both of our servers. In looking at the report the only courses that showed "OK" were the ones not using topcol. The others shows "Unfinished". Nothing else was modified on either of the servers except topcoll.

      Full stack trace:

      Debug info: 
      Error code: setting_invalid_ui_label 
      $a contents:
      Stack trace:
      line 143 of \backup\util\ui\backup_ui_setting.class.php: base_setting_ui_exception thrown
      line 156 of \backup\moodle2\backup_section_task.class.php: call to base_setting_ui->set_label()
      line 132 of \backup\util\plan\base_task.class.php: call to backup_section_task->define_settings()
      line 60 of \backup\util\plan\base_plan.class.php: call to base_task->set_plan()
      line 159 of \backup\moodle2\backup_plan_builder.class.php: call to base_plan->add_task()
      line 186 of \backup\moodle2\backup_plan_builder.class.php: call to backup_plan_builder::build_section_plan()
      line 99 of \backup\moodle2\backup_plan_builder.class.php: call to backup_plan_builder::build_course_plan()
      line 163 of \backup\util\factories\backup_factory.class.php: call to backup_plan_builder::build_plan()
      line 62 of \backup\util\plan\backup_plan.class.php: call to backup_factory::build_plan()
      line 357 of \backup\controller\backup_controller.class.php: call to backup_plan->build()
      line 126 of \backup\controller\backup_controller.class.php: call to backup_controller->load_plan()
      line 84 of \backup\backup.php: call to backup_controller->__construct()
      

      Line 156 of \backup\moodle2\backup_section_task.class.php:

      $section_included->get_ui()->set_label(get_section_name($course, $section));
      

      Issue is when 'get_section_name()' returns odd characters.

      Lines 141-146 of \backup\util\ui\backup_ui_setting.class.php:

          public function set_label($label) {
              if ((string)$label === '' || $label !== clean_param($label, PARAM_TEXT)) {
                  throw new base_setting_ui_exception('setting_invalid_ui_label');
              }
              $this->label = $label;
          }
      

      Also see: https://moodle.org/mod/forum/discuss.php?d=230606

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/May/13