Details
-
Bug
-
Status: Open
-
Minor
-
Resolution: Unresolved
-
2.5.3
-
None
-
None
-
2013022702
-
MOODLE_25_STABLE
Description
We reviewed the Adobe Connect module code before installing it in our Moodle code base and found two functions that are not prefixed:
set_username()
get_connect_username()
To prevent any possible naming conflicts, our suggestion is to rename these as aconnect_set_username() and aconnect_get_username() respectively to be consistent with the other functions in locallib.php.
There are also deprecated functions but these are minor compared to the prefixing. I noticed get_context_instance(), error(), and notify().