Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-4967

Show nonrespondents list doesn't paginate properly

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.6.2
    • None
    • Module: Questionnaire
    • None
    • MOODLE_26_STABLE

    Description

      The list of users should split over several pages if there are more than 20 users to be displayed.

      However in our demo course at the top of the page I see the text: 'Users who have not yet submitted their responses to this questionnaire (23)'

      • there are 23 users listed underneath
      • however, there is also a 'Show all 23' link at the bottom of the table and Page 1|2 navigation at the top and bottom

      If we select page '2' from the page navigation

      • the same 23 users are included in the list
        If we select the 'Show all 23' link I see the same users listed
      • link changes to 'Show 20 per page'
      • Page 1|2 navigation is no longer displaying.

      I think this is because $startpage and $pagecount are defined as false on lines 181 and line 182 but they aren't updated based on the total number of users and the $perpage parameter before the call to questionnaire_get_incomplete_users() and so that query never goes through the array_splice().

      Attachments

        Activity

          People

            rezeau Joseph Rézeau
            jenny-gray Jenny Gray
            Mike Churchward
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: